[HELPWANTED] Building jquery for F24 branch

[Christopher]

Can anybody help me build js-jquery1 for F24? I keep getting some NodeJS
and/or Grunt error with uglify, but only for the F24 branch. I want to
update the package, and I can get all the other branches to build just fine
(including EPEL7, F25, and rawhide), but F24 is broken even before I apply
any updates/changes, and I'm not sure why.

[Tom Hughes]

On 30/11/16 01:02, Christopher wrote:

>  Can anybody help me build js-jquery1 for F24? I keep getting some
> NodeJS
>  and/or Grunt error with uglify, but only for the F24 branch. I want to
>  update the package, and I can get all the other branches to build just
>  fine (including EPEL7, F25, and rawhide), but F24 is broken even before
>  I apply any updates/changes, and I'm not sure why. 
Well the Node.js SIG are probably the people to ask, but I can't see any 
builds on koji, so if you want help you're going to have to point us at 
the build or give us some more information about the error you are seeing.

If you're planning to update from 1.11 to 1.12 then I would have to ask 
if that is even appropriate in a released version anyway...

Tom

-- 
Tom Hughes (tom(a)compton.nu)
http://compton.nu/

[Christopher]

On Tue, Nov 29, 2016 at 8:13 PM Tom Hughes <tom(a)compton.nu&gt; wrote:

>  On 30/11/16 01:02, Christopher wrote:
>
>  > Can anybody help me build js-jquery1 for F24? I keep getting some NodeJS
>  > and/or Grunt error with uglify, but only for the F24 branch. I want to
>  > update the package, and I can get all the other branches to build just
>  > fine (including EPEL7, F25, and rawhide), but F24 is broken even before
>  > I apply any updates/changes, and I'm not sure why.
>
>  Well the Node.js SIG are probably the people to ask, but I can't see any
>  builds on koji, so if you want help you're going to have to point us at
>  the build or give us some more information about the error you are seeing.
>
>  
I figured I'd ask for help first, before spamming this list with details :)
But, the failure is reproducible with mockbuild. Here's a scratch build
which failed: http://koji.fedoraproject.org/koji/taskinfo?taskID=16675312
I can check with the Node.js SIG (I didn't realize such a thing existed).


>  If you're planning to update from 1.11 to 1.12 then I would have
> to ask
>  if that is even appropriate in a released version anyway...
>
>  
That's a good question. I'm not sure. It really depends on what API
changes
upstream is making, and who depends on the js-jquery1 compat package. At
first, I would have said yes, to get the security fix for
https://bugzilla.redhat.com/show_bug.cgi?id=1399547 . However, I now
realize that the patch they had applied to 1.12 for that was never
released, and was instead reverted in all branches before 3.0, which isn't
even packaged (yet) in Fedora. So now, the options are to backport the fix
to the versions in Fedora... or to ignore the issue until we update to 3.0.
Even if we ignore, it doesn't resolve the question about what to do with
the compat packages for jquery1 (and maybe a future compat package for
jquery2).

Whether or not we upgrade or backport a security fix, I can't proceed at
all on the F24 branch right now.


>  Tom
>
>  --
>  Tom Hughes (tom(a)compton.nu)
>  http://compton.nu/
>
>

[Vít Ondruch]

Dne 30.11.2016 v 02:30 Christopher napsal(a):
>  On Tue, Nov 29, 2016 at 8:13 PM Tom Hughes <tom(a)compton.nu
>  <mailto:[e-mail]>> wrote:
>
>   
>
>      If you're planning to update from 1.11 to 1.12 then I would have
>      to ask
>      if that is even appropriate in a released version anyway...
>
>
>  That's a good question. I'm not sure. It really depends on what API
>  changes upstream is making, and who depends on the js-jquery1 compat
>  package. 
rubygem-jquery-rails depends on js-jquery1 [1] and it is already broken
in Rawhide [2]. Updates to jQuery should be synchronized ....


Vít




[1]
http://pkgs.fedoraproject.org/cgit/rpms/rubygem-jquery-rails.git/tree/rub...
[2] https://apps.fedoraproject.org/koschei/package/rubygem-jquery-rails

[Vít Ondruch]

Dne 30.11.2016 v 02:30 Christopher napsal(a):
>  On Tue, Nov 29, 2016 at 8:13 PM Tom Hughes <tom(a)compton.nu
>  <mailto:[e-mail]>> wrote:
>
>      On 30/11/16 01:02, Christopher wrote:
>
>
>   
>
>      If you're planning to update from 1.11 to 1.12 then I would have
>      to ask
>      if that is even appropriate in a released version anyway...
>
>
>  Even if we ignore, it doesn't resolve the question about what to do
>  with the compat packages for jquery1 (and maybe a future compat
>  package for jquery2). 
BTW jquery-rails now bundles jQuery 1, 2 and 3 [1], so I'd appreciate if
there are all versions available in Fedora.


Vít



[1]
https://github.com/rails/jquery-rails/tree/master/vendor/assets/javascripts