Re: rpms/gnokii/F-8 gnokii.spec,1.19,1.20

[Andy Shevchenko]

Hi Bastien Nocera!

 On Thu, Nov 29, 2007 at 08:48:02AM -0500, Bastien Nocera wrote next:

>  And again 
>  --- gnokii.spec	29 Nov 2007 12:50:02 -0000	1.19
>  +++ gnokii.spec	29 Nov 2007 13:47:30 -0000	1.20
>  @@ -138,7 +138,7 @@
>     xmandir=%{_mandir}/man1 docdir=/__docinst
>   
>   mv $RPM_BUILD_ROOT/__docinst .
>  -rm
> __docinst/{README-MacOSX,README-WIN32,packaging-howto,ChangeLog,COPYING,COPYRIGHT,TODO,MAINTAINERS}
>  +rm __docinst/{README-MacOSX,README-WIN32,ChangeLog,COPYING,COPYRIGHT,TODO,MAINTAINERS}
Why did you not use rm -f ?

-- 
With best regards,
Andy Shevchenko.      mailto: andy(a)smile.org.ua

rpms/gnokii/F-8 gnokii.spec,1.19,1.20

[Matthias Clasen]

On Thu, 2007-11-29 at 16:20 +0200, Andy Shevchenko wrote:
>  Hi Bastien Nocera!
>  
>   On Thu, Nov 29, 2007 at 08:48:02AM -0500, Bastien Nocera wrote next:
>  
>  > And again
>  
>  > --- gnokii.spec	29 Nov 2007 12:50:02 -0000	1.19
>  > +++ gnokii.spec	29 Nov 2007 13:47:30 -0000	1.20
>  > @@ -138,7 +138,7 @@
>  >    xmandir=%{_mandir}/man1 docdir=/__docinst
>  >  
>  >  mv $RPM_BUILD_ROOT/__docinst .
>  > -rm
> __docinst/{README-MacOSX,README-WIN32,packaging-howto,ChangeLog,COPYING,COPYRIGHT,TODO,MAINTAINERS}
>  > +rm
> __docinst/{README-MacOSX,README-WIN32,ChangeLog,COPYING,COPYRIGHT,TODO,MAINTAINERS}
>  Why did you not use rm -f ? 
If you use -f, the rm call will not fail, thus the cruft will likely
stay in your spec file forever, even if it is not needed anymore.

It is a bit like using excessive wildcards in your file list...

rpms/gnokii/F-8 gnokii.spec,1.19,1.20

[Bastien Nocera]

On Thu, 2007-11-29 at 09:39 -0500, Matthias Clasen wrote:
>  On Thu, 2007-11-29 at 16:20 +0200, Andy Shevchenko wrote:
>  > Hi Bastien Nocera!
>  > 
>  >  On Thu, Nov 29, 2007 at 08:48:02AM -0500, Bastien Nocera wrote next:
>  > 
>  > > And again
>  > 
>  > > --- gnokii.spec	29 Nov 2007 12:50:02 -0000	1.19
>  > > +++ gnokii.spec	29 Nov 2007 13:47:30 -0000	1.20
>  > > @@ -138,7 +138,7 @@
>  > >    xmandir=%{_mandir}/man1 docdir=/__docinst
>  > >  
>  > >  mv $RPM_BUILD_ROOT/__docinst .
>  > > -rm
> __docinst/{README-MacOSX,README-WIN32,packaging-howto,ChangeLog,COPYING,COPYRIGHT,TODO,MAINTAINERS}
>  > > +rm
> __docinst/{README-MacOSX,README-WIN32,ChangeLog,COPYING,COPYRIGHT,TODO,MAINTAINERS}
>  > Why did you not use rm -f ? 
I actually did in devel.

>  If you use -f, the rm call will not fail, thus the cruft will likely
>  stay in your spec file forever, even if it is not needed anymore.
>  
>  It is a bit like using excessive wildcards in your file list... 
Yep. Hopefully, I'll be able to clean this mess up with the next version
of gnokii, once it's all nicely automake-ified.

Cheers