Galera FTBFS in f33, but same build passes in f32

[Lukas Javorsky]

Hi folks,

I've run into the compilation problem in the Galera package
This problem occurs only on f33 and higher tho.

Here is build performed on Fedora 32:
https://koji.fedoraproject.org/koji/taskinfo?taskID=50232504

And here is the same build, but on Fedora 33:
https://koji.fedoraproject.org/koji/taskinfo?taskID=50232498

Does anyone know what could cause this?
It looks like something that changed in *cc1plus* or *scons *is causing
this, so if you had similar issue, please let me know.

Thanks for any help.
Lukas
-- 
S pozdravom/ Best regards

Lukas Javorsky

Intern, Core service - Databases

Red Hat <https://www.redhat.com>

Purkyňova 115 (TPB-C)

612 00 Brno - Královo Pole

ljavorsk(a)redhat.com
<https://www.redhat.com>

[Paul Howarth]

On Thu, 27 Aug 2020 14:21:03 +0200
Lukas Javorsky <ljavorsk(a)redhat.com&gt; wrote:

>  Hi folks,
>  
>  I've run into the compilation problem in the Galera package
>  This problem occurs only on f33 and higher tho.
>  
>  Here is build performed on Fedora 32:
>  https://koji.fedoraproject.org/koji/taskinfo?taskID=50232504
>  
>  And here is the same build, but on Fedora 33:
>  https://koji.fedoraproject.org/koji/taskinfo?taskID=50232498
>  
>  Does anyone know what could cause this?
>  It looks like something that changed in *cc1plus* or *scons *is
>  causing this, so if you had similar issue, please let me know.
>  
>  Thanks for any help.
>  Lukas 
Looks like you might be hitting
https://bugzilla.redhat.com/show_bug.cgi?id=1850198 (changed api for
fail_if and fail_unless in check), the workaround for which now
introduces warnings, and they are turned to errors by the use of
"-Werror".

Paul.

[Dan Horák]

On Thu, 27 Aug 2020 14:21:03 +0200
Lukas Javorsky <ljavorsk(a)redhat.com&gt; wrote:

>  Hi folks,
>  
>  I've run into the compilation problem in the Galera package
>  This problem occurs only on f33 and higher tho.
>  
>  Here is build performed on Fedora 32:
>  https://koji.fedoraproject.org/koji/taskinfo?taskID=50232504
>  
>  And here is the same build, but on Fedora 33:
>  https://koji.fedoraproject.org/koji/taskinfo?taskID=50232498
>  
>  Does anyone know what could cause this?
>  It looks like something that changed in *cc1plus* or *scons *is causing
>  this, so if you had similar issue, please let me know. 
one difference is that F-33 enabled LTO (new compiler flags added at
the distro level, [1], but as you are building with -Werror, then you
should review the code for real issues.


		Dan

[1] https://fedoraproject.org/wiki/LTOByDefault

[Lukas Javorsky]

>  one difference is that F-33 enabled LTO (new compiler flags added at
>  the distro level, [1], but as you are building with -Werror, then you
>  should review the code for real issues. 
What do you mean by real issues?

On Thu, Aug 27, 2020 at 2:38 PM Dan Horák <dan(a)danny.cz&gt; wrote:

> On Thu, 27 Aug 2020 14:21:03 +0200
> Lukas Javorsky <ljavorsk(a)redhat.com&gt; wrote:
>
> > Hi folks,
> >
> > I've run into the compilation problem in the Galera package
> > This problem occurs only on f33 and higher tho.
> >
> > Here is build performed on Fedora 32:
> > https://koji.fedoraproject.org/koji/taskinfo?taskID=50232504
> >
> > And here is the same build, but on Fedora 33:
> > https://koji.fedoraproject.org/koji/taskinfo?taskID=50232498
> >
> > Does anyone know what could cause this?
> > It looks like something that changed in *cc1plus* or *scons *is causing
> > this, so if you had similar issue, please let me know.
>
>  one difference is that F-33 enabled LTO (new compiler flags added at
>  the distro level, [1], but as you are building with -Werror, then you
>  should review the code for real issues. 
>
>
>                 Dan
>
> [1] https://fedoraproject.org/wiki/LTOByDefault
> _______________________________________________
> devel mailing list -- devel(a)lists.fedoraproject.org
> To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]
>


-- 
S pozdravom/ Best regards

Lukas Javorsky

Intern, Core service - Databases

Red Hat <https://www.redhat.com>

Purkyňova 115 (TPB-C)

612 00 Brno - Královo Pole

ljavorsk(a)redhat.com
<https://www.redhat.com>

[Dan Horák]

On Fri, 28 Aug 2020 10:01:37 +0200
Lukas Javorsky <ljavorsk(a)redhat.com&gt; wrote:

>  > one difference is that F-33 enabled LTO (new compiler flags
> added at
>  > the distro level, [1], but as you are building with -Werror, then you
>  > should review the code for real issues. 
as others already mentioned - there is a problem in the project's source
code with the fail_*() functions leading to a compiler warning that's
turned into an error by -Werror.


		Dan
 
> What do you mean by real issues?
> 
> On Thu, Aug 27, 2020 at 2:38 PM Dan Horák <dan(a)danny.cz&gt; wrote:
> 
> > On Thu, 27 Aug 2020 14:21:03 +0200
> > Lukas Javorsky <ljavorsk(a)redhat.com&gt; wrote:
> >
> > > Hi folks,
> > >
> > > I've run into the compilation problem in the Galera package
> > > This problem occurs only on f33 and higher tho.
> > >
> > > Here is build performed on Fedora 32:
> > > https://koji.fedoraproject.org/koji/taskinfo?taskID=50232504
> > >
> > > And here is the same build, but on Fedora 33:
> > > https://koji.fedoraproject.org/koji/taskinfo?taskID=50232498
> > >
> > > Does anyone know what could cause this?
> > > It looks like something that changed in *cc1plus* or *scons *is causing
> > > this, so if you had similar issue, please let me know.
> >
>  > one difference is that F-33 enabled LTO (new compiler flags
> added at
>  > the distro level, [1], but as you are building with -Werror, then you
>  > should review the code for real issues. 
> >
> >
> >                 Dan
> >
> > [1] https://fedoraproject.org/wiki/LTOByDefault
> > _______________________________________________
> > devel mailing list -- devel(a)lists.fedoraproject.org
> > To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
> > Fedora Code of Conduct:
> > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives:
> > https://lists.fedoraproject.org/archives/list/[e-mail]
> >
> 
> 
> -- 
> S pozdravom/ Best regards
> 
> Lukas Javorsky
> 
> Intern, Core service - Databases
> 
> Red Hat <https://www.redhat.com>
> 
> Purkyňova 115 (TPB-C)
> 
> 612 00 Brno - Královo Pole
> 
> ljavorsk(a)redhat.com
> <https://www.redhat.com>

[Lukas Javorsky]

Yep, thanks for help

Lukas

On Fri, Aug 28, 2020 at 10:11 AM Dan Horák <dan(a)danny.cz&gt; wrote:

>  On Fri, 28 Aug 2020 10:01:37 +0200
>  Lukas Javorsky <ljavorsk(a)redhat.com&gt; wrote:
>
>  > > one difference is that F-33 enabled LTO (new compiler flags added at
>  > > the distro level, [1], but as you are building with -Werror, then you
>  > > should review the code for real issues.
>
>  as others already mentioned - there is a problem in the project's source
>  code with the fail_*() functions leading to a compiler warning that's
>  turned into an error by -Werror.
>
>
>                  Dan
>
>  > What do you mean by real issues?
>  >
>  > On Thu, Aug 27, 2020 at 2:38 PM Dan Horák <dan(a)danny.cz&gt; wrote:
>  >
>  > > On Thu, 27 Aug 2020 14:21:03 +0200
>  > > Lukas Javorsky <ljavorsk(a)redhat.com&gt; wrote:
>  > >
>  > > > Hi folks,
>  > > >
>  > > > I've run into the compilation problem in the Galera package
>  > > > This problem occurs only on f33 and higher tho.
>  > > >
>  > > > Here is build performed on Fedora 32:
>  > > > https://koji.fedoraproject.org/koji/taskinfo?taskID=50232504
>  > > >
>  > > > And here is the same build, but on Fedora 33:
>  > > > https://koji.fedoraproject.org/koji/taskinfo?taskID=50232498
>  > > >
>  > > > Does anyone know what could cause this?
>  > > > It looks like something that changed in *cc1plus* or *scons *is
>  causing
>  > > > this, so if you had similar issue, please let me know.
>  > >
>  > > one difference is that F-33 enabled LTO (new compiler flags added at
>  > > the distro level, [1], but as you are building with -Werror, then you
>  > > should review the code for real issues.
>  > >
>  > >
>  > >                 Dan
>  > >
>  > > [1] https://fedoraproject.org/wiki/LTOByDefault
>  > > _______________________________________________
>  > > devel mailing list -- devel(a)lists.fedoraproject.org
>  > > To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
>  > > Fedora Code of Conduct:
>  > > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  > > List Guidelines:
>  https://fedoraproject.org/wiki/Mailing_list_guidelines
>  > > List Archives:
>  > >
>  https://lists.fedoraproject.org/archives/list/[e-mail]
>  > >
>  >
>  >
>  > --
>  > S pozdravom/ Best regards
>  >
>  > Lukas Javorsky
>  >
>  > Intern, Core service - Databases
>  >
>  > Red Hat <https://www.redhat.com>
>  >
>  > Purkyňova 115 (TPB-C)
>  >
>  > 612 00 Brno - Královo Pole
>  >
>  > ljavorsk(a)redhat.com
>  > <https://www.redhat.com>
>  _______________________________________________
>  devel mailing list -- devel(a)lists.fedoraproject.org
>  To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct:
>  https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
>  https://lists.fedoraproject.org/archives/list/[e-mail]
>  

-- 
S pozdravom/ Best regards

Lukas Javorsky

Intern, Core service - Databases

Red Hat <https://www.redhat.com>

Purkyňova 115 (TPB-C)

612 00 Brno - Královo Pole

ljavorsk(a)redhat.com
<https://www.redhat.com>

[Petr Pisar]

On Thu, Aug 27, 2020 at 02:21:03PM +0200, Lukas Javorsky wrote:
>  I've run into the compilation problem in the Galera package
>  This problem occurs only on f33 and higher tho.
>  
>  Here is build performed on Fedora 32:
>  https://koji.fedoraproject.org/koji/taskinfo?taskID=50232504
>  
>  And here is the same build, but on Fedora 33:
>  https://koji.fedoraproject.org/koji/taskinfo?taskID=50232498
>  
>  Does anyone know what could cause this? 
On of these changed build-dependencies
<https://koschei.fedoraproject.org/build/8634598>;.

-- Petr

[Jeff Law]

On Thu, 2020-08-27 at 14:21 +0200, Lukas Javorsky wrote:
>  Hi folks,
>  
>  I've run into the compilation problem in the Galera package
>  This problem occurs only on f33 and higher tho.
>  
>  Here is build performed on Fedora 32: 
> https://koji.fedoraproject.org/koji/taskinfo?taskID=50232504
>  
>  And here is the same build, but on Fedora 33: 
> https://koji.fedoraproject.org/koji/taskinfo?taskID=50232498
>  
>  Does anyone know what could cause this?
>  It looks like something that changed in cc1plus or scons is causing this, so if you had
> similar issue, please let me know. 
I'm pretty confident this is a source level
issue, not a problem with gcc or
scons.

If you look at the cpp output you'll find something like this:

# 130 "galera/tests/defaults_check.cpp" 3 4
       (
# 130 "galera/tests/defaults_check.cpp"
       it == map.end()
# 130 "galera/tests/defaults_check.cpp" 3 4
       ) ? _ck_assert_failed("galera/tests/defaults_check.cpp", 130,
"Failure '"
# 130 "galera/tests/defaults_check.cpp"
       "it == map.end()"
# 130 "galera/tests/defaults_check.cpp" 3 4
       "' occurred" ,
# 130 "galera/tests/defaults_check.cpp"
       "Failed to insert KV pair: %s = %s", param.first.c_str(),
param.second.c_str()
# 130 "galera/tests/defaults_check.cpp" 3 4
       , __null) : _mark_point("galera/tests/defaults_check.cpp", 130)

# 131 "galera/tests/defaults_check.cpp"

Where ck_assert_failed is defined by /usr/include/check.h, which comes from
check-devel:
CK_DLL_EXP void CK_EXPORT _ck_assert_failed(const char *file, int line,
                                            const char *expr, const char *msg,
                                            ...) CK_ATTRIBUTE_NORETURN
CK_ATTRIBUTE_FORMAT(printf, 4, 5);


Which says argument 4 of the call to ck_assert_failed is a printf style argument.
 

THat argument is:

"Failed to insert KV pair: %s = %s", param.first.c_str()

Note two string format arguments (%s).  Yet there are 3 arguments
(param.first.c_str(), param.second.c_str(), __null

That's what the compiler is complaining about.  This all indicates either check.h
is broken or the sources using it are broken.  But it isn't a compiler or scons
issue.


jeff