GCC 4.3 problem building libeXosip2?

[Jeffrey Ollie]

I'm working on an update to libeXosip2, unfortunately I get some
errors while building on rawhide:

http://koji.fedoraproject.org/koji/getfile?taskID=395271&name=build.log

The problems occur both building locally on mock and when doing a
scratch build on koji.   Builds on F-7 and F-8 work fine so I'm fairly
confident that this is something related to GCC 4.3.  I'm working on
getting a rawhide system up and running to do some testing - in the
meantime is there anyone that can take a look and give me some
pointers?

Jeff

[Jason L Tibbitts III]

> >>>> "JO" == Jeffrey Ollie
> <jeff(a)ocjtech.us&gt; writes: 
JO> The problems occur both building locally on mock and when doing a
JO> scratch build on koji.  Builds on F-7 and F-8 work fine so I'm
JO> fairly confident that this is something related to GCC 4.3.

Well:

eXtl_udp.c:279: error: 'NI_MAXHOST' undeclared (first use in this function)
eXtl_udp.c:279: error: (Each undeclared identifier is reported only once
eXtl_udp.c:279: error: for each function it appears in.)

So did anything include netdb.h where this is defined?

 - J<

[Jeffrey Ollie]

On 04 Feb 2008 14:47:19 -0600, Jason L Tibbitts III <tibbs(a)math.uh.edu&gt; wrote:
>  >>>>> "JO" == Jeffrey Ollie
> <jeff(a)ocjtech.us&gt; writes:
>
>  JO> The problems occur both building locally on mock and when doing a
>  JO> scratch build on koji.  Builds on F-7 and F-8 work fine so I'm
>  JO> fairly confident that this is something related to GCC 4.3.
>
>  Well:
>
>  eXtl_udp.c:279: error: 'NI_MAXHOST' undeclared (first use in this function)
>  eXtl_udp.c:279: error: (Each undeclared identifier is reported only once
>  eXtl_udp.c:279: error: for each function it appears in.)
>
>  So did anything include netdb.h where this is defined? 
There's a header in the source itself (src/eXosip2.h) that defines
NI_MAXHOST itself.

Jeff

[Adam Tkac]

On Mon, Feb 04, 2008 at 02:36:50PM -0600, Jeffrey Ollie wrote:
>  I'm working on an update to libeXosip2, unfortunately I get some
>  errors while building on rawhide:
>  
>  http://koji.fedoraproject.org/koji/getfile?taskID=395271&name=build.log
>  
>  The problems occur both building locally on mock and when doing a
>  scratch build on koji.   Builds on F-7 and F-8 work fine so I'm fairly
>  confident that this is something related to GCC 4.3.  I'm working on
>  getting a rawhide system up and running to do some testing - in the
>  meantime is there anyone that can take a look and give me some
>  pointers?
>  
>  Jeff
>   
libeXosip2 is buggy. NI_MAXHOST is in #ifdef statement in header but
in code is used without #ifdef. Simple patch is attached

Adam

-- 
Adam Tkac, Red Hat, Inc.

[Jeffrey Ollie]

On 2/5/08, Adam Tkac <atkac(a)redhat.com&gt; wrote:
>  libeXosip2 is buggy. NI_MAXHOST is in #ifdef statement in header but
>  in code is used without #ifdef. Simple patch is attached 
Thanks for the patch - it got my package building.  However, I've been
digging deeper into the situation and found the following change was
made recently in F-9's glibc:

diff --git a/resolv/netdb.h b/resolv/netdb.h
index 7c5c9c9..5e007e2 100644
--- a/resolv/netdb.h
+++ b/resolv/netdb.h
@@ -607,8 +607,10 @@ struct gaicb
 #  define EAI_IDN_ENCODE  -105 /* IDN encoding failed.  */
 # endif

-# define NI_MAXHOST      1025
-# define NI_MAXSERV      32
+# ifdef __USE_GNU
+#  define NI_MAXHOST      1025
+#  define NI_MAXSERV      32
+# endif

 # define NI_NUMERICHOST        1       /* Don't try to look up hostname.  */
 # define NI_NUMERICSERV 2      /* Don't convert port number to name.  */

So that means that I'd have to define _GNU_SOURCE to use these macros.
 I had a similar issue when compiling the new linphone package in
rawhide.  I'm not sure which way is the "correct" way but something
that will certainly need to be kept in mind.

Jeff