Packaging wiki: shortcoming in Github Source0 (?)

[Germano Massullo]

I think I have found a shortcoming in
https://fedoraproject.org/wiki/Packaging:SourceURL#Commit_Revision
Github line, which is
Source0:
https://github.com/OWNER/%{name}/archive/%{commit}/%{name}-%{shortcommit}...
but I am not sure, so I have not made any edit to the wiki page.

In my case I am packaging bettercap-ng with the following attributes
commit eb1a53efa3171aefed0ec9766d8c5047bd0df289
shortcommit eb1a53e

rpmbuild parser will translate Source0 into
https://github.com/evilsocket/bettercap-ng/archive/eb1a53efa3171aefed0ec9...
but if you try inserting such URL in your browser, Github will return a
file named

bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289.tar.gz

instead of

bettercap-ng-eb1a53e.tar.gz

so if you run locally

$ rpmbuild -bs rpmbuild/SPECS/bettercap.spec

you will obviously get

error: File /home/user/rpmbuild/SOURCES/bettercap-ng-eb1a53e.tar.gz: No
such file or directory.

Therefore I think wiki line

Source0:
https://github.com/OWNER/%{name}/archive/%{commit}/%{name}-%{shortcommit}...

should be changed into

Source0:
https://github.com/OWNER/%{name}/archive/%{commit}/%{name}-%{commit}.tar.gz

Am I right?

Best regards