Overriding default %cmake CXXFLAGS

[Julian Sikorski]

Hi,

mame needs to have the symbols level reduced to -g1 or the compilation 
will fail due to relocation overflows and generally excessive memory and 
disk space usage. Right now this is taken care of by editing $RPM_OPT_FLAGS:
https://src.fedoraproject.org/rpms/mame/blob/30873dfe8d2ab851bb018b7a1049...
Upstream are considering switching to cmake, which is going to render 
this approach inoperable. Is there a preferred way of editing the flags 
used by %cmake macro? Thanks!

Best regards,
Julian

[Neal Gompa]

On Mon, Aug 16, 2021 at 3:14 PM Julian Sikorski <belegdol(a)gmail.com&gt; wrote:
>  Hi,
>
>  mame needs to have the symbols level reduced to -g1 or the compilation
>  will fail due to relocation overflows and generally excessive memory and
>  disk space usage. Right now this is taken care of by editing $RPM_OPT_FLAGS:
>
> https://src.fedoraproject.org/rpms/mame/blob/30873dfe8d2ab851bb018b7a1049...
>  Upstream are considering switching to cmake, which is going to render
>  this approach inoperable. Is there a preferred way of editing the flags
>  used by %cmake macro? Thanks!
>  
Overriding the %build_cflags and %build_cxxflags macros is sufficient here.



-- 
真実はいつも一つ！/ Always, there's only one truth!

[Julian Sikorski]

W dniu 16.08.2021 o 21:24, Neal Gompa pisze:
>  On Mon, Aug 16, 2021 at 3:14 PM Julian Sikorski
> <belegdol(a)gmail.com&gt; wrote:
> >
> > Hi,
> >
> > mame needs to have the symbols level reduced to -g1 or the compilation
> > will fail due to relocation overflows and generally excessive memory and
> > disk space usage. Right now this is taken care of by editing $RPM_OPT_FLAGS:
> >
> https://src.fedoraproject.org/rpms/mame/blob/30873dfe8d2ab851bb018b7a1049...
> > Upstream are considering switching to cmake, which is going to render
> > this approach inoperable. Is there a preferred way of editing the flags
> > used by %cmake macro? Thanks!
> >
>  
>  Overriding the %build_cflags and %build_cxxflags macros is sufficient here.
>  
>  
>   
Thanks! And what is the recommended way of doing this? Just defining it 
in the spec?
The advantage of the approach used until now is that it only drops -g(2) 
to -g1, leaving other flags intact.

Best regards,
Julian

[Neal Gompa]

On Mon, Aug 16, 2021 at 3:32 PM Julian Sikorski <belegdol(a)gmail.com&gt; wrote:
>  W dniu 16.08.2021 o 21:24, Neal Gompa pisze:
>  > On Mon, Aug 16, 2021 at 3:14 PM Julian Sikorski <belegdol(a)gmail.com&gt; wrote:
>  >>
>  >> Hi,
>  >>
>  >> mame needs to have the symbols level reduced to -g1 or the compilation
>  >> will fail due to relocation overflows and generally excessive memory and
>  >> disk space usage. Right now this is taken care of by editing $RPM_OPT_FLAGS:
>  >>
> https://src.fedoraproject.org/rpms/mame/blob/30873dfe8d2ab851bb018b7a1049...
>  >> Upstream are considering switching to cmake, which is going to render
>  >> this approach inoperable. Is there a preferred way of editing the flags
>  >> used by %cmake macro? Thanks!
>  >>
>  >
>  > Overriding the %build_cflags and %build_cxxflags macros is sufficient here.
>  >
>  >
>  >
>  Thanks! And what is the recommended way of doing this? Just defining it
>  in the spec?
>  The advantage of the approach used until now is that it only drops -g(2)
>  to -g1, leaving other flags intact.
>  
Do it the same way you're doing it now, just change $() for %().


-- 
真実はいつも一つ！/ Always, there's only one truth!

[Julian Sikorski]

W dniu 16.08.2021 o 21:33, Neal Gompa pisze:
>  On Mon, Aug 16, 2021 at 3:32 PM Julian Sikorski
> <belegdol(a)gmail.com&gt; wrote:
> >
> > W dniu 16.08.2021 o 21:24, Neal Gompa pisze:
> >> On Mon, Aug 16, 2021 at 3:14 PM Julian Sikorski <belegdol(a)gmail.com&gt;
> wrote:
> >>>
> >>> Hi,
> >>>
> >>> mame needs to have the symbols level reduced to -g1 or the compilation
> >>> will fail due to relocation overflows and generally excessive memory and
> >>> disk space usage. Right now this is taken care of by editing $RPM_OPT_FLAGS:
> >>>
> https://src.fedoraproject.org/rpms/mame/blob/30873dfe8d2ab851bb018b7a1049...
> >>> Upstream are considering switching to cmake, which is going to render
> >>> this approach inoperable. Is there a preferred way of editing the flags
> >>> used by %cmake macro? Thanks!
> >>>
> >>
> >> Overriding the %build_cflags and %build_cxxflags macros is sufficient here.
> >>
> >>
> >>
> > Thanks! And what is the recommended way of doing this? Just defining it
> > in the spec?
> > The advantage of the approach used until now is that it only drops -g(2)
> > to -g1, leaving other flags intact.
> >
>  
>  Do it the same way you're doing it now, just change $() for %().
>  
>   
I must be having a short between the headphones:

%global build_cflags %(echo $RPM_OPT_FLAGS | sed "s@-g@-g1@")
%global build_cxxflags %(echo $RPM_OPT_FLAGS | sed "s@-g@-g1@")

this results in no flags being passed to cmake whatsoever.

[Vitaly Zaitsev]

On 16/08/2021 22:03, Julian Sikorski wrote:
>  %global build_cflags %(echo $RPM_OPT_FLAGS | sed
> "s@-g@-g1@")
>  %global build_cxxflags %(echo $RPM_OPT_FLAGS | sed "s@-g@-g1@") 
Changing optflags is better, because it will affect all build flags at 
once: C, C++, Fortran, etc.

-- 
Sincerely,
   Vitaly Zaitsev (vitaly(a)easycoding.org)

[Vitaly Zaitsev]

On 16/08/2021 21:14, Julian Sikorski wrote:
>  mame needs to have the symbols level reduced to -g1 or the
> compilation 
>  will fail due to relocation overflows and generally excessive memory and 
>  disk space usage. 
%global optflags %(echo %{optflags} | sed 's/-g /-g1 /')

-- 
Sincerely,
   Vitaly Zaitsev (vitaly(a)easycoding.org)

[Julian Sikorski]

W dniu 16.08.2021 o 22:22, Vitaly Zaitsev via devel pisze:
>  On 16/08/2021 21:14, Julian Sikorski wrote:
> > mame needs to have the symbols level reduced to -g1 or the compilation 
> > will fail due to relocation overflows and generally excessive memory 
> > and disk space usage.
>  
>  %global optflags %(echo %{optflags} | sed 's/-g /-g1 /')
>   
Thanks, this worked!