Re: rpms/kdepim/devel kdepim.spec,1.211,1.212

[Mamoru Tasaka]

Rex Dieter wrote, at 04/02/2009 03:55 AM +9:00:
>  Author: rdieter
>  
>  Update of /cvs/pkgs/rpms/kdepim/devel
>  In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv11129
>  
>  Modified Files:
>  	kdepim.spec 
>  Log Message:
>  * Wed Apr 01 2009 Rex Dieter <rdieter(a)fedoraproject.org&gt; - 4.2.2-2
>  - optimize scriptlets
>  
>  
>  
>  Index: kdepim.spec
>  ===================================================================
>  RCS file: /cvs/pkgs/rpms/kdepim/devel/kdepim.spec,v
>  retrieving revision 1.211
>  retrieving revision 1.212
>  diff -u -r1.211 -r1.212
>  --- kdepim.spec	31 Mar 2009 15:03:24 -0000	1.211
>  +++ kdepim.spec	1 Apr 2009 18:54:54 -0000	1.212
>  -%postun
>  -xdg-icon-resource forceupdate --theme hicolor 2> /dev/null || :
>  -xdg-icon-resource forceupdate --theme oxygen 2> /dev/null || :
>  -xdg-desktop-menu forceupdate 2> /dev/null || :
>  +%posttrans
>  +gtk-update-icon-cache %{_kde4_iconsdir}/hicolor &> /dev/null ||:
>  +gtk-update-icon-cache %{_kde4_iconsdir}/oxygen &> /dev/null ||:
>  +update-desktop-database -q &> /dev/null ||:
>   
>  +%postun
>  +if [ $1 -eq 0 ] ; then
>  +  touch --no-create %{_kde4_iconsdir}/hicolor &> /dev/null ||:
>  +  touch --no-create %{_kde4_iconsdir}/oxygen &> /dev/null ||:
>  +  gtk-update-icon-cache %{_kde4_iconsdir}/hicolor &> /dev/null ||:
>  +  gtk-update-icon-cache %{_kde4_iconsdir}/oxygen &> /dev/null ||:
>  +  update-desktop-database -q &> /dev/null ||:
>  +fi
>   
>   %post libs -p /sbin/ldconfig 
Can "update-desktop-database" be moved to %posttrans and
(%postun : if [ $1 -eq 0 ] ; then) ? 
Current packaging guidelines don't suggest it so I am just asking
(I have moved "gtk-update-icon-cache" to %posttrans and so on
 in my packages)

Regards,
Mamoru

rpms/kdepim/devel kdepim.spec,1.211,1.212

[Rex Dieter]

Mamoru Tasaka wrote:

>  Can "update-desktop-database" be moved to %posttrans and
>  (%postun : if [ $1 -eq 0 ] ; then) ?
>  Current packaging guidelines don't suggest it so I am just asking
>  (I have moved "gtk-update-icon-cache" to %posttrans and so on
>   in my packages) 
shrug, I see no reason why not... but it turns out in my quick testing that
scriptlet processing speed doesn't benefit from this much, if at all.

-- Rex