Koschei builds fail with "error: %patchN is obsolete", but no %patchN in the spec file

[Alexander Ploumistos]

Hello,

I found a moment to catch up on my package maintainer tasks and I
noticed that for the past 15 days fityk's rawhide builds started by
Koschei have been failing[1]. There are no build logs and the only
error I can spot in the root.log is this:

DEBUG util.py:461:  error: %patchN is obsolete, use %patch N (or
%patch -P N): %patch0 -p0

The odd thing here is that the spec file has

%patch -P0 -p0

I also did a scratch build[2] and it completed without any errors. Is
there something I need to do?

Best regards,
A.

1. https://koschei.fedoraproject.org/package/fityk?collection=f41
2. https://koji.fedoraproject.org/koji/taskinfo?taskID=119026186

[Dominik 'Rathann' Mierzejewski]

On Saturday, 15 June 2024 at 00:07, Alexander Ploumistos wrote:
> Hello,
>
> I found a moment to catch up on my package maintainer tasks and I
> noticed that for the past 15 days fityk's rawhide builds started by
> Koschei have been failing[1]. There are no build logs and the only
> error I can spot in the root.log is this:
>
> DEBUG util.py:461:  error: %patchN is obsolete, use %patch N (or
> %patch -P N): %patch0 -p0
>
> The odd thing here is that the spec file has
>
> %patch -P0 -p0
>
> I also did a scratch build[2] and it completed without any errors. Is
> there something I need to do?

Do a new build of the package if you want koschei to be clean.
The %patchN fixes were committed and pushed without bumping the release,
so koschei is not aware of them (it's using the latest src.rpm, not git
HEAD).

Regards,
Dominik

[Alexander Ploumistos]

Thank you Dominik, I hadn't noticed the commit message, I was looking
at everything else.

[Otto Liljalaakso]

It looks like builds were not started after %patch changes. Which is probably otherwise fine, but yes Koschei attempts to rebuild latest Koji build, not dist-git tip. Just do 'fedpkg build' to align Koji and dist-git and Koschei should get into sync.

It would be great if Koschei somehow took this situation into account. On Rawhide it is not so bad, because I can just issue a build to recover. But currently, I  also have similar situation for Tilix in Fedora 40 (due to different root cause) and I don't think it is appropriate to build&update just because of packaging changes. I would say it is not an error state I'd latest Koji build cannot be rebuilt, if dist-git tip builds.

15. kesäkuuta 2024 1.07.27 GMT+03:00 Alexander Ploumistos  kirjoitti:
> Hello,
>
> I found a moment to catch up on my package maintainer tasks and I
> noticed that for the past 15 days fityk's rawhide builds started by
> Koschei have been failing[1]. There are no build logs and the only
> error I can spot in the root.log is this:
>
> DEBUG util.py:461:  error: %patchN is obsolete, use %patch N (or
> %patch -P N): %patch0 -p0
>
> The odd thing here is that the spec file has
>
> %patch -P0 -p0
>
> I also did a scratch build[2] and it completed without any errors. Is
> there something I need to do?
>
> Best regards,
> A.
> https://koschei.fedoraproject.org/package/fityk?collection=f41
> https://koji.fedoraproject.org/koji/taskinfo?taskID=119026186
>
> --
> _______________________________________________
> devel mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/[e-mail]
> Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue