On Wed, Jan 25, 2023 at 03:45:35PM +0100, Jaroslav Skarvada wrote:
On Wed, Jan 25, 2023 at 12:13 PM Miro Hrončok
> On 25. 01. 23 11:50, Vít Ondruch wrote:
> > Reading the thread, I was afraid this will be the end result. Nevertheless,
> > given this would be used just for side-tags, is there a chance to exclude side
> > tags from the policy? Who would handle such request?
I thought we had already done this, but it seems not.
I am not 100% koji has the needed policy for this, so I'd say file the
issue first as a koji issue and once we can allow/disallow this via
policy we can allow it for sidetags... but see below.
> > Although being able to modify one macro means also
possibility to edit all
> > macros. Not sure this is desired. However one can achieve almost everything by
> > changing .spec file, so that should not be blocker IMHO.
Or add an option that will mark/unmark the sidetag for bootstrapping,
i.e. option that will add only this specific bootstrap macro to the
sidetag and nothing more.
Yeah, that would be better than allowing all tag options to be set.
> I think the "commit the bootstrap conditional directly to
> approach is much more transparent than "fiddling with macros in Koji to save
> myself one tiny commit" anyway.
It's one commit per package. If you rebuild more packages there may be
more things that need bootstrapping.
Also: commits to reverse the horrible with/without syntax are error
prone. If we can avoid doing them, we can probibly avoid some mistakes.
> To answer the original question, it can be done like this:
> 1. commit all commits and push them all
> 2. fedpkg request-side-tag
> 3. koji chain-build --nowait f38-build-side-66666
> : ..instert mid deps here... :
If there already are the boostrap conditionals in the specs the logic
progress is to have some support in the infra. Just manually reverting
the condition in the spec is, let's say not the optimal solution. Just
my two cents.
I personally agree.
I think ideally koji would allow us to allow/deny changing taginfo to
side tags, and even better allow/deny changing just bootstrap=1.