eit.c:394:13: error: 'stime' was not declared in this scope; did you mean 'ctime'?

[Martin Gansser]

Hi,

i'am trying to compile vdr-2.4.1 for Fedora32, but this fails with the following error
message:

g++ -O3 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
-Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic
-fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fPIC
-Werror=overloaded-virtual -Wno-parentheses -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fPIC -c -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DREMOTE_KBD -DVDR_USER=\"vdr\"
-DSDNOTIFY -DLIRC_DEVICE=\"/var/run/lirc/lircd\"
-DVIDEODIR=\"/var/lib/vdr/video\" -DCONFDIR=\"/etc/vdr\"
-DARGSDIR=\"/etc/vdr/conf.d\" -DCACHEDIR=\"/var/cache/vdr\"
-DRESDIR=\"/usr/share/vdr\" -DPLUGINDIR=\"/usr/lib64/vdr\"
-DLOCDIR=\"/usr/share/locale\" -I/usr/include/freetype2 -I/usr/include/libpng16 
  -o eit.o eit.c^M
eit.c: In constructor 'cTDT::cTDT(const u_char*)':^M
eit.c:394:13: error: 'stime' was not declared in this scope; did you mean
'ctime'?^M
394 |         if (stime(&dvbtim) == 0)^M
|             ^~~~~^M
|             ctime^M

I tried the following patch already, but this doesn't work.

--- a/eit.c.orig        2019-12-12 16:23:42.231599228 +0100
+++ b/eit.c     2019-12-12 16:24:09.093601411 +0100
@@ -13,6 +13,7 @@
#include "eit.h"
#include <sys/time.h>
+#include <time.h>
#include "epg.h"
#include "i18n.h"
#include "libsi/section.h"

Any help appreciated

Martin

[Florian Weimer]

* Martin Gansser:

>  Hi,
>
>  i'am trying to compile vdr-2.4.1 for Fedora32, but this fails with the following
> error message:
>
>  g++ -O3 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
> -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches
> -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic
> -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fPIC
> -Werror=overloaded-virtual -Wno-parentheses -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
> -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fPIC -c -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
> -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DREMOTE_KBD -DVDR_USER=\"vdr\"
> -DSDNOTIFY -DLIRC_DEVICE=\"/var/run/lirc/lircd\"
> -DVIDEODIR=\"/var/lib/vdr/video\" -DCONFDIR=\"/etc/vdr\"
> -DARGSDIR=\"/etc/vdr/conf.d\" -DCACHEDIR=\"/var/cache/vdr\"
> -DRESDIR=\"/usr/share/vdr\" -DPLUGINDIR=\"/usr/lib64/vdr\"
> -DLOCDIR=\"/usr/share/locale\" -I/usr/include/freetype2 -I/usr/include/libpng16 
>   -o eit.o eit.c^M
>  eit.c: In constructor 'cTDT::cTDT(const u_char*)':^M
>  eit.c:394:13: error: 'stime' was not declared in this scope; did you mean
> 'ctime'?^M
>  394 |         if (stime(&dvbtim) == 0)^M
>  |             ^~~~~^M
>  |             ctime^M
>
>  I tried the following patch already, but this doesn't work. 
You need to port this code to clock_settime.

(I'm not really sure why vdr would want to set the system time, though.)

Thanks,
Florian

[Martin Gansser]

I tried to compile the vdr with the following patch, unfortunately it fails with the
following error message.

eit.c:25:18: error: missing binary operator before token "("
25 | #if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_31)
| ^
make: *** Deleting file '.dependencies'


--- a/eit.c.orig        2019-12-13 12:45:00.202346585 +0100
+++ b/eit.c     2019-12-13 12:46:20.027353073 +0100
@@ -18,6 +18,32 @@
 #include "libsi/section.h"
 #include "libsi/descriptor.h"

+
+
+#include <shlib-compat.h>
+
+#if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_31)
+
+#include <time.h>
+ 
+/* Set the system clock to *WHEN.  */
+ 
+int
+attribute_compat_text_section
+__stime (const time_t *when)
+  {
+  struct timespec ts;
+  ts.tv_sec = *when;
+  ts.tv_nsec = 0;
+
+  return __clock_settime (CLOCK_REALTIME, &ts);
+  }
+ 
+compat_symbol (libc, __stime, stime, GLIBC_2_0);
+#endif
+
+
+
 #define VALID_TIME (31536000 * 2) // two years

 #define DBGEIT 0

Regards
Martin

[Martin Gansser]

solved now with this patch:

diff --git a/eit.c b/eit.c
index 50d8229..82294dc 100644
--- a/eit.c
+++ b/eit.c
@@ -391,7 +391,9 @@ cTDT::cTDT(const u_char *Data)
   if (abs(diff) > MAX_TIME_DIFF) {
      mutex.Lock();
      if (abs(diff) > MAX_ADJ_DIFF) {
-        if (stime(&dvbtim) == 0)
+        timespec ts = {0};
+        ts.tv_sec = dvbtim;
+        if (clock_settime(CLOCK_REALTIME, &ts) == 0)
            isyslog("system time changed from %s (%ld) to %s (%ld)",
*TimeToString(loctim), loctim, *TimeToString(dvbtim), dvbtim);
         else
            esyslog("ERROR while setting system time: %m");

[Kevin Kofler]

Martin Gansser wrote:
>  +        timespec ts = {0}; 
The compiler will warn about the missing initializers with this idiom. 
(struct timespec has more than one member.) Write this instead:
timespec ts = {};
(If you omit the initializer list within the braces entirely, as I have done 
above, GCC will know that you want to initialize the struct to all zeros and 
not complain about the missing zeros. Just make sure you keep the = {} part, 
otherwise the struct will not be initialized at all.)

        Kevin Kofler

[Martin Gansser]

ok, i will change it and inform the developer of vdr.
Many Thanks
Martin

[Dan Čermák]

Hi,

"Martin Gansser" <martin.gansser(a)gmail.com&gt; writes:

>  Hi,
>
>  i'am trying to compile vdr-2.4.1 for Fedora32, but this fails with the following
> error message:
>
>  g++ -O3 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
> -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches
> -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic
> -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fPIC
> -Werror=overloaded-virtual -Wno-parentheses -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
> -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fPIC -c -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
> -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DREMOTE_KBD -DVDR_USER=\"vdr\"
> -DSDNOTIFY -DLIRC_DEVICE=\"/var/run/lirc/lircd\"
> -DVIDEODIR=\"/var/lib/vdr/video\" -DCONFDIR=\"/etc/vdr\"
> -DARGSDIR=\"/etc/vdr/conf.d\" -DCACHEDIR=\"/var/cache/vdr\"
> -DRESDIR=\"/usr/share/vdr\" -DPLUGINDIR=\"/usr/lib64/vdr\"
> -DLOCDIR=\"/usr/share/locale\" -I/usr/include/freetype2 -I/usr/include/libpng16 
>   -o eit.o eit.c^M
>  eit.c: In constructor 'cTDT::cTDT(const u_char*)':^M
>  eit.c:394:13: error: 'stime' was not declared in this scope; did you mean
> 'ctime'?^M
>  394 |         if (stime(&dvbtim) == 0)^M
>  |             ^~~~~^M
>  |             ctime^M
>
>  I tried the following patch already, but this doesn't work. 
You need to `#define _DEFAULT_SOURCE` (since glibc 2.19) or `#define
_SVID_SOURCE` (for glibc <= 2.19) before including time.h (and before
any headers that could include time.h themselves).

>  --- a/eit.c.orig        2019-12-12 16:23:42.231599228 +0100
>  +++ b/eit.c     2019-12-12 16:24:09.093601411 +0100
>  @@ -13,6 +13,7 @@
>  #include "eit.h"
>  #include <sys/time.h>
>  +#include <time.h>
>  #include "epg.h"
>  #include "i18n.h"
>  #include "libsi/section.h"
>
>  Any help appreciated
>
>  Martin

[Martin Gansser]

Thanks for your help, but i will contact the developer.

Regards
Martin