hamcrest update to 2.2 in Fedora rawhide

[Mikolaj Izdebski]

Hello,

Next week I'm going to update package hamcrest in Fedora rawhide from
version 1.3 to version 2.2.

The proposed update contains an API change that can affect packages
depending on hamcrest.  You may need to rebuild your packages to keep
working with updated hamcrest.

The update has already been checked into dist-git and a Koji build has
already been done, but Bodhi update has not been submitted yet.  Bodhi
update is expected after a week, to comply with Updates Policy that
mandates a notification one week in advance before submitting an API
changing update.

  Current NVR in rawhide: hamcrest-1.3-31.fc34
  Updated NVR: hamcrest-2.2-3.fc35
  Build link: https://koji.fedoraproject.org/koji/buildinfo?buildID=1748364

Packages depending on hamcrest that are possibly affected by this update:
 * eclipse, maintained by lef jerboaa dbhole rgrunber jjohnstn
akurtakov ebaron oliver mbooth arobinso
 * freemarker, maintained by filiperosset
 * hamcrest, maintained by akurtakov mizdebsk jerboaa
 * hdf, maintained by sagitter orion
 * hdf5, maintained by deji sagitter orion ignatenkobrain
 * icedtea-web, maintained by jvanek dbhole omajid
 * jmock, maintained by orphan
 * openas2, maintained by sdgathman
 * py4j, maintained by raphgro

--
Mikolaj Izdebski

[Fabio Valentini]

On Fri, May 21, 2021 at 1:10 AM Mikolaj Izdebski <mizdebsk(a)redhat.com&gt; wrote:
>  Hello,
>
>  Next week I'm going to update package hamcrest in Fedora rawhide from
>  version 1.3 to version 2.2.
>
>  The proposed update contains an API change that can affect packages
>  depending on hamcrest.  You may need to rebuild your packages to keep
>  working with updated hamcrest.
>
>  The update has already been checked into dist-git and a Koji build has
>  already been done, but Bodhi update has not been submitted yet.  Bodhi
>  update is expected after a week, to comply with Updates Policy that
>  mandates a notification one week in advance before submitting an API
>  changing update.
>
>    Current NVR in rawhide: hamcrest-1.3-31.fc34
>    Updated NVR: hamcrest-2.2-3.fc35
>    Build link: https://koji.fedoraproject.org/koji/buildinfo?buildID=1748364 
Note that hamcrest versions 2.x have already been available for over a year:
https://src.fedoraproject.org/rpms/hamcrest2

We packaged them separately because, IIRC, maven artifact coordinates
and java package import paths are completely separate between version
1.x and 2.x so packages can't just be updated, but actually need to be
ported to the new 2.x APIs.

Fabio

[Mikolaj Izdebski]

On Fri, May 21, 2021 at 1:55 AM Fabio Valentini <decathorpe(a)gmail.com&gt; wrote:
>  On Fri, May 21, 2021 at 1:10 AM Mikolaj Izdebski <mizdebsk(a)redhat.com&gt; wrote:
>  >
>  > Hello,
>  >
>  > Next week I'm going to update package hamcrest in Fedora rawhide from
>  > version 1.3 to version 2.2.
>  >
>  > The proposed update contains an API change that can affect packages
>  > depending on hamcrest.  You may need to rebuild your packages to keep
>  > working with updated hamcrest.
>  >
>  > The update has already been checked into dist-git and a Koji build has
>  > already been done, but Bodhi update has not been submitted yet.  Bodhi
>  > update is expected after a week, to comply with Updates Policy that
>  > mandates a notification one week in advance before submitting an API
>  > changing update.
>  >
>  >   Current NVR in rawhide: hamcrest-1.3-31.fc34
>  >   Updated NVR: hamcrest-2.2-3.fc35
>  >   Build link: https://koji.fedoraproject.org/koji/buildinfo?buildID=1748364
>
>  Note that hamcrest versions 2.x have already been available for over a year:
>  https://src.fedoraproject.org/rpms/hamcrest2 
hamcrest2 package is orphaned and it will be retired soon, unless
someone adopts it. As maintainer of hamcrest I would like to keep it
at the latest upstream version. Older versions can of course be
packaged as compat packages with version suffix in the name, if anyone
wishes to maintain them.

>  We packaged them separately because, IIRC, maven artifact
> coordinates
>  and java package import paths are completely separate between version
>  1.x and 2.x so packages can't just be updated, but actually need to be
>  ported to the new 2.x APIs. 
That is the API break I was speaking of. Hence I gave maintainers of
dependent packages a week to respond and prepare their packages to
work with updated hamcrest, by porting to hamcrest 2.2 or by packaging
version 1.x as hamcrest1 compat package and switching packages to use
it instead of hamcrest.

--
Mikolaj Izdebski

>  Fabio
>  _______________________________________________
>  devel mailing list -- devel(a)lists.fedoraproject.org
>  To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]
>  Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure

[Fabio Valentini]

On Mon, May 24, 2021 at 4:02 PM Mikolaj Izdebski <mizdebsk(a)redhat.com&gt; wrote:
>  On Fri, May 21, 2021 at 1:55 AM Fabio Valentini <decathorpe(a)gmail.com&gt; wrote:
>  >
>  > On Fri, May 21, 2021 at 1:10 AM Mikolaj Izdebski <mizdebsk(a)redhat.com&gt; wrote:
>  > >
>  > > Hello,
>  > >
>  > > Next week I'm going to update package hamcrest in Fedora rawhide from
>  > > version 1.3 to version 2.2.
>  > >
>  > > The proposed update contains an API change that can affect packages
>  > > depending on hamcrest.  You may need to rebuild your packages to keep
>  > > working with updated hamcrest.
>  > >
>  > > The update has already been checked into dist-git and a Koji build has
>  > > already been done, but Bodhi update has not been submitted yet.  Bodhi
>  > > update is expected after a week, to comply with Updates Policy that
>  > > mandates a notification one week in advance before submitting an API
>  > > changing update.
>  > >
>  > >   Current NVR in rawhide: hamcrest-1.3-31.fc34
>  > >   Updated NVR: hamcrest-2.2-3.fc35
>  > >   Build link: https://koji.fedoraproject.org/koji/buildinfo?buildID=1748364
>  >
>  > Note that hamcrest versions 2.x have already been available for over a year:
>  > https://src.fedoraproject.org/rpms/hamcrest2
>
>  hamcrest2 package is orphaned and it will be retired soon, unless
>  someone adopts it. As maintainer of hamcrest I would like to keep it
>  at the latest upstream version. Older versions can of course be
>  packaged as compat packages with version suffix in the name, if anyone
>  wishes to maintain them.
>
>  > We packaged them separately because, IIRC, maven artifact coordinates
>  > and java package import paths are completely separate between version
>  > 1.x and 2.x so packages can't just be updated, but actually need to be
>  > ported to the new 2.x APIs.
>
>  That is the API break I was speaking of. Hence I gave maintainers of
>  dependent packages a week to respond and prepare their packages to
>  work with updated hamcrest, by porting to hamcrest 2.2 or by packaging
>  version 1.x as hamcrest1 compat package and switching packages to use
>  it instead of hamcrest. 
So you're going to knowingly break other people's packages, with only
one week's notice, for no good reason (since both versions of hamcrest
were already available in parallel for over a year)? Do you think that
is acceptable?

Fabio

[Miro Hrončok]

On 17. 05. 21 21:57, Mikolaj Izdebski wrote:
>  Hello,
>  
>  Next week I'm going to update package hamcrest in Fedora rawhide from
>  version 1.3 to version 2.2.
>  
>  The proposed update contains an API change that can affect packages
>  depending on hamcrest.  You may need to rebuild your packages to keep
>  working with updated hamcrest.
>  
>  The update has already been checked into dist-git and a Koji build has
>  already been done, but Bodhi update has not been submitted yet.  Bodhi
>  update is expected after a week, to comply with Updates Policy that
>  mandates a notification one week in advance before submitting an API
>  changing update.
>  
>     Current NVR in rawhide: hamcrest-1.3-31.fc34
>     Updated NVR: hamcrest-2.2-3.fc35
>     Build link: https://koji.fedoraproject.org/koji/buildinfo?buildID=1748364
>  
>  Packages depending on hamcrest that are possibly affected by this update:
>    * eclipse, maintained by lef jerboaa dbhole rgrunber jjohnstn
>  akurtakov ebaron oliver mbooth arobinso
>    * freemarker, maintained by filiperosset
>    * hamcrest, maintained by akurtakov mizdebsk jerboaa
>    * hdf, maintained by sagitter orion
>    * hdf5, maintained by deji sagitter orion ignatenkobrain
>    * icedtea-web, maintained by jvanek dbhole omajid
>    * jmock, maintained by orphan
>    * openas2, maintained by sdgathman
>    * py4j, maintained by raphgro 
Hey Mikolaj,

libreoffice now fails to build because of this change and without building 
libreoffice, we might need to postpone the Python 3.10 rebuild. I'd rather 
avoid doing that. Would you please be able to help?


The error is:

checking for included Hamcrest... Not included
checking for standalone hamcrest jar.... configure: error: junit does not 
contain hamcrest; please use a junit jar that includes hamcrest, install a 
hamcrest jar in the default location (/usr/share/java),
                           specify its path with --with-hamcrest=..., or 
disable junit with --without-junit


Seems like the configure script (or whatever that is) fails to find hamcrest.

The bugzilla is https://bugzilla.redhat.com/show_bug.cgi?id=1965975

Thanks,
-- 
Miro Hrončok
-- 
Phone: [phone]
IRC: mhroncok

[Mikolaj Izdebski]

On Mon, May 31, 2021 at 1:12 PM Miro Hrončok <mhroncok(a)redhat.com&gt; wrote:
>  On 17. 05. 21 21:57, Mikolaj Izdebski wrote:
>  > Hello,
>  >
>  > Next week I'm going to update package hamcrest in Fedora rawhide from
>  > version 1.3 to version 2.2.
>  >
>  > The proposed update contains an API change that can affect packages
>  > depending on hamcrest.  You may need to rebuild your packages to keep
>  > working with updated hamcrest.
>  >
>  > The update has already been checked into dist-git and a Koji build has
>  > already been done, but Bodhi update has not been submitted yet.  Bodhi
>  > update is expected after a week, to comply with Updates Policy that
>  > mandates a notification one week in advance before submitting an API
>  > changing update.
>  >
>  >    Current NVR in rawhide: hamcrest-1.3-31.fc34
>  >    Updated NVR: hamcrest-2.2-3.fc35
>  >    Build link: https://koji.fedoraproject.org/koji/buildinfo?buildID=1748364
>  >
>  > Packages depending on hamcrest that are possibly affected by this update:
>  >   * eclipse, maintained by lef jerboaa dbhole rgrunber jjohnstn
>  > akurtakov ebaron oliver mbooth arobinso
>  >   * freemarker, maintained by filiperosset
>  >   * hamcrest, maintained by akurtakov mizdebsk jerboaa
>  >   * hdf, maintained by sagitter orion
>  >   * hdf5, maintained by deji sagitter orion ignatenkobrain
>  >   * icedtea-web, maintained by jvanek dbhole omajid
>  >   * jmock, maintained by orphan
>  >   * openas2, maintained by sdgathman
>  >   * py4j, maintained by raphgro
>
>  Hey Mikolaj,
>
>  libreoffice now fails to build because of this change and without building
>  libreoffice, we might need to postpone the Python 3.10 rebuild. I'd rather
>  avoid doing that. Would you please be able to help? 
>  The error is:
>
>  checking for included Hamcrest... Not included
>  checking for standalone hamcrest jar.... configure: error: junit does not
>  contain hamcrest; please use a junit jar that includes hamcrest, install a
>  hamcrest jar in the default location (/usr/share/java),
>                             specify its path with --with-hamcrest=..., or
>  disable junit with --without-junit
>
>
>  Seems like the configure script (or whatever that is) fails to find hamcrest. 
That's because libreoffice hardcodes path to hamcrest JAR in the
configure script, instead of using one of the tools designed to locate
JAR files in the system. That is covered in Java Packaging Guidelines
[1].

>  The bugzilla is https://bugzilla.redhat.com/show_bug.cgi?id=1965975
I could add a compat symlink to the hamcrest package, but it seems
that the issue was fixed on the libreoffice side.

--
Mikolaj Izdebski

[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#_hardcode...


>  Thanks,
>  --
>  Miro Hrončok
>  --
>  Phone: [phone]
>  IRC: mhroncok
>

[Stephan Bergmann]

On 01/06/2021 05:42, Mikolaj Izdebski wrote:
>  On Mon, May 31, 2021 at 1:12 PM Miro Hrončok
> <mhroncok(a)redhat.com&gt; wrote: 
[...]
> > Seems like the configure script (or whatever that is) fails to
> find hamcrest.
>  
>  That's because libreoffice hardcodes path to hamcrest JAR in the
>  configure script, instead of using one of the tools designed to locate
>  JAR files in the system. That is covered in Java Packaging Guidelines
>  [1]. 
"packager SHOULD use one of tools designed to locating JAR files in the 
system": whatever those tools are; that packaging guidelines page 
doesn't seem to tell

> > The bugzilla is
> https://bugzilla.redhat.com/show_bug.cgi?id=1965975
>  
>  I could add a compat symlink to the hamcrest package, but it seems
>  that the issue was fixed on the libreoffice side. 
yes, thanks, no need to adapt the hamcrest side

[...]
>  [1]
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#_hardcode...

[Mikolaj Izdebski]

On Tue, Jun 1, 2021 at 8:40 AM Stephan Bergmann <sbergman(a)redhat.com&gt; wrote:
>  On 01/06/2021 05:42, Mikolaj Izdebski wrote:
>  > On Mon, May 31, 2021 at 1:12 PM Miro Hrončok <mhroncok(a)redhat.com&gt; wrote:
>  [...]
>  >> Seems like the configure script (or whatever that is) fails to find hamcrest.
>  >
>  > That's because libreoffice hardcodes path to hamcrest JAR in the
>  > configure script, instead of using one of the tools designed to locate
>  > JAR files in the system. That is covered in Java Packaging Guidelines
>  > [1].
>
>  "packager SHOULD use one of tools designed to locating JAR files in the
>  system": whatever those tools are; that packaging guidelines page
>  doesn't seem to tell 
These would be find-jar, build-classpath, build-jar-repository etc.
from javapackages-tools. They are described in Java Packaging HOWTO.

Java packaging guideline is fairly minimal and primarily defines
policy (MUSTs and SHOULDs) for packaging Java. It strives not to
provide specific examples directly, but rather refers to Java
packaging HOWTO. The split into two documents, one maintained by FPC
that defines packaging policy and the other maintained by Java SIG
that provides packaging documentation, is intentional - it gives Java
SIG ability to work on packaging documentation without involving FPC
and at the same time keeps FPC in control of packaging policy.

--
Mikolaj Izdebski

>  >> The bugzilla is https://bugzilla.redhat.com/show_bug.cgi?id=1965975
>  >
>  > I could add a compat symlink to the hamcrest package, but it seems
>  > that the issue was fixed on the libreoffice side.
>
>  yes, thanks, no need to adapt the hamcrest side
>
>  [...]
>  > [1]
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#_hardcode...
>  _______________________________________________
>  devel mailing list -- devel(a)lists.fedoraproject.org
>  To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]
>  Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure

[Miro Hrončok]

On 01. 06. 21 5:42, Mikolaj Izdebski wrote:
>  On Mon, May 31, 2021 at 1:12 PM Miro Hrončok
> <mhroncok(a)redhat.com&gt; wrote:
> >
> > On 17. 05. 21 21:57, Mikolaj Izdebski wrote:
> >> Hello,
> >>
> >> Next week I'm going to update package hamcrest in Fedora rawhide from
> >> version 1.3 to version 2.2.
> >>
> >> The proposed update contains an API change that can affect packages
> >> depending on hamcrest.  You may need to rebuild your packages to keep
> >> working with updated hamcrest.
> >>
> >> The update has already been checked into dist-git and a Koji build has
> >> already been done, but Bodhi update has not been submitted yet.  Bodhi
> >> update is expected after a week, to comply with Updates Policy that
> >> mandates a notification one week in advance before submitting an API
> >> changing update.
> >>
> >>     Current NVR in rawhide: hamcrest-1.3-31.fc34
> >>     Updated NVR: hamcrest-2.2-3.fc35
> >>     Build link: https://koji.fedoraproject.org/koji/buildinfo?buildID=1748364
> >>
> >> Packages depending on hamcrest that are possibly affected by this update:
> >>    * eclipse, maintained by lef jerboaa dbhole rgrunber jjohnstn
> >> akurtakov ebaron oliver mbooth arobinso
> >>    * freemarker, maintained by filiperosset
> >>    * hamcrest, maintained by akurtakov mizdebsk jerboaa
> >>    * hdf, maintained by sagitter orion
> >>    * hdf5, maintained by deji sagitter orion ignatenkobrain
> >>    * icedtea-web, maintained by jvanek dbhole omajid
> >>    * jmock, maintained by orphan
> >>    * openas2, maintained by sdgathman
> >>    * py4j, maintained by raphgro
> >
> > Hey Mikolaj,
> >
> > libreoffice now fails to build because of this change and without building
> > libreoffice, we might need to postpone the Python 3.10 rebuild. I'd rather
> > avoid doing that. Would you please be able to help?
>  
> > The error is:
> >
> > checking for included Hamcrest... Not included
> > checking for standalone hamcrest jar.... configure: error: junit does not
> > contain hamcrest; please use a junit jar that includes hamcrest, install a
> > hamcrest jar in the default location (/usr/share/java),
> >                             specify its path with --with-hamcrest=..., or
> > disable junit with --without-junit
> >
> >
> > Seems like the configure script (or whatever that is) fails to find hamcrest.
>  
>  That's because libreoffice hardcodes path to hamcrest JAR in the
>  configure script, instead of using one of the tools designed to locate
>  JAR files in the system. That is covered in Java Packaging Guidelines
>  [1].
>  
> > The bugzilla is https://bugzilla.redhat.com/show_bug.cgi?id=1965975
>  
>  I could add a compat symlink to the hamcrest package, but it seems
>  that the issue was fixed on the libreoffice side. 
Indeed it was, sorry for the noise.

-- 
Miro Hrončok
-- 
Phone: [phone]
IRC: mhroncok