On Wed, Apr 17, 2024 at 9:52 PM Nathan Scott <nathans(a)redhat.com> wrote:
Hi all,
On Thu, Apr 18, 2024 at 2:38 AM Maxwell G <maxwell(a)gtmx.me> wrote:
>
> Thank you for submitting this!
+1
> > == Owner ==
> > * Name: [[User:jonathanspw|Jonathan Wright]]
> > * Email: jonathan(a)almalinux.org
>
> It would be nice to have Remi who currently maintains redis on board as well.
>
This is the second time this has been requested, but not yet actioned.
https://bugzilla.redhat.com/show_bug.cgi?id=2274206
https://src.fedoraproject.org/rpms/valkey
https://src.fedoraproject.org/rpms/redis
Can we resolve this before allowing this Change Proposal to proceed,
please? I think its in Fedora's interest to see 'new redis' maintained
by group, rather than an individual, if the existing maintainers wish to
(continue to) be involved.
The 'new' valkey package is very closely derived from redis packaging
which other Fedora maintainers have been looking after for ~14 years.
There is no big rush to switch AFAICT though, as Redis[Labs] stated
they continue to provide updates for redis-7.2.4 (including CVE fixes,
which is a big part of the Fedora workload) for the foreseeable future.
On the contrary, we *have* to do it sooner rather than later. As
divergence among the forks occurs and the community shifts away,
retaining Redis will just hurt us in the long term. Not to mention,
now that they've pulled this change on us (after saying they wouldn't
five years ago), there's no guarantee that they'd continue to do
anything. Their word isn't worth a lot anymore.
Some other technical questions:
- it could be advantageous if the new compat sub-package contained
the redis binary symlinks & not the primary valkey package (this could
allow valkey and redict packages to coexist, for example). Long-term
we may want to drop those entirely (along with the compat package, to
complete the transition away from Redis).
We will probably never be able to completely drop this, as stuff may
exist for a very long time that needs it.
- what happened to the man page patch Remi made? we should carry
it forward into the new package (and try again with new upstream folks
to get it merged there).
That patch should be completely rewritten for upstreaming anyway. It's
not written in a maintainable format, which really doesn't help for
upstreaming at all.
--
真実はいつも一つ!/ Always, there's only one truth!