On Thu, Jan 14, 2016 at 02:37:13PM -0500, Stephen Gallagher wrote:
On 01/14/2016 02:25 PM, Fabio Alessandro Locati wrote:
> During a Package Review I was doing on a python package, Kevin
> Kofler joined the conversation to point out that was wrong to
> suggest that the python packages should remove the egg-info
> provided by upstream. I was a little surprised by this so I
> started to look around and I found a wiki page
> (
https://fedoraproject.org/wiki/Packaging:Python_Eggs) confirming
> that this is an old policy that is now deprecated.
>
> Believing not to be the only packager that is used to delete the
> upstream egg-info folder, I scanned Fedora RPM specs and this is
> what I found: 459 packages do it.
>
> Since in the wiki page it's specified that this behavior is
> deprecated, I think all packagers having packages that delete
> egg-info files should improve their packages.
>
> This is the complete list of packages doing so.
>
Some (many?) of these packages only remove egg-info during %setup to
ensure that it gets regenerated by the %build phase (this is
particularly important for packages that may patch the requirements
from upstream to be more flexible with versions).
I guess this is only partially true.
Of these 459, 134 contain the string "rm -rf %{pypi_name}.egg-info"
which make me thinking that those packages are created with the pyp2rpm
tool, which adds this rm string _by default_ to all packages that have a
bundled egg-info (see:
https://github.com/fedora-python/pyp2rpm/blob/master/pyp2rpm/templates/fe...).
As for the other packages, my guess is that the majority were built when
this was still the policy and have not been modified when the policy
changed.
Have a nice day,
Fale
--
Fabio Alessandro Locati
PGP Fingerprint: B960 BE9D E7A8 FA12 273A 98BB 6D6A 29D6 709A 7851
https://keybase.io/fale