Staled PRs at https://src.fedoraproject.org/rpms/

[Miroslav Suchý]

During my work on SPDX migration I filed hundreds of pull request and as part of that work I always check if there is 
already open PRs for a package.

It surprised me how many packages has open PR. I understand when there is open PR with blocker or ongoing discussion. 
But I have seen PRs that are open for year+ without any comment from anyone.

I understood that it may happen that you miss the notification. Or postponed the work because you were busy and later 
forget about it... Lots of valid reasons.

I want to point to nice feature of Pagure - it can show you PR where you can act on:

https://src.fedoraproject.org/user/msuchy/requests?type=actionable&statu...

(your account icon -> My Pull Request -> PR I can act on)

Please check it, maybe you will discover some PR that is waiting on your feedback and you are not aware of it.

[Zbigniew Jędrzejewski-Szmek]

On Thu, Jan 25, 2024 at 08:07:03AM +0100, Miroslav Suchý wrote:
> During my work on SPDX migration I filed hundreds of pull request and as
> part of that work I always check if there is already open PRs for a package.
>
> It surprised me how many packages has open PR. I understand when there is
> open PR with blocker or ongoing discussion. But I have seen PRs that are
> open for year+ without any comment from anyone.
>
> I understood that it may happen that you miss the notification. Or postponed
> the work because you were busy and later forget about it... Lots of valid
> reasons.
>
> I want to point to nice feature of Pagure - it can show you PR where you can act on:
>
> https://src.fedoraproject.org/user/msuchy/requests?type=actionable&statu...
>
> (your account icon -> My Pull Request -> PR I can act on)
>
> Please check it, maybe you will discover some PR that is waiting on
> your feedback and you are not aware of it.

Hear, hear.

BTW, https://packager-dashboard.fedoraproject.org/ also shows those
pull requests.

Zbyszek

[Gary Buhrmaster]

On Thu, Jan 25, 2024 at 7:07 AM Miroslav Suchý  wrote:
> I understood that it may happen that you miss the notification. Or postponed the work because you were busy and later
> forget about it... Lots of valid reasons.

While I am certainly not in favor of more
"Are we there yet?" emails, I wonder if
a gentle reminder every few months
might not be appropriate if there are
open PR's, as, as you say, sometimes
there are valid reasons.

I also wonder if a PR open for more
than, say, 18 months might trigger
a check to make sure the packager
is still active.

Both are un-resourced ideas, of course.

[Smith, Stewart]

On Jan 24, 2024, at 11:07 PM, Miroslav Suchý  wrote:
> During my work on SPDX migration I filed hundreds of pull request and as part of that work I always check if there is
> already open PRs for a package.
>
> It surprised me how many packages has open PR. I understand when there is open PR with blocker or ongoing discussion.
> But I have seen PRs that are open for year+ without any comment from anyone.

This is something that has also caused some amount of frustration amongst the Amazon Linux team and can end up as a pretty large de-motivator for contributing changes back to Fedora. The context switching back to a long time ago, and then likely having to re-adapt your changes can certainly lead to choosing the path of not submitting the change as it’s less hassle.

Is a possible solution to tweak how/what provenpackagers can/do do, and perhaps surface at a higher level what the global list of “pull requests without comments for a month” and “open pull requests mentioning CVE or the word security”?  Have it be more of a common pattern to have provenpackagers ack and merge CRs across the board? Perhaps some tweaking around SIGs so that experts in the ecosystem in question are looking at CRs there?

We have a similar-ish model to how we maintain packages in Amazon Linux internally - the key being to avoid SPoF in knowledge, and to enable us to move fast when needed (e.g. getting an important security update out to customers).

[Florian Weimer]

* Miroslav Suchý:
> I want to point to nice feature of Pagure - it can show you PR where
> you can act on:
>
> https://src.fedoraproject.org/user/msuchy/requests?type=actionable&statu...
>
> (your account icon -> My Pull Request -> PR I can act on)
>
> Please check it, maybe you will discover some PR that is waiting on
> your feedback and you are not aware of it.

Is there a way to merge PR lists from multiple packages into a single
backlog?  We try to keep an eye on the bug list for our components, but
that only works (to some extent …) because Bugzilla allows us to
consolidate everything into a single list.  If we had this for PRs, it
would really help, I think.

Thanks,
Florian

[Miro Hrončok]

On 25. 01. 24 19:17, Florian Weimer wrote:
> Miroslav Suchý:
> > I want to point to nice feature of Pagure - it can show you PR where
> > you can act on:
> >
> > https://src.fedoraproject.org/user/msuchy/requests?type=actionable&statu...
> >
> > (your account icon -> My Pull Request -> PR I can act on)
> >
> > Please check it, maybe you will discover some PR that is waiting on
> > your feedback and you are not aware of it.
>
> Is there a way to merge PR lists from multiple packages into a single
> backlog?  We try to keep an eye on the bug list for our components, but
> that only works (to some extent …) because Bugzilla allows us to
> consolidate everything into a single list.  If we had this for PRs, it
> would really help, I think.

You can use the packager dashboard:

https://packager-dashboard.fedoraproject.org/dashboard?users=fweimer,churchy...

On the top right corner, you can click the git icon to only see PRs (probably 
not possible via a bookmarked URL but if that is the only blocker for your 
workflow, open an issue).

[Chris Kelley]

> Is there a way to merge PR lists from multiple packages into a single
> backlog?

I don't know about Pagure, but you can make bespoke packager dashboards to
show whatever combination of packages/packagers/groups you like :-)
https://packager-dashboard.fedoraproject.org/custom

Cheers,

Chris

On Thu, 25 Jan 2024 at 18:18, Florian Weimer  wrote:
> Miroslav Suchý:
> > I want to point to nice feature of Pagure - it can show you PR where
> > you can act on:
>
> https://src.fedoraproject.org/user/msuchy/requests?type=actionable&statu...
> > (your account icon -> My Pull Request -> PR I can act on)
> >
> > Please check it, maybe you will discover some PR that is waiting on
> > your feedback and you are not aware of it.
>
> Is there a way to merge PR lists from multiple packages into a single
> backlog?  We try to keep an eye on the bug list for our components, but
> that only works (to some extent …) because Bugzilla allows us to
> consolidate everything into a single list.  If we had this for PRs, it
> would really help, I think.
>
> Thanks,
> Florian
> --
> _______________________________________________
> devel mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]
> Do not reply to spam, report it:
> https://pagure.io/fedora-infrastructure/new_issue