Removal of krb5-devel from "stable" F29 buidroot broke my package

[Michal Schorm]

Hello folks

I maintain 'mariadb-connector-c' package, which build (amongst others)
a plugin that utilizes kerberos authentication to the MariaDB
database.

Recently, this very plugin stopped building. Everything else stayed the same.
The change appeared first after a commit that changes literally
nothing, but adds a "Requires: zlib-devel".

I compared the build and released versions before and after the commit.
On the Rawhide it could have been some buildroot change. That happens.
But the problem exists not only in Rawhide, but F30 and F29 too.

Simple add of "BuildRequires: krb5-devel" fixed the package.
However I'm generally upset, such change made it to the F29 buildroot,
breaking something.

--

Can you help me confirm, you know about this change in stable,
released F29 buildroot (and I just missed an annoucement) ?

Or do you spot a different cause?

--

Package builds to examine: (compare 3.0.9-2 & 3.0.9-3)
https://koji.fedoraproject.org/koji/packageinfo?packageID=19185

--

Michal Schorm
Software Engineer
Core Services - Databases Team
Red Hat

--

[Michal Schorm]

Another possible cause came up my mind.

Another package in the buildroot could have brought it as a
dependency, but does not bring it anymore ?


--

Michal Schorm
Software Engineer
Core Services - Databases Team
Red Hat

--

On Wed, May 15, 2019 at 5:08 PM Michal Schorm <mschorm(a)redhat.com&gt; wrote:
>
> Hello folks
>
> I maintain 'mariadb-connector-c' package, which build (amongst others)
> a plugin that utilizes kerberos authentication to the MariaDB
> database.
>
> Recently, this very plugin stopped building. Everything else stayed the same.
> The change appeared first after a commit that changes literally
> nothing, but adds a "Requires: zlib-devel".
>
> I compared the build and released versions before and after the commit.
> On the Rawhide it could have been some buildroot change. That happens.
> But the problem exists not only in Rawhide, but F30 and F29 too.
>
> Simple add of "BuildRequires: krb5-devel" fixed the package.
> However I'm generally upset, such change made it to the F29 buildroot,
> breaking something.
>
> --
>
> Can you help me confirm, you know about this change in stable,
> released F29 buildroot (and I just missed an annoucement) ?
>
> Or do you spot a different cause?
>
> --
>
> Package builds to examine: (compare 3.0.9-2 & 3.0.9-3)
> https://koji.fedoraproject.org/koji/packageinfo?packageID=19185
>
> --
>
> Michal Schorm
> Software Engineer
> Core Services - Databases Team
> Red Hat
>
> --

[Dominique Martinet]

Michal Schorm wrote on Wed, May 15, 2019 at 05:14:23PM +0200:
>  Another possible cause came up my mind.
>  
>  Another package in the buildroot could have brought it as a
>  dependency, but does not bring it anymore ? 
Yeah, it used to come with openssl-devel, but got removed very recently:
https://src.fedoraproject.org/rpms/openssl/c/7a654fc69c499b54f38543ca40f7...

-- 
Dominique

[Michal Schorm]

>  Yeah, it used to come with openssl-devel, but got removed very
> recently:
>  https://src.fedoraproject.org/rpms/openssl/c/7a654fc69c499b54f38543ca40f7...
Alright, I'm happy we found the cause and itś  not something more severe.

Thanks!

--

Michal Schorm
Software Engineer
Core Services - Databases Team
Red Hat

--

On Wed, May 15, 2019 at 5:30 PM Dominique Martinet
<dominique.martinet(a)cea.fr&gt; wrote:
>
> Michal Schorm wrote on Wed, May 15, 2019 at 05:14:23PM +0200:
> > Another possible cause came up my mind.
> >
> > Another package in the buildroot could have brought it as a
> > dependency, but does not bring it anymore ?
>
>  Yeah, it used to come with openssl-devel, but got removed very
> recently:
>  https://src.fedoraproject.org/rpms/openssl/c/7a654fc69c499b54f38543ca40f7...
>
> --
> Dominique
> _______________________________________________
> devel mailing list -- devel(a)lists.fedoraproject.org
> To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
https://lists.fedoraproject.org/archives/list/[e-mail]

[Vít Ondruch]

Dne 15. 05. 19 v 17:29 Dominique Martinet napsal(a):
>  Michal Schorm wrote on Wed, May 15, 2019 at 05:14:23PM +0200:
> > Another possible cause came up my mind.
> >
> > Another package in the buildroot could have brought it as a
> > dependency, but does not bring it anymore ?
>  Yeah, it used to come with openssl-devel, but got removed very recently:
>  https://src.fedoraproject.org/rpms/openssl/c/7a654fc69c499b54f38543ca40f7...
>  
This was removed on my request, triggered by this PR [1]. Nevertheless I
concur that this should happen just in Rawhide and never be backported
into stable releases.


Vít



[1] https://src.fedoraproject.org/rpms/ruby/pull-request/40

[Samuel Sieb]

On 5/15/19 10:50 PM, Vít Ondruch wrote:
>  Dne 15. 05. 19 v 17:29 Dominique Martinet napsal(a):
> > Yeah, it used to come with openssl-devel, but got removed very recently:
> >
> https://src.fedoraproject.org/rpms/openssl/c/7a654fc69c499b54f38543ca40f7...
>  
>  This was removed on my request, triggered by this PR [1]. Nevertheless I
>  concur that this should happen just in Rawhide and never be backported
>  into stable releases. 
I don't see why this is a problem.  Removing an unneeded build 
dependency from a package shouldn't affect anything else.  That it did 
merely pointed out a bug in the other package where the build deps were 
incomplete.

[Vít Ondruch]

Dne 16. 05. 19 v 7:58 Samuel Sieb napsal(a):
>  On 5/15/19 10:50 PM, Vít Ondruch wrote:
> > Dne 15. 05. 19 v 17:29 Dominique Martinet napsal(a):
> >> Yeah, it used to come with openssl-devel, but got removed very
> >> recently:
> >>
> https://src.fedoraproject.org/rpms/openssl/c/7a654fc69c499b54f38543ca40f7...
> >>
> >
> > This was removed on my request, triggered by this PR [1]. Nevertheless I
> > concur that this should happen just in Rawhide and never be backported
> > into stable releases.
>
>  I don't see why this is a problem.  Removing an unneeded build
>  dependency from a package shouldn't affect anything else.  That it did
>  merely pointed out a bug in the other package where the build deps
>  were incomplete. 

We lived with this "bug" for years. There is no reason to fix this bug
in stable release just to cause other bugs. And it was obvious it would
broke at least build of Ruby and now it is obvious it did broke not just
Ruby. It would be enough to have to solve this issues in Rawhide.

Also, (not) pulling -devel package into build root might result in some
subtle bugs such as some part of package functionality disabled based on
build configuration, which might went unnoticed, until the package is
released. This is irresponsible.


Vít

[Dominique Martinet]

Vít Ondruch wrote on Thu, May 16, 2019 at 08:28:45AM +0200:
>  >> This was removed on my request, triggered by this PR [1].
> Nevertheless I
>  >> concur that this should happen just in Rawhide and never be backported
>  >> into stable releases.
>  >
>  > I don't see why this is a problem.  Removing an unneeded build
>  > dependency from a package shouldn't affect anything else.  That it did
>  > merely pointed out a bug in the other package where the build deps
>  > were incomplete. 
The problem is not the build dependency, you can get rid of it
everywhere without any impact except for openssl itself.

What is less transparent is the removal of an actual Require (two
actually, zlib-devel is no longer pulled either) ; that can impact other
packages and workflows.
Someone installing openssl-devel could have expected it to pull
krb5-devel and zlib-devel, now they need to install it explicitely
separately for their own use as well, it's a change in user interface.

>  We lived with this "bug" for years. There is no reason to
> fix this bug
>  in stable release just to cause other bugs. And it was obvious it would
>  broke at least build of Ruby and now it is obvious it did broke not just
>  Ruby. It would be enough to have to solve this issues in Rawhide.
>  
>  Also, (not) pulling -devel package into build root might result in some
>  subtle bugs such as some part of package functionality disabled based on
>  build configuration, which might went unnoticed, until the package is
>  released. This is irresponsible. 
configure with feature autodetection is a PITA :/

-- 
Dominique

[Dridi Boukelmoune]

>  configure with feature autodetection is a PITA :/ 
The PITA doesn't come from auto-detection, rather auto-selection of
(optional) dependencies. I tend to prefer explicit --with-* or --enable-*
flags for anything optional and fixed defaults.

It would be worse if we had to tell a configure script where each
individual build dependency can be found! There tend to be more
than what meets the eye, much more. Take your average project
building with autotools and try this:

    ./configure --help | less

Dridi

[Igor Gnatenko]

In meson we automatically set all "auto" features to be "enabled". So
people have to disable things they don't want manually.

On Thu, May 16, 2019, 10:00 Dridi Boukelmoune <dridi.boukelmoune(a)gmail.com&gt;
wrote:

>  > configure with feature autodetection is a PITA :/
>
>  The PITA doesn't come from auto-detection, rather auto-selection of
>  (optional) dependencies. I tend to prefer explicit --with-* or --enable-*
>  flags for anything optional and fixed defaults.
>
>  It would be worse if we had to tell a configure script where each
>  individual build dependency can be found! There tend to be more
>  than what meets the eye, much more. Take your average project
>  building with autotools and try this:
>
>      ./configure --help | less
>
>  Dridi
>  _______________________________________________
>  devel mailing list -- devel(a)lists.fedoraproject.org
>  To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
>  https://lists.fedoraproject.org/archives/list/[e-mail]
>

[Vít Ondruch]

Dne 16. 05. 19 v 9:20 Dominique Martinet napsal(a):
>  Vít Ondruch wrote on Thu, May 16, 2019 at 08:28:45AM +0200:
> >>> This was removed on my request, triggered by this PR [1]. Nevertheless I
> >>> concur that this should happen just in Rawhide and never be backported
> >>> into stable releases.
> >> I don't see why this is a problem.  Removing an unneeded build
> >> dependency from a package shouldn't affect anything else.  That it did
> >> merely pointed out a bug in the other package where the build deps
> >> were incomplete.
>  The problem is not the build dependency, you can get rid of it
>  everywhere without any impact except for openssl itself.
>
>  What is less transparent is the removal of an actual Require (two
>  actually, zlib-devel is no longer pulled either) ; that can impact other
>  packages and workflows. 

Ah, right, I meant Require of course. I stand corrected. Thx.


Vít


> Someone installing openssl-devel could have expected it to pull
> krb5-devel and zlib-devel, now they need to install it explicitely
> separately for their own use as well, it's a change in user interface.
>
>> We lived with this "bug" for years. There is no reason to fix this bug
>> in stable release just to cause other bugs. And it was obvious it would
>> broke at least build of Ruby and now it is obvious it did broke not just
>> Ruby. It would be enough to have to solve this issues in Rawhide.
>>
>> Also, (not) pulling -devel package into build root might result in some
>> subtle bugs such as some part of package functionality disabled based on
>> build configuration, which might went unnoticed, until the package is
>> released. This is irresponsible.
> configure with feature autodetection is a PITA :/
>

[Tomas Mraz]

On Thu, 2019-05-16 at 07:50 +0200, Vít Ondruch wrote:
>  Dne 15. 05. 19 v 17:29 Dominique Martinet napsal(a):
>  > Michal Schorm wrote on Wed, May 15, 2019 at 05:14:23PM +0200:
>  > > Another possible cause came up my mind.
>  > > 
>  > > Another package in the buildroot could have brought it as a
>  > > dependency, but does not bring it anymore ?
>  > Yeah, it used to come with openssl-devel, but got removed very
>  > recently:
>  >
> https://src.fedoraproject.org/rpms/openssl/c/7a654fc69c499b54f38543ca40f7...
>  > 
>  
>  This was removed on my request, triggered by this PR [1].
>  Nevertheless I
>  concur that this should happen just in Rawhide and never be
>  backported
>  into stable releases. 
Well... that's debatable. There is no promise that the stable releases
won't break broken packages working only accidentaly. The fix is simple
add the proper build dependency if you need it and do not depend on it
being pulled in by something else.

-- 
Tomáš Mráz
No matter how far down the wrong road you've gone, turn back.
                                              Turkish proverb
[You'll know whether the road is wrong if you carefully listen to your
conscience.]