hiredis soname bump

[Kevin Fenzi]

Greetings. 

We currently have hiredis-0.13.3-16 in rawhide, I'd like to upgrade to
1.0.2, which includes a soname bump. 

I plan to make a side tag and build dependent packages the next few
days.

I've rebuilt everything in a copr:
https://copr.fedorainfracloud.org/coprs/kevin/hiredis/builds/

The two failures were rsyslog and opensips, but they both fail the same
way in rawhide. 

dependent packages are:

alexandria
ccache  
collectd        
coturn  
gawk-redis      
gearmand        
icecat  
idzebra         
minetest        
minetestmapper  
opensips        
php-phpiredis   
rsyslog         
sems    
seqan3  
subtitleeditor  
suricata        
syslog-ng       
tellico         
yaz     
zmap    

kevin

[Nathan Scott]

Hi Kevin,

On Mon, Jan 17, 2022 at 7:05 AM Kevin Fenzi <kevin(a)scrye.com&gt; wrote:
>  Greetings.
>
>  We currently have hiredis-0.13.3-16 in rawhide, I'd like to upgrade to
>  1.0.2, which includes a soname bump. 
I think upstream may have reverted this change FWIW ...
https://github.com/redis/hiredis/issues/990

cheers.

--
Nathan

[Iñaki Ucar]

On Mon, 17 Jan 2022 at 00:21, Nathan Scott <nathans(a)redhat.com&gt; wrote:
>  Hi Kevin,
>
>  On Mon, Jan 17, 2022 at 7:05 AM Kevin Fenzi <kevin(a)scrye.com&gt; wrote:
>  >
>  > Greetings.
>  >
>  > We currently have hiredis-0.13.3-16 in rawhide, I'd like to upgrade to
>  > 1.0.2, which includes a soname bump.
>
>  I think upstream may have reverted this change FWIW ...
>  https://github.com/redis/hiredis/issues/990 
This refers to the incorrect SONAME bump in 1.0.1 with respect to
1.0.0. But as Kevin said, we still have 0.13.3 in Fedora, so...

-- 
Iñaki Úcar

[Nathan Scott]

On Mon, Jan 17, 2022 at 10:35 AM Iñaki Ucar <iucar(a)fedoraproject.org&gt; wrote:
>  On Mon, 17 Jan 2022 at 00:21, Nathan Scott <nathans(a)redhat.com&gt;
> wrote:
>  > On Mon, Jan 17, 2022 at 7:05 AM Kevin Fenzi <kevin(a)scrye.com&gt; wrote:
>  > >
>  > > Greetings.
>  > >
>  > > We currently have hiredis-0.13.3-16 in rawhide, I'd like to upgrade to
>  > > 1.0.2, which includes a soname bump.
>  >
>  > I think upstream may have reverted this change FWIW ...
>  > https://github.com/redis/hiredis/issues/990
>
>  This refers to the incorrect SONAME bump in 1.0.1 with respect to
>  1.0.0. But as Kevin said, we still have 0.13.3 in Fedora, so... 
Aha - right you are, thanks for the correction.

cheers.

--
Nathan

[Kevin Fenzi]

On Mon, Jan 17, 2022 at 10:44:57AM +1100, Nathan Scott wrote:
>  On Mon, Jan 17, 2022 at 10:35 AM Iñaki Ucar
> <iucar(a)fedoraproject.org&gt; wrote:
>  > On Mon, 17 Jan 2022 at 00:21, Nathan Scott <nathans(a)redhat.com&gt; wrote:
>  > > On Mon, Jan 17, 2022 at 7:05 AM Kevin Fenzi <kevin(a)scrye.com&gt; wrote:
>  > > >
>  > > > Greetings.
>  > > >
>  > > > We currently have hiredis-0.13.3-16 in rawhide, I'd like to upgrade
> to
>  > > > 1.0.2, which includes a soname bump.
>  > >
>  > > I think upstream may have reverted this change FWIW ...
>  > > https://github.com/redis/hiredis/issues/990
>  >
>  > This refers to the incorrect SONAME bump in 1.0.1 with respect to
>  > 1.0.0. But as Kevin said, we still have 0.13.3 in Fedora, so...
>  
>  Aha - right you are, thanks for the correction. 
ok, so I made the sidetag (f36-build-side-49618) and rebuilt things, 
but of course now there's 4 more erroring packages (I guess due to gcc12?).
Any help welcomed. :) 

(bccing maintainers)

gearmand
https://koji.fedoraproject.org/koji/taskinfo?taskID=81386050
...
./gear_config.h:35:25: error: conversion from 'int' to 'const std::string'
{aka 'const std::__cxx11::basic_string<char>'} is ambiguous

sems
https://koji.fedoraproject.org/koji/taskinfo?taskID=81386117
...
/builddir/build/BUILD/sems-baad4717fdb3c02a63eb4869f31ec33ff8ec1fed/core/tests/fct.h:267:12:
error: '__builtin_strncpy' specified bound 256 equals destination size
[-Werror=stringop-truncation]

seqan3
https://koji.fedoraproject.org/koji/taskinfo?taskID=81386062
/builddir/build/BUILD/seqan3-3.1.0/include/seqan3/utility/concept/exposition_only/core_language.hpp:67:5:
error: testing if a concept-id is a valid expression; add 'requires' to check
satisfaction [-Werror=missing-requires]
   67 |     std::convertible_to<decltype(v2 >= v1), bool>;

suircata
https://koji.fedoraproject.org/koji/taskinfo?taskID=81386008
   Compiling suricata v6.0.4 (/builddir/build/BUILD/suricata-6.0.4/rust)
/usr/lib/librustc_driver-f074454651f889f4.so(+0x4d3083)[0xf3c95083]
linux-gate.so.1(__kernel_sigreturn+0x0)[0xf7f9a570]
/usr/lib/libLLVM-13.so(+0xf564fe)[0xee3684fe]
/usr/lib/libLLVM-13.so(+0xf586ae)[0xee36a6ae]
/usr/lib/libLLVM-13.so(+0x104900f)[0xee45b00f]
/usr/lib/libLLVM-13.so(_ZN4llvm18ScheduleDAGSDNodes12EmitScheduleERNS_26MachineInstrBundleIteratorINS_12MachineInstrELb0EEE+0x382)[0xee45a1a2]
/usr/lib/libLLVM-13.so(_ZN4llvm16SelectionDAGISel17CodeGenAndEmitDAGEv+0xa2a)[0xee532fca]
/usr/lib/libLLVM-13.so(_ZN4llvm16SelectionDAGISel16SelectBasicBlockENS_14ilist_iteratorINS_12ilist_detail12node_optionsINS_11InstructionELb0ELb0EvEELb0ELb1EEES6_Rb+0x303)[0xee532543]
/usr/lib/libLLVM-13.so(_ZN4llvm16SelectionDAGISel20SelectAllBasicBlocksERKNS_8FunctionE+0x2204)[0xee531d14]
/usr/lib/libLLVM-13.so(_ZN4llvm16SelectionDAGISel20runOnMachineFunctionERNS_15MachineFunctionE+0xc22)[0xee52e932]
/usr/lib/libLLVM-13.so(+0x37b98e1)[0xf0bcb8e1]
/usr/lib/libLLVM-13.so(_ZN4llvm19MachineFunctionPass13runOnFunctionERNS_8FunctionE+0x14b)[0xedfddd0b]
/usr/lib/libLLVM-13.so(_ZN4llvm13FPPassManager13runOnFunctionERNS_8FunctionE+0x598)[0xedd407d8]
/usr/lib/libLLVM-13.so(_ZN4llvm13FPPassManager11runOnModuleERNS_6ModuleE+0x48)[0xedd48148]
/usr/lib/libLLVM-13.so(_ZN4llvm6legacy15PassManagerImpl3runERNS_6ModuleE+0x43b)[0xedd40fdb]
/usr/lib/libLLVM-13.so(_ZN4llvm6legacy11PassManager3runERNS_6ModuleE+0x2b)[0xedd484fb]
/usr/lib/librustc_driver-f074454651f889f4.so(+0x5702ed)[0xf3d322ed]
/usr/lib/librustc_driver-f074454651f889f4.so(+0x8752aa)[0xf40372aa]
/usr/lib/librustc_driver-f074454651f889f4.so(+0x87aefe)[0xf403cefe]
/usr/lib/librustc_driver-f074454651f889f4.so(+0x893167)[0xf4055167]
/usr/lib/librustc_driver-f074454651f889f4.so(+0x88c6e4)[0xf404e6e4]
/usr/lib/librustc_driver-f074454651f889f4.so(+0x7a91a3)[0xf3f6b1a3]
/usr/lib/librustc_driver-f074454651f889f4.so(+0x820c27)[0xf3fe2c27]
/usr/lib/libstd-1c430345c3146024.so(rust_metadata_std_6938c2bdeba667b5+0x9d37b)[0xf36d537b]
/usr/lib/libc.so.6(+0x8baf1)[0xf34d9af1]
/usr/lib/libc.so.6(+0x1118cc)[0xf355f8cc]
error: could not compile `suricata`

kevin

[Remi Collet]

Le 18/01/2022 à 02:53, Kevin Fenzi a écrit :
>  ok, so I made the sidetag (f36-build-side-49618) and rebuilt things,
>  but of course now there's 4 more erroring packages (I guess due to gcc12?).
>  Any help welcomed. :) 
php-phpiredis is also broken, but sadly not detected during the build

I open a upstream PR to fix this and run a new build


Cheers,
Remi




P.S. minimal test is broken with recent change in PHP :(


+ : Minimal load test for NTS extension
+ /usr/bin/php --no-php-ini --define 
extension=/builddir/build/BUILDROOT/php-phpiredis-1.0.1-6.fc36.arm/usr/lib/php/modules/phpiredis.so

--modules
+ grep phpiredis
Warning: PHP Startup: Unable to load dynamic library 
'/builddir/build/BUILDROOT/php-phpiredis-1.0.1-6.fc36.arm/usr/lib/php/modules/phpiredis.so'

(tried: 
/builddir/build/BUILDROOT/php-phpiredis-1.0.1-6.fc36.arm/usr/lib/php/modules/phpiredis.so

(/builddir/build/BUILDROOT/php-phpiredis-1.0.1-6.fc36.arm/usr/lib/php/modules/phpiredis.so:

undefined symbol: redisReplyReaderGetError), 
/usr/lib/php/modules//builddir/build/BUILDROOT/php-phpiredis-1.0.1-6.fc36.arm/usr/lib/php/modules/phpiredis.so.so

(/usr/lib/php/modules//builddir/build/BUILDROOT/php-phpiredis-1.0.1-6.fc36.arm/usr/lib/php/modules/phpiredis.so.so:

cannot open shared object file: No such file or directory)) in Unknown 
on line 0


This is also fixed (stricter grep pattern)

+ : Minimal load test for NTS extension
+ /usr/bin/php --no-php-ini --define 
extension=/dev/shm/BUILDROOT/php-phpiredis-1.0.1-4.fc35.remi.8.0.x86_64/usr/lib64/php/modules/phpiredis.so

--modules
+ grep '^phpiredis$'
phpiredis

[Robin Lee]

On Tue, Jan 18, 2022 at 9:53 AM Kevin Fenzi <kevin(a)scrye.com&gt; wrote:
>  On Mon, Jan 17, 2022 at 10:44:57AM +1100, Nathan Scott wrote:
>  > On Mon, Jan 17, 2022 at 10:35 AM Iñaki Ucar <iucar(a)fedoraproject.org&gt; wrote:
>  > > On Mon, 17 Jan 2022 at 00:21, Nathan Scott <nathans(a)redhat.com&gt; wrote:
>  > > > On Mon, Jan 17, 2022 at 7:05 AM Kevin Fenzi <kevin(a)scrye.com&gt;
> wrote:
>  > > > >
>  > > > > Greetings.
>  > > > >
>  > > > > We currently have hiredis-0.13.3-16 in rawhide, I'd like to
> upgrade to
>  > > > > 1.0.2, which includes a soname bump.
>  > > >
>  > > > I think upstream may have reverted this change FWIW ...
>  > > > https://github.com/redis/hiredis/issues/990
>  > >
>  > > This refers to the incorrect SONAME bump in 1.0.1 with respect to
>  > > 1.0.0. But as Kevin said, we still have 0.13.3 in Fedora, so...
>  >
>  > Aha - right you are, thanks for the correction.
>
>  ok, so I made the sidetag (f36-build-side-49618) and rebuilt things,
>  but of course now there's 4 more erroring packages (I guess due to gcc12?).
>  Any help welcomed. :)
>
>  (bccing maintainers)
>
>  gearmand
>  https://koji.fedoraproject.org/koji/taskinfo?taskID=81386050
>  ...
>  ./gear_config.h:35:25: error: conversion from 'int' to 'const
> std::string' {aka 'const std::__cxx11::basic_string<char>'} is ambiguous
Fixed build in the side tag.
>
> sems
> https://koji.fedoraproject.org/koji/taskinfo?taskID=81386117
> ...
>
/builddir/build/BUILD/sems-baad4717fdb3c02a63eb4869f31ec33ff8ec1fed/core/tests/fct.h:267:12:
error: '__builtin_strncpy' specified bound 256 equals destination size
[-Werror=stringop-truncation]
>
> seqan3
> https://koji.fedoraproject.org/koji/taskinfo?taskID=81386062
>
/builddir/build/BUILD/seqan3-3.1.0/include/seqan3/utility/concept/exposition_only/core_language.hpp:67:5:
error: testing if a concept-id is a valid expression; add 'requires' to check
satisfaction [-Werror=missing-requires]
>    67 |     std::convertible_to<decltype(v2 >= v1), bool>;
>
> suircata
> https://koji.fedoraproject.org/koji/taskinfo?taskID=81386008
>    Compiling suricata v6.0.4 (/builddir/build/BUILD/suricata-6.0.4/rust)
> /usr/lib/librustc_driver-f074454651f889f4.so(+0x4d3083)[0xf3c95083]
> linux-gate.so.1(__kernel_sigreturn+0x0)[0xf7f9a570]
> /usr/lib/libLLVM-13.so(+0xf564fe)[0xee3684fe]
> /usr/lib/libLLVM-13.so(+0xf586ae)[0xee36a6ae]
> /usr/lib/libLLVM-13.so(+0x104900f)[0xee45b00f]
>
/usr/lib/libLLVM-13.so(_ZN4llvm18ScheduleDAGSDNodes12EmitScheduleERNS_26MachineInstrBundleIteratorINS_12MachineInstrELb0EEE+0x382)[0xee45a1a2]
>
/usr/lib/libLLVM-13.so(_ZN4llvm16SelectionDAGISel17CodeGenAndEmitDAGEv+0xa2a)[0xee532fca]
>
/usr/lib/libLLVM-13.so(_ZN4llvm16SelectionDAGISel16SelectBasicBlockENS_14ilist_iteratorINS_12ilist_detail12node_optionsINS_11InstructionELb0ELb0EvEELb0ELb1EEES6_Rb+0x303)[0xee532543]
>
/usr/lib/libLLVM-13.so(_ZN4llvm16SelectionDAGISel20SelectAllBasicBlocksERKNS_8FunctionE+0x2204)[0xee531d14]
>
/usr/lib/libLLVM-13.so(_ZN4llvm16SelectionDAGISel20runOnMachineFunctionERNS_15MachineFunctionE+0xc22)[0xee52e932]
> /usr/lib/libLLVM-13.so(+0x37b98e1)[0xf0bcb8e1]
>
/usr/lib/libLLVM-13.so(_ZN4llvm19MachineFunctionPass13runOnFunctionERNS_8FunctionE+0x14b)[0xedfddd0b]
>
/usr/lib/libLLVM-13.so(_ZN4llvm13FPPassManager13runOnFunctionERNS_8FunctionE+0x598)[0xedd407d8]
>
/usr/lib/libLLVM-13.so(_ZN4llvm13FPPassManager11runOnModuleERNS_6ModuleE+0x48)[0xedd48148]
>
/usr/lib/libLLVM-13.so(_ZN4llvm6legacy15PassManagerImpl3runERNS_6ModuleE+0x43b)[0xedd40fdb]
>
/usr/lib/libLLVM-13.so(_ZN4llvm6legacy11PassManager3runERNS_6ModuleE+0x2b)[0xedd484fb]
> /usr/lib/librustc_driver-f074454651f889f4.so(+0x5702ed)[0xf3d322ed]
> /usr/lib/librustc_driver-f074454651f889f4.so(+0x8752aa)[0xf40372aa]
> /usr/lib/librustc_driver-f074454651f889f4.so(+0x87aefe)[0xf403cefe]
> /usr/lib/librustc_driver-f074454651f889f4.so(+0x893167)[0xf4055167]
> /usr/lib/librustc_driver-f074454651f889f4.so(+0x88c6e4)[0xf404e6e4]
> /usr/lib/librustc_driver-f074454651f889f4.so(+0x7a91a3)[0xf3f6b1a3]
> /usr/lib/librustc_driver-f074454651f889f4.so(+0x820c27)[0xf3fe2c27]
>
/usr/lib/libstd-1c430345c3146024.so(rust_metadata_std_6938c2bdeba667b5+0x9d37b)[0xf36d537b]
> /usr/lib/libc.so.6(+0x8baf1)[0xf34d9af1]
> /usr/lib/libc.so.6(+0x1118cc)[0xf355f8cc]
> error: could not compile `suricata`
>
> kevin

[Kevin Fenzi]

Thanks for the fixes. 

I went ahead and merged the side tag because the broken by gcc packages
will be broken by the mass rebuild anyhow. :( 

I'll try and poke at them some more next weekend...

kevin

[Miro Hrončok]

On 19. 01. 22 23:02, Kevin Fenzi wrote:
>  Thanks for the fixes.
>  
>  I went ahead and merged the side tag because the broken by gcc packages
>  will be broken by the mass rebuild anyhow. :(
>  
>  I'll try and poke at them some more next weekend... 
https://bugzilla.redhat.com/show_bug.cgi?id=2042939
https://bugzilla.redhat.com/show_bug.cgi?id=2042940
https://bugzilla.redhat.com/show_bug.cgi?id=2042941
https://bugzilla.redhat.com/show_bug.cgi?id=2042942
https://bugzilla.redhat.com/show_bug.cgi?id=2042943

-- 
Miro Hrončok
-- 
Phone: [phone]
IRC: mhroncok