install command nit

[Richard Shaw]

I noticed a warning on one of my packages that the appdata file was marked
as executable. The source file is not, its 644, but I use the install
command to install it to the metainfo directory.

Does "install" install files as executable by default or is something else
going on here?

Adding -m 0644 fixed it but it shouldn't be necessary.

Thanks,
Richard

[Florian Weimer]

* Richard Shaw:

>  Does "install" install files as executable by default or is
> something
>  else going on here? 
According to the manual page, the install program uses 0755 by default:

       -m, --mode=MODE
              set permission mode (as in chmod), instead of rwxr-xr-x

I don't think this is something we can change at this point.

Thanks,
Florian

[Richard Shaw]

On Sat, Feb 2, 2019 at 8:16 AM Florian Weimer <fweimer(a)redhat.com&gt; wrote:

>  * Richard Shaw:
>
>  > Does "install" install files as executable by default or is something
>  > else going on here?
>
>  According to the manual page, the install program uses 0755 by default:
>
>         -m, --mode=MODE
>                set permission mode (as in chmod), instead of rwxr-xr-x
>
>  I don't think this is something we can change at this point.
>  
Nope... Thanks.

Richard

[Björn 'besser82' Esser]

Am Samstag, den 02.02.2019, 07:05 -0600 schrieb Richard Shaw:
>  I noticed a warning on one of my packages that the appdata file was
>  marked as executable. The source file is not, its 644, but I use the
>  install command to install it to the metainfo directory.
>  
>  Does "install" install files as executable by default or is something
>  else going on here?
>  
>  Adding -m 0644 fixed it but it shouldn't be necessary. 

Quoting from `man install`:

>  -m, --mode=MODE
>    set permission mode (as in chmod), instead of rwxr-xr-x 
So the `install` command is supposed to set the file mode to 0755 by
default, if not explicitly required different.

Cheers,
  Björn