Hello folks,
before all, I want to thank everyone putting their time in reviewing new package requests! That is a key task in distinguish Fedora among the other Linux distribution and ensure we have high quality packages in our repositories.
That said, I'd like to make a request and maybe make all reviewers aware of a feature which was implemented some time ago. I've noticed many reviewers change the ticket status from ASSIGNED to POST when they flag the package as approved: I'd like to request to not do that.
The Package Review Tracker webpages make a distinction between packages approved (fedora-review flag set to +) and packages approved AND being built in Fedora. That distinction relies on the ticket status change to POST, which is automatically set when the repository is created in src.fp.o.
I think that distinction can be useful to see all packages that were approved, but for some reason the submitter never asked for the repository to be created. So, if you also think that is useful and can change what it may have become a routine for you, just set the review flag accordingly without changing the ticket status.
BTW, for the future (if I find some spare time) I plan to change the interface of the Package Review Tracker webpages by moving from using colors to icons. That's because the colors are currently mutually exclusive i.e. whenever a ticket is marked NEEDSPONSOR, the green background will take precedence over all other descriptions. By using multiple icons, we can have better "visual categorization" (and, maybe, enhance the js filter). But before doing so, I'll make a preview of the change and post it here (or on Discussion) to get some feedback...
Thanks Mattia
On Mon, Jan 29, 2024 at 7:47 PM Mattia Verga via devel devel@lists.fedoraproject.org wrote:
(snip)
That said, I'd like to make a request and maybe make all reviewers aware of a feature which was implemented some time ago. I've noticed many reviewers change the ticket status from ASSIGNED to POST when they flag the package as approved: I'd like to request to not do that.
The Package Review Tracker webpages make a distinction between packages approved (fedora-review flag set to +) and packages approved AND being built in Fedora. That distinction relies on the ticket status change to POST, which is automatically set when the repository is created in src.fp.o.
Hum ... am I missing something here?
The bot that creates the dist-git repos does *NOT*, in fact, set the bug status to POST: https://bugzilla.redhat.com/show_bug.cgi?id=2260350#c5
Fabio
Il 01/02/24 22:44, Fabio Valentini ha scritto:
On Mon, Jan 29, 2024 at 7:47 PM Mattia Verga via devel devel@lists.fedoraproject.org wrote: (snip)
That said, I'd like to make a request and maybe make all reviewers aware of a feature which was implemented some time ago. I've noticed many reviewers change the ticket status from ASSIGNED to POST when they flag the package as approved: I'd like to request to not do that.
The Package Review Tracker webpages make a distinction between packages approved (fedora-review flag set to +) and packages approved AND being built in Fedora. That distinction relies on the ticket status change to POST, which is automatically set when the repository is created in src.fp.o.
Hum ... am I missing something here?
The bot that creates the dist-git repos does *NOT*, in fact, set the bug status to POST: https://bugzilla.redhat.com/show_bug.cgi?id=2260350#c5
Fabio
Well... it should: https://pagure.io/fedora-infra/toddlers/pull-request/158
Mattia
On Sat, Feb 3, 2024, 11:04 AM Mattia Verga via devel < devel@lists.fedoraproject.org> wrote:
Il 01/02/24 22:44, Fabio Valentini ha scritto:
On Mon, Jan 29, 2024 at 7:47 PM Mattia Verga via devel devel@lists.fedoraproject.org wrote: (snip)
That said, I'd like to make a request and maybe make all reviewers aware of a feature which was implemented some time ago. I've noticed many reviewers change the ticket status from ASSIGNED to POST when they flag the package as approved: I'd like to request to not do that.
The Package Review Tracker webpages make a distinction between packages approved (fedora-review flag set to +) and packages approved AND being built in Fedora. That distinction relies on the ticket status change to POST, which is automatically set when the repository is created in
src.fp.o.
Hum ... am I missing something here?
The bot that creates the dist-git repos does *NOT*, in fact, set the bug status to POST: https://bugzilla.redhat.com/show_bug.cgi?id=2260350#c5
Fabio
Well... it should: https://pagure.io/fedora-infra/toddlers/pull-request/158
That has never worked. Also, POST is the wrong status for that. RELEASE_PENDING would make more sense instead.
On Mon, Jan 29, 2024 at 06:47:21PM +0000, Mattia Verga via devel wrote:
That said, I'd like to make a request and maybe make all reviewers aware of a feature which was implemented some time ago. I've noticed many reviewers change the ticket status from ASSIGNED to POST when they flag the package as approved: I'd like to request to not do that.
The reason for POST is that this allows the reviews that are "done" from the reviewer's side to be easily distinguished in a bugzilla listing. E.g. my reviews are [1], and then I only need to care about those with ASSIGNED.
If we're not supposed to use POST, then please provide this functionality in some different form. (I think the suggestion from the other part of thread to use RELEASE_PENDING is better.)
[1] https://bugzilla.redhat.com/buglist.cgi?classification=Fedora&component=...
Zbyszek
V Tue, Feb 06, 2024 at 01:34:54PM +0000, Zbigniew Jędrzejewski-Szmek napsal(a):
On Mon, Jan 29, 2024 at 06:47:21PM +0000, Mattia Verga via devel wrote:
That said, I'd like to make a request and maybe make all reviewers aware of a feature which was implemented some time ago. I've noticed many reviewers change the ticket status from ASSIGNED to POST when they flag the package as approved: I'd like to request to not do that.
The reason for POST is that this allows the reviews that are "done" from the reviewer's side to be easily distinguished in a bugzilla listing.
flags == fedora-review+
I don't say its easy to query, but it's the normative way stating that the reviewer is done.
-- Petr
Il 06/02/24 14:34, Zbigniew Jędrzejewski-Szmek ha scritto:
On Mon, Jan 29, 2024 at 06:47:21PM +0000, Mattia Verga via devel wrote:
That said, I'd like to make a request and maybe make all reviewers aware of a feature which was implemented some time ago. I've noticed many reviewers change the ticket status from ASSIGNED to POST when they flag the package as approved: I'd like to request to not do that.
The reason for POST is that this allows the reviews that are "done" from the reviewer's side to be easily distinguished in a bugzilla listing. E.g. my reviews are [1], and then I only need to care about those with ASSIGNED.
If we're not supposed to use POST, then please provide this functionality in some different form. (I think the suggestion from the other part of thread to use RELEASE_PENDING is better.)
Sure, the 'POST' usage has been inherited by the old review ticket status webpages. When I rewrite the code I used the same statuses, but I agree that it may have much more sense to use 'RELEASE_PENDING'. If there isn't any objection e.g. disrupting someone's else tool workflow, I can easily change that.
BTW, the ticket status is not changed automatically upon repository creation because I now realize there was an error in the code I submitted to toddlers. There is now a PR to fix that [1]
Mattia
[1] https://pagure.io/fedora-infra/toddlers/pull-request/184