qarte - compilation fails

[Martin Gansser]

Hi,

when compiling qarte-4.4.0 with this spec file
https://martinkg.fedorapeople.org/Packages/test/qarte.spec

 '[' noarch = noarch ']'
+ case "${QA_CHECK_RPATHS:-}" in
+ /usr/lib/rpm/check-buildroot
+ /usr/lib/rpm/brp-compress
+ /usr/lib/rpm/brp-strip-static-archive /usr/bin/strip
+ /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1
Compiling
/home/martin/rpmbuild/BUILDROOT/qarte-4.0.0-1.fc27.x86_64/usr/share/qarte/arteconcert.py
...
  File "/usr/share/qarte/arteconcert.py", line 385
    def update_pitch(self, *args, html=False):
                                     ^
SyntaxError: invalid syntax

error: Bad exit status from /var/tmp/rpm-tmp.rp9wQD (%install)

only when i comment the following line, the program compiles fine:
#####cp -p *.py* %{buildroot}%{_datadir}/%{name}

[Charalampos Stratakis]

----- Original Message -----
>  From: "Martin Gansser" <martin.gansser(a)gmail.com&gt;
>  To: devel(a)lists.fedoraproject.org
>  Sent: Thursday, March 1, 2018 11:35:25 AM
>  Subject: qarte - compilation fails
>  
>  Hi,
>  
>  when compiling qarte-4.4.0 with this spec file
>  https://martinkg.fedorapeople.org/Packages/test/qarte.spec
>  
>   '[' noarch = noarch ']'
>  + case "${QA_CHECK_RPATHS:-}" in
>  + /usr/lib/rpm/check-buildroot
>  + /usr/lib/rpm/brp-compress
>  + /usr/lib/rpm/brp-strip-static-archive /usr/bin/strip
>  + /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1
>  Compiling
>  /home/martin/rpmbuild/BUILDROOT/qarte-4.0.0-1.fc27.x86_64/usr/share/qarte/arteconcert.py
>  ...
>    File "/usr/share/qarte/arteconcert.py", line 385
>      def update_pitch(self, *args, html=False):
>                                       ^
>  SyntaxError: invalid syntax
>  
>  error: Bad exit status from /var/tmp/rpm-tmp.rp9wQD (%install)
>  
>  only when i comment the following line, the program compiles fine:
>  #####cp -p *.py* %{buildroot}%{_datadir}/%{name}
>  _______________________________________________
>  devel mailing list -- devel(a)lists.fedoraproject.org
>  To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
>   
It seems that rpm bytecompiles arteconcert.py with python2, and having a default argument
(html=False) after *args is not allowed in python2.

What happens if you try to build it in rawhide?

-- 
Regards,

Charalampos Stratakis
Software Engineer
Python Maintenance Team, Red Hat

[Tim Landscheidt]

"Martin Gansser" <martin.gansser(a)gmail.com&gt; wrote:

>  when compiling qarte-4.4.0 with this spec file
>  https://martinkg.fedorapeople.org/Packages/test/qarte.spec 
>   '[' noarch = noarch ']'
>  + case "${QA_CHECK_RPATHS:-}" in
>  + /usr/lib/rpm/check-buildroot
>  + /usr/lib/rpm/brp-compress
>  + /usr/lib/rpm/brp-strip-static-archive /usr/bin/strip
>  + /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1
>  Compiling
> /home/martin/rpmbuild/BUILDROOT/qarte-4.0.0-1.fc27.x86_64/usr/share/qarte/arteconcert.py
> ...
>    File "/usr/share/qarte/arteconcert.py", line 385
>      def update_pitch(self, *args, html=False):
>                                       ^
>  SyntaxError: invalid syntax 
>  error: Bad exit status from /var/tmp/rpm-tmp.rp9wQD (%install)
>  only when i comment the following line, the program compiles fine:
>  #####cp -p *.py* %{buildroot}%{_datadir}/%{name} 
To state the obvious: arteconcert.py is Python 3,
brp-python-bytecompile uses /usr/bin/python (which is most
likely Python 2):

| [tim@passepartout ~]$ python2 -m py_compile ~/RPMS/BUILD/qarte-4.0.0/arteconcert.py
|   File "/home/tim/RPMS/BUILD/qarte-4.0.0/arteconcert.py", line 385
|     def update_pitch(self, *args, html=False):
|                                      ^
| SyntaxError: invalid syntax

| [tim@passepartout ~]$ python3 -m py_compile ~/RPMS/BUILD/qarte-4.0.0/arteconcert.py
| [tim@passepartout ~]$

Following the advice from
https://fedoraproject.org/wiki/Packaging:Python_Appendix#Manual_byte_comp...,
prepending:

| %global __python %{__python3}

to your qarte.spec works, but there may be cleaner solu-
tions.

Tim

[Kevin Kofler]

Try this:

BuildRequires:  python3-devel
# bytecompile with Python 3
%global __python %{__python3}

in your specfile to force it to bytecompile your Python code with Python 3.

        Kevin Kofler

[Martin Gansser]

>  Try this:
>  
>  BuildRequires:  python3-devel
>  # bytecompile with Python 3
>  %global __python %{__python3}
>  
>  in your specfile to force it to bytecompile your Python code with Python 3.
>  
>          Kevin Kofler 
Thanks for your feedback and solution, compiles/works fine now.
Martin