Mock: cmake having trouble finding libclaw

[Martin Gansser]

Hi,

I'm trying to package the program asgp for fedora, it compiles fine, but the mock
build fails with the following error messages:
bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1176273

+ /usr/bin/cmake -DCMAKE_C_FLAGS_RELEASE:STRING=-DNDEBUG
-DCMAKE_CXX_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_Fortran_FLAGS_RELEASE:STRING=-DNDEBUG
-DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DCMAKE_INSTALL_PREFIX:PATH=/usr
-DINCLUDE_INSTALL_DIR:PATH=/usr/include -DLIB_INSTALL_DIR:PATH=/usr/lib64
-DSYSCONF_INSTALL_DIR:PATH=/etc -DSHARE_INSTALL_PREFIX:PATH=/usr/share -DLIB_SUFFIX=64
-DBUILD_SHARED_LIBS:BOOL=ON -DBEAR_ENGINE_INSTALL_LIBRARY_DIR=lib64/bear
-DBEAR_EDITORS_ENABLED=OFF -DRP_INSTALL_CUSTOM_LIBRARY_DIR=lib64/bear
-DBEAR_ROOT_DIRECTORY=/usr/include/bear -DRP_INSTALL_DATA_DIR=share/asgp
-DCMAKE_BUILD_TYPE=release -DRP_BEAR_FACTORY_ENABLED=ON
-- The C compiler identification is GNU 6.3.1
-- The CXX compiler identification is GNU 6.3.1
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE  
-- Found SDL2: /usr/lib64/libSDL2.so;-lpthread  
-- Could NOT find JPEG (missing:  JPEG_LIBRARY JPEG_INCLUDE_DIR) 
-- Found ZLIB: /usr/lib64/libz.so (found version "1.2.8") 
-- Found PNG: /usr/lib64/libpng.so (found version "1.6.26") 
-- Boost version: 1.60.0
-- Boost version: 1.60.0
CMake Error at /usr/share/cmake/libclaw/libclaw-config.cmake:377 (MESSAGE):
  Could not find Claw library
Call Stack (most recent call first):
  asgp/CMakeLists.txt:75 (find_package)


-- Configuring incomplete, errors occurred!
See also
"/builddir/build/BUILD/asgp-90d6d90e3196d387dc58f028a04e75af2281e513/CMakeFiles/CMakeOutput.log".
See also
"/builddir/build/BUILD/asgp-90d6d90e3196d387dc58f028a04e75af2281e513/CMakeFiles/CMakeError.log".
Fehler: Fehler-Status beim Beenden von /var/tmp/rpm-tmp.4xv4r5 (%build)
    Fehler-Status beim Beenden von /var/tmp/rpm-tmp.4xv4r5 (%build)

Fehler beim Bauen des RPM:
ERROR: Exception(../SRPMS/asgp-1.0.18-3.fc25.src.rpm) Config(fedora-rawhide-x86_64) 5
minutes 8 seconds
INFO: Results and/or logs in: /tmp/mock
INFO: Cleaning up build root ('cleanup_on_failure=True')
Start: clean chroot
Finish: clean chroot
ERROR: Command failed. See logs for output.
 # bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps
/builddir/build/SPECS/asgp.spec

error logs:
https://martinkg.fedorapeople.org/ErrorReports/asgp/CMakeError.log
https://martinkg.fedorapeople.org/ErrorReports/asgp/CMakeOutput.log

any suggestions ?

Thanks Martin

[Benjamin Kircher]

Hi Martin!


On Thu, Dec 29, 2016 at 9:14 AM, Martin Gansser <martinkg(a)fedoraproject.org&gt;
wrote:

>  I'm trying to package the program asgp for fedora, it compiles
> fine, but
>  the mock build fails with the following error messages:
>  bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1176273
>
>  + /usr/bin/cmake -DCMAKE_C_FLAGS_RELEASE:STRING=-DNDEBUG
>  -DCMAKE_CXX_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_Fortran_FLAGS_RELEASE:STRING=-DNDEBUG
>  -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DCMAKE_INSTALL_PREFIX:PATH=/usr
>  -DINCLUDE_INSTALL_DIR:PATH=/usr/include -DLIB_INSTALL_DIR:PATH=/usr/lib64
>  -DSYSCONF_INSTALL_DIR:PATH=/etc -DSHARE_INSTALL_PREFIX:PATH=/usr/share
>  -DLIB_SUFFIX=64 -DBUILD_SHARED_LIBS:BOOL=ON -DBEAR_ENGINE_INSTALL_LIBRARY_DIR=lib64/bear
>  -DBEAR_EDITORS_ENABLED=OFF -DRP_INSTALL_CUSTOM_LIBRARY_DIR=lib64/bear
>  -DBEAR_ROOT_DIRECTORY=/usr/include/bear -DRP_INSTALL_DATA_DIR=share/asgp
>  -DCMAKE_BUILD_TYPE=release -DRP_BEAR_FACTORY_ENABLED=ON
>  -- The C compiler identification is GNU 6.3.1
>  -- The CXX compiler identification is GNU 6.3.1
>  -- Check for working C compiler: /usr/bin/cc
>  -- Check for working C compiler: /usr/bin/cc -- works
>  -- Detecting C compiler ABI info
>  -- Detecting C compiler ABI info - done
>  -- Detecting C compile features
>  -- Detecting C compile features - done
>  -- Check for working CXX compiler: /usr/bin/c++
>  -- Check for working CXX compiler: /usr/bin/c++ -- works
>  -- Detecting CXX compiler ABI info
>  -- Detecting CXX compiler ABI info - done
>  -- Detecting CXX compile features
>  -- Detecting CXX compile features - done
>  -- Looking for pthread.h
>  -- Looking for pthread.h - found
>  -- Looking for pthread_create
>  -- Looking for pthread_create - not found
>  -- Looking for pthread_create in pthreads
>  -- Looking for pthread_create in pthreads - not found
>  -- Looking for pthread_create in pthread
>  -- Looking for pthread_create in pthread - found
>  -- Found Threads: TRUE
>  -- Found SDL2: /usr/lib64/libSDL2.so;-lpthread
>  -- Could NOT find JPEG (missing:  JPEG_LIBRARY JPEG_INCLUDE_DIR)
>  -- Found ZLIB: /usr/lib64/libz.so (found version "1.2.8")
>  -- Found PNG: /usr/lib64/libpng.so (found version "1.6.26")
>  -- Boost version: 1.60.0
>  -- Boost version: 1.60.0
>  CMake Error at /usr/share/cmake/libclaw/libclaw-config.cmake:377
>  (MESSAGE):
>    Could not find Claw library
>  Call Stack (most recent call first):
>    asgp/CMakeLists.txt:75 (find_package)
>  
Please correct me if I am wrong but `/usr/share/cmake/libclaw` does look
like a very strange path for a package to put its CMake modules, no?

$ dnf provides /usr/share/cmake/libclaw/libclaw-config.cmake
<snip>
libclaw-devel-1.7.4-13.fc24.x86_64 : Development files for Claw library
Repo        : @System

libclaw-devel-1.7.4-13.fc24.i686 : Development files for Claw library
Repo        : fedora

libclaw-devel-1.7.4-13.fc24.x86_64 : Development files for Claw library
Repo        : fedora


But this may be totally unrelated to your problem at hand.



>  -- Configuring incomplete, errors occurred!
>  See also "/builddir/build/BUILD/asgp-90d6d90e3196d387dc58f028a04e75af
>  2281e513/CMakeFiles/CMakeOutput.log".
>  See also "/builddir/build/BUILD/asgp-90d6d90e3196d387dc58f028a04e75af
>  2281e513/CMakeFiles/CMakeError.log".
>  Fehler: Fehler-Status beim Beenden von /var/tmp/rpm-tmp.4xv4r5 (%build)
>      Fehler-Status beim Beenden von /var/tmp/rpm-tmp.4xv4r5 (%build)
>
>  Fehler beim Bauen des RPM:
>  ERROR: Exception(../SRPMS/asgp-1.0.18-3.fc25.src.rpm)
>  Config(fedora-rawhide-x86_64) 5 minutes 8 seconds
>  INFO: Results and/or logs in: /tmp/mock
>  INFO: Cleaning up build root ('cleanup_on_failure=True')
>  Start: clean chroot
>  Finish: clean chroot
>  ERROR: Command failed. See logs for output.
>   # bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps
>  /builddir/build/SPECS/asgp.spec
>
>  error logs:
>  https://martinkg.fedorapeople.org/ErrorReports/asgp/CMakeError.log
>  https://martinkg.fedorapeople.org/ErrorReports/asgp/CMakeOutput.log
>
>  any suggestions ?
>  

Just a wild guess, but does it any help if you remove the explicit
requested version in asgp/CMakeLists.txt:75? Maybe there is no libclaw
1.7.4 in the mock build environment?


BK

[Martin Gansser]

>  Hi Martin!
>  
>  
>  Just a wild guess, but does it any help if you remove the explicit
>  requested version in asgp/CMakeLists.txt:75? Maybe there is no libclaw
>  1.7.4 in the mock build environment?
>  
>  
>  BK 
removed the requested version in CMakeLists.txt
sed -i 's|find_package( libclaw 1.7.4 )|find_package( libclaw )|'
asgp/CMakeLists.txt

but the same error:
CMake Error at /usr/share/cmake/libclaw/libclaw-config.cmake:377 (MESSAGE):
  Could not find Claw library
Call Stack (most recent call first):
  asgp/CMakeLists.txt:75 (find_package)

[Michael Schwendt]

It may be necessary to debug the cmake libclaw detection script.

claw-config is broken, btw, and it's likely that this has not been
caught during review:

  $ claw-config --libs
  -L/usr/lib 
  $ claw-config application --libs 
  -L/usr/lib -lclaw_application -lclaw_logger
  $ claw-config dynamic_library --libs
  -L/usr/lib -lclaw_dynamic_library -ldl

Wrong on x86_64.
And odd to relink with libdl as libclaw_dynamic_library is linked with
libdl already.


 $ claw-config all --libs 
-L/usr/lib -lclaw_application -lclaw_logger -lclaw_dynamic_library -ldl
-lclaw_configuration_file -lclaw_graphic -lpng -lz -ljpeg -lclaw_logger
-lclaw_net -lclaw_tween

Is relinking with all those non-libclaw libs necessary? It seems they are
for linking statically only.


  $ claw-config --cflags
  -I/usr/include/ -DCLAW_JPEG_SUPPORT -DCLAW_PNG_SUPPORT

This -I parameter is not only superfluous (because /usr/include is
standard search path), but may also be harmful, since it alters the
search order.

Further packaging issues:

  $ rpmls libclaw|grep claw1
  drwxr-xr-x  /usr/share/doc/libclaw1
  -rw-r--r--  /usr/share/doc/libclaw1/COPYING

Why "libclaw1" and not %name?
No %license usage.

[Orion Poplawski]

On 12/29/2016 11:23 AM, Michael Schwendt wrote:
>  It may be necessary to debug the cmake libclaw detection script.
>  
>  claw-config is broken, btw, and it's likely that this has not been
>  caught during review:
>  
>    $ claw-config --libs
>    -L/usr/lib 
>    $ claw-config application --libs 
>    -L/usr/lib -lclaw_application -lclaw_logger
>    $ claw-config dynamic_library --libs
>    -L/usr/lib -lclaw_dynamic_library -ldl
>  
>  Wrong on x86_64.
>  And odd to relink with libdl as libclaw_dynamic_library is linked with
>  libdl already.
>  
>  
>   $ claw-config all --libs 
>  -L/usr/lib -lclaw_application -lclaw_logger -lclaw_dynamic_library -ldl
>  -lclaw_configuration_file -lclaw_graphic -lpng -lz -ljpeg -lclaw_logger
>  -lclaw_net -lclaw_tween
>  
>  Is relinking with all those non-libclaw libs necessary? It seems they are
>  for linking statically only.
>  
>  
>    $ claw-config --cflags
>    -I/usr/include/ -DCLAW_JPEG_SUPPORT -DCLAW_PNG_SUPPORT
>  
>  This -I parameter is not only superfluous (because /usr/include is
>  standard search path), but may also be harmful, since it alters the
>  search order.
>  
>  Further packaging issues:
>  
>    $ rpmls libclaw|grep claw1
>    drwxr-xr-x  /usr/share/doc/libclaw1
>    -rw-r--r--  /usr/share/doc/libclaw1/COPYING
>  
>  Why "libclaw1" and not %name?
>  No %license usage.
>  _______________________________________________
>  devel mailing list -- devel(a)lists.fedoraproject.org
>  To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
>   
I've hopefully fixed most of these issues including the initial cmake issue
with this build:

* Thu Dec 29 2016 Orion Poplawski <orion(a)cora.nwra.com&gt; - 1.7.4-16
- Install cmake files in arch specific dirs
- Put documentation into separate noarch sub-package
- Require needed devel packages in -devel sub-package
- Use %license

https://koji.fedoraproject.org/koji/taskinfo?taskID=17109344

I did not address the various -l library output of claw-config or
-I/usr/include, nor the "libclaw1" name.

Initial issue was caused by the claw cmake file refusing to "find" libclaw if
any of the dependent packages (libjpeg/libpng/boost) were not found.
libclaw-devel now requires them.

-- 
Orion Poplawski
Technical Manager                          720-772-5637
NWRA, Boulder/CoRA Office             FAX: [phone]
3380 Mitchell Lane                       orion(a)nwra.com
Boulder, CO 80301                   http://www.nwra.com

[Martin Gansser]

Thanks to Michael for his investigation.

Thanks to Orion for your support,
could you please commit a package for f24/f25 also ?

Thanks Martin

[Michael Schwendt]

On Thu, 29 Dec 2016 17:11:10 -0700, Orion Poplawski wrote:

>  >  $ claw-config all --libs 
>  > -L/usr/lib -lclaw_application -lclaw_logger -lclaw_dynamic_library -ldl
>  > -lclaw_configuration_file -lclaw_graphic -lpng -lz -ljpeg -lclaw_logger
>  > -lclaw_net -lclaw_tween
>  > 
>  > Is relinking with all those non-libclaw libs necessary? It seems they are
>  > for linking statically only. 
>  https://koji.fedoraproject.org/koji/taskinfo?taskID=17109344
>  
>  I did not address the various -l library output of claw-config or
>  -I/usr/include, nor the "libclaw1" name.
>  
>  Initial issue was caused by the claw cmake file refusing to "find" libclaw if
>  any of the dependent packages (libjpeg/libpng/boost) were not found.
>  libclaw-devel now requires them. 
Eventually, this ought to get fixed however, because relinking with shared
libs causes the same dependency bloat (and requires unnecessary rebuilds)
as if using libtool .la files, for example.