F40 Change Proposal: Change Firefox Desktop File (System-Wide)

[Aoife Moloney]

Wiki -> https://fedoraproject.org/wiki/Changes/RenameFirefoxDesktopFile

This is a proposed Change for Fedora Linux.
This document represents a proposed Change. As part of the Changes
process, proposals are publicly announced in order to receive
community feedback. This proposal will only be implemented if approved
by the Fedora Engineering Steering Committee.

== Summary ==
Recent Firefox desktop file (firefox.desktop) does not comply with
DBus/Gnome search provider rules thus Firefox can't provide DBus Gnome
search service.

We should change Firefox desktop file from firefox.desktop to
org.mozilla.firefox.desktop.

== Owner ==
* Name: [[User:stransky| Martin Stransky]]
* Email:

== Detailed Description ==
Firefox needs to provide desktop file in expected format to pair DBus
service and Gnome search service together to make Gnome search service
work.

== Feedback ==

== Benefit to Fedora ==

We'll fix already broken feature.

== Scope ==
* Proposal owners:

Desktop file name is changed in Firefox 121.0.

* Other developers:

Fedora Workstation needs update Firefox desktop name (hardcoded in
gnome-shell) to correctly place Firefox to Gnome taskbar as default
application.

* Release engineering: [https://pagure.io/releng/issues #Releng issue number]

No need to coordinate with rel-eng.

* Policies and guidelines: N/A (not needed for this Change)

* Trademark approval: N/A (not needed for this Change)

* Alignment with Community Initiatives:

== Upgrade/compatibility impact ==

Should not impact.

== How To Test ==

1) Open Firefox
2) Type something to Gnome search
3) It works

Test also KDE/Plasma it doesn't crash
(https://bugzilla.redhat.com/show_bug.cgi?id=2017123)

== User Experience ==

Enabled Gnome shell search provider for Firefox.

== Dependencies ==

None

== Contingency Plan ==

* Revert desktop file name change in Firefox package.
* Blocks release? No

== Documentation ==

== Release Notes ==

[Kai A. Hiller]

Shouldn’t the ID be `org.mozilla.Firefox`, i.e., with an upper-case 
spelling of Firefox? The D-Bus specification recommends (“It is 
conventional […]”) CamelCase spelling after the reverse DNS part of the 
interface name:

https://dbus.freedesktop.org/doc/dbus-specification.html#message-protocol-na...

On 2023-12-20 20:43, Aoife Moloney wrote:
> Wiki -> https://fedoraproject.org/wiki/Changes/RenameFirefoxDesktopFile
>
> This is a proposed Change for Fedora Linux.
> This document represents a proposed Change. As part of the Changes
> process, proposals are publicly announced in order to receive
> community feedback. This proposal will only be implemented if approved
> by the Fedora Engineering Steering Committee.
>
> == Summary ==
> Recent Firefox desktop file (firefox.desktop) does not comply with
> DBus/Gnome search provider rules thus Firefox can't provide DBus Gnome
> search service.
>
> We should change Firefox desktop file from firefox.desktop to
> org.mozilla.firefox.desktop.
>
> == Owner ==
> Name: [[User:stransky| Martin Stransky]]
> Email:
>
> == Detailed Description ==
> Firefox needs to provide desktop file in expected format to pair DBus
> service and Gnome search service together to make Gnome search service
> work.
>
> == Feedback ==
>
> == Benefit to Fedora ==
>
> We'll fix already broken feature.
>
> == Scope ==
> Proposal owners:
>
> Desktop file name is changed in Firefox 121.0.
> Other developers:
>
> Fedora Workstation needs update Firefox desktop name (hardcoded in
> gnome-shell) to correctly place Firefox to Gnome taskbar as default
> application.
> Release engineering: [https://pagure.io/releng/issues #Releng issue number]
>
> No need to coordinate with rel-eng.
>
> Policies and guidelines: N/A (not needed for this Change)
>
> Trademark approval: N/A (not needed for this Change)
>
> Alignment with Community Initiatives:
>
> == Upgrade/compatibility impact ==
>
> Should not impact.
>
> == How To Test ==
> Open Firefox
> Type something to Gnome search
> It works
>
> Test also KDE/Plasma it doesn't crash
> (https://bugzilla.redhat.com/show_bug.cgi?id=2017123)
>
> == User Experience ==
>
> Enabled Gnome shell search provider for Firefox.
>
> == Dependencies ==
>
> None
>
> == Contingency Plan ==
> Revert desktop file name change in Firefox package.
> Blocks release? No
>
> == Documentation ==
>
> == Release Notes ==

[Yaakov Selkowitz]

On Sun, 2024-01-21 at 17:07 +0100, Kai A. Hiller wrote:
> Shouldn’t the ID be `org.mozilla.Firefox`, i.e., with an upper-case 
> spelling of Firefox? The D-Bus specification recommends (“It is 
> conventional […]”) CamelCase spelling after the reverse DNS part of
> the 
> interface name:
>
> https://dbus.freedesktop.org/doc/dbus-specification.html#message-protocol-na...

Flathub uses org.mozilla.firefox though:

https://flathub.org/apps/org.mozilla.firefox

And the Appstream spec discourages capital letters in the ID:

https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-i...

IIUC it is the mismatch of IDs between RPMs and flatpaks that causes
the same application to be listed multiple times in GNOME Software
and/or KDE Discover, and at some point it would be good to make it a
goal to fix that.
> On 2023-12-20 20:43, Aoife Moloney wrote:
> > Wiki ->
> > https://fedoraproject.org/wiki/Changes/RenameFirefoxDesktopFile
> >
> > This is a proposed Change for Fedora Linux.
> > This document represents a proposed Change. As part of the Changes
> > process, proposals are publicly announced in order to receive
> > community feedback. This proposal will only be implemented if
> > approved
> > by the Fedora Engineering Steering Committee.
> >
> > == Summary ==
> > Recent Firefox desktop file (firefox.desktop) does not comply with
> > DBus/Gnome search provider rules thus Firefox can't provide DBus
> > Gnome
> > search service.
> >
> > We should change Firefox desktop file from firefox.desktop to
> > org.mozilla.firefox.desktop.
> >
> > == Owner ==
> > Name: [[User:stransky| Martin Stransky]]
> > Email:
> >
> > == Detailed Description ==
> > Firefox needs to provide desktop file in expected format to pair
> > DBus
> > service and Gnome search service together to make Gnome search
> > service
> > work.
> >
> > == Feedback ==
> >
> > == Benefit to Fedora ==
> >
> > We'll fix already broken feature.
> >
> > == Scope ==
> > Proposal owners:
> >
> > Desktop file name is changed in Firefox 121.0.
> > Other developers:
> >
> > Fedora Workstation needs update Firefox desktop name (hardcoded in
> > gnome-shell) to correctly place Firefox to Gnome taskbar as default
> > application.
> > Release engineering: [https://pagure.io/releng/issues%C2%A0#Releng
> >
> > issue number]
> >
> > No need to coordinate with rel-eng.
> >
> > Policies and guidelines: N/A (not needed for this Change)
> >
> > Trademark approval: N/A (not needed for this Change)
> >
> > Alignment with Community Initiatives:
> >
> > == Upgrade/compatibility impact ==
> >
> > Should not impact.
> >
> > == How To Test ==
> > Open Firefox
> > Type something to Gnome search
> > It works
> >
> > Test also KDE/Plasma it doesn't crash
> > (https://bugzilla.redhat.com/show_bug.cgi?id=2017123)
> >
> > == User Experience ==
> >
> > Enabled Gnome shell search provider for Firefox.
> >
> > == Dependencies ==
> >
> > None
> >
> > == Contingency Plan ==
> > Revert desktop file name change in Firefox package.
> > Blocks release? No
> >
> > == Documentation ==
> >
> > == Release Notes ==
>
> --
> _______________________________________________
> devel mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines:
> https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]
> Do not reply to spam, report it:
> https://pagure.io/fedora-infrastructure/new_issue