Coin4 build failure

[Richard Shaw]

While trying to update the spec for the CMake change I ran into this for
the first time:

cd /builddir/build/BUILD/coin-6enkw/x86_64-redhat-linux-gnu/src/base &&
/usr/bin/g++
 -I/builddir/build/BUILD/coin-6enkw/x86_64-redhat-linux-gnu/data
-I/builddir/build/BUILD/coin-6enkw/include/Inventor/annex
-I/builddir/build/BUILD/coin-6enkw/src
-I/builddir/build/BUILD/coin-6enkw/x86_64-redhat-linux-gnu/src
-I/builddir/build/BUILD/coin-6enkw/include
-I/builddir/build/BUILD/coin-6enkw/x86_64-redhat-linux-gnu/include -O2
-flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe
-Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
-Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
-fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1
 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection
-fcf-protection -DNDEBUG -fPIC -DHAVE_CONFIG_H -DCOIN_INTERNAL
-DCOIN_DEBUG=0 -o CMakeFiles/base.dir/dict.cpp.o -c
/builddir/build/BUILD/coin-6enkw/src/base/dict.cpp
/builddir/build/BUILD/coin-6enkw/src/xml/expat/xmlparse.c:94:3: error:
#error You do not have support for any sources of high quality entropy
enabled. For end user security, that is probably not what you want. Your
options include: * Linux + glibc >=2.25 (getrandom): HAVE_GETRANDOM, *
Linux + glibc <2.25 (syscall SYS_getrandom): HAVE_SYSCALL_GETRANDOM, * BSD
/ macOS >=10.7 (arc4random_buf): HAVE_ARC4RANDOM_BUF, * BSD / macOS <10.7
(arc4random): HAVE_ARC4RANDOM, * libbsd (arc4random_buf):
HAVE_ARC4RANDOM_BUF + HAVE_LIBBSD, * libbsd (arc4random): HAVE_ARC4RANDOM +
HAVE_LIBBSD, * Linux / BSD / macOS (/dev/urandom): XML_DEV_URANDOM *
Windows (RtlGenRandom): _WIN32. If insist on not using any of these, bypass
this error by defining XML_POOR_ENTROPY; you have been warned. If you have
reasons to patch this detection code away or need changes to the build
system, please open a bug. Thank you!
   94 | # error  \
      |   ^~~~~

Thoughts?

Thanks,
Richard

[J. Scheurich]

On 07.08.20 02:58, Richard Shaw wrote:
>  While trying to update the spec for the CMake change I ran into this
>  for the first time:
>
>  cd /builddir/build/BUILD/coin-6enkw/x86_64-redhat-linux-gnu/src/base
>  && /usr/bin/g++
>   -I/builddir/build/BUILD/coin-6enkw/x86_64-redhat-linux-gnu/data
>  -I/builddir/build/BUILD/coin-6enkw/include/Inventor/annex
>  -I/builddir/build/BUILD/coin-6enkw/src
>  -I/builddir/build/BUILD/coin-6enkw/x86_64-redhat-linux-gnu/src
>  -I/builddir/build/BUILD/coin-6enkw/include
>  -I/builddir/build/BUILD/coin-6enkw/x86_64-redhat-linux-gnu/include -O2
>  -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches
>  -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
>  -Wp,-D_GLIBCXX_ASSERTIONS
>  -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
>  -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1
>   -m64 -mtune=generic -fasynchronous-unwind-tables
>  -fstack-clash-protection -fcf-protection -DNDEBUG -fPIC
>  -DHAVE_CONFIG_H -DCOIN_INTERNAL -DCOIN_DEBUG=0 -o
>  CMakeFiles/base.dir/dict.cpp.o -c
>  /builddir/build/BUILD/coin-6enkw/src/base/dict.cpp
>  /builddir/build/BUILD/coin-6enkw/src/xml/expat/xmlparse.c:94:3: error:
>  #error You do not have support for any sources of high quality entropy
>  enabled. For end user security, that is probably not what you want.
>  Your options include: * Linux + glibc >=2.25 (getrandom):
>  HAVE_GETRANDOM, * Linux + glibc <2.25 (syscall SYS_getrandom):
>  HAVE_SYSCALL_GETRANDOM, * BSD / macOS >=10.7 (arc4random_buf):
>  HAVE_ARC4RANDOM_BUF, * BSD / macOS <10.7 (arc4random):
>  HAVE_ARC4RANDOM, * libbsd (arc4random_buf): HAVE_ARC4RANDOM_BUF +
>  HAVE_LIBBSD, * libbsd (arc4random): HAVE_ARC4RANDOM + HAVE_LIBBSD, *
>  Linux / BSD / macOS (/dev/urandom): XML_DEV_URANDOM * Windows
>  (RtlGenRandom): _WIN32. If insist on not using any of these, bypass
>  this error by defining XML_POOR_ENTROPY; you have been warned. If you
>  have reasons to patch this detection code away or need changes to the
>  build system, please open a bug. Thank you!
>     94 | # error  \
>        |   ^~~~~
>
>  Thoughts?
>  
A longer pat of the source would be help, cause #error is commonly used
to describe a problem
detected by the compiler during complie time like here:


https://docs.microsoft.com/en-us/cpp/preprocessor/hash-error-directive-c-...

|#if !defined(__cplusplus) #error C++ compiler required. #endif |

Not  recommended, but often seen....

The error text in this case is

You do not have support for any sources of high quality entropy enabled.
For end user security, that is probably not what you want. Your options
include: * Linux + glibc >=2.25 (getrandom): HAVE_GETRANDOM, * Linux +
glibc <2.25 (syscall SYS_getrandom): HAVE_SYSCALL_GETRANDOM, * BSD /
macOS >=10.7 (arc4random_buf): HAVE_ARC4RANDOM_BUF, * BSD / macOS <10.7
(arc4random): HAVE_ARC4RANDOM, * libbsd (arc4random_buf):

If insist on not using any of these, bypass this error by defining
XML_POOR_ENTROPY; you have been warned. If you have reasons to patch
this detection code away or need changes to the build system, please
open a bug. Thank you!

You can bypass this by using

CXXFLGS="-DXML_POOR_ENTROPY=1"


but you should reinspect the osusres to use a better random seed.

so long
MUFTI

[J. Scheurich]

>  You can bypass this by using
>
>  CXXFLGS="-DXML_POOR_ENTROPY=1"
>  
export CXXFLAGS="-DXML_POOR_ENTROPY=1"

in bash before compiling

sorry...

so long
MUFTO

[Björn Persson]

>  You do not have support for any sources of high quality entropy
>  enabled. For end user security, that is probably not what you want. Your
>  options include: * Linux + glibc >=2.25 (getrandom): HAVE_GETRANDOM, *
>  Linux + glibc <2.25 (syscall SYS_getrandom): HAVE_SYSCALL_GETRANDOM, * BSD
>  / macOS >=10.7 (arc4random_buf): HAVE_ARC4RANDOM_BUF, * BSD / macOS <10.7
>  (arc4random): HAVE_ARC4RANDOM, * libbsd (arc4random_buf):
>  HAVE_ARC4RANDOM_BUF + HAVE_LIBBSD, * libbsd (arc4random): HAVE_ARC4RANDOM +
>  HAVE_LIBBSD, * Linux / BSD / macOS (/dev/urandom): XML_DEV_URANDOM *
>  Windows (RtlGenRandom): _WIN32. If insist on not using any of these,
>  bypass this error by defining XML_POOR_ENTROPY; you have been warned.
>  If you have reasons to patch this detection code away or need changes
>  to the build system, please open a bug. Thank you! 
My interpretation is that they want you to choose a source of
randomness by defining one of those macros, so can you get the build
system to pass -DXML_DEV_URANDOM to g++?

Björn Persson

[Richard Shaw]

So I was curious what the error was, but my bigger question is, what
changed?

This was just a rebuild for the CMake change FTBFS. I have not changed
anything other than what was necessary to fix the CMake commands.

Thanks,
Richard

[J. Scheurich]

About a question related to #error...

On 8/7/20 2:12 PM, Richard Shaw wrote:
>  So I was curious what the error was, but my bigger question is, what
>  changed?
>
>  This was just a rebuild for the CMake change FTBFS. I have not changed
>  anything other than what was necessary to fix the CMake commands.
>  
Maybe the source maintainers improooved securitiy related things ?

so long
MUFTI

[Richard Shaw]

On Fri, Aug 7, 2020 at 7:21 AM J. Scheurich <mufti11(a)web.de&gt; wrote:

>  About a question related to #error...
>
>  On 8/7/20 2:12 PM, Richard Shaw wrote:
>  > So I was curious what the error was, but my bigger question is, what
>  > changed?
>  >
>  > This was just a rebuild for the CMake change FTBFS. I have not changed
>  > anything other than what was necessary to fix the CMake commands.
>
>  Maybe the source maintainers improooved securitiy related things ?
>  
Coin4 upstream? I haven't changed anything to do with the source.

Thanks,
Richard

[Zbigniew Jędrzejewski-Szmek]

On Thu, Aug 06, 2020 at 07:58:10PM -0500, Richard Shaw wrote:
>  /builddir/build/BUILD/coin-6enkw/src/xml/expat/xmlparse.c:94:3:
> error:
>  #error You do not have support for any sources of high quality entropy
>  enabled. For end user security, that is probably not what you want. 
>  Your options include:
>  * Linux + glibc >=2.25 (getrandom): HAVE_GETRANDOM
>  * Linux + glibc <2.25 (syscall SYS_getrandom): HAVE_SYSCALL_GETRANDOM
>  * BSD / macOS >=10.7 (arc4random_buf): HAVE_ARC4RANDOM_BUF 
...

The first one is the one you want. So the question is how to get the
compilation script to detect that. Maybe just -DHAVE_GETRANDOM will work?

Zbyszek

[Richard Shaw]

On Fri, Aug 7, 2020 at 7:27 AM Zbigniew Jędrzejewski-Szmek <
zbyszek(a)in.waw.pl&gt; wrote:

>  On Thu, Aug 06, 2020 at 07:58:10PM -0500, Richard Shaw wrote:
>  > /builddir/build/BUILD/coin-6enkw/src/xml/expat/xmlparse.c:94:3: error:
>  > #error You do not have support for any sources of high quality entropy
>  > enabled. For end user security, that is probably not what you want.
>
>  > Your options include:
>  > * Linux + glibc >=2.25 (getrandom): HAVE_GETRANDOM
>  > * Linux + glibc <2.25 (syscall SYS_getrandom): HAVE_SYSCALL_GETRANDOM
>  > * BSD / macOS >=10.7 (arc4random_buf): HAVE_ARC4RANDOM_BUF
>  ...
>
>  The first one is the one you want. So the question is how to get the
>  compilation script to detect that. Maybe just -DHAVE_GETRANDOM will work?
>  
Nope, but I think I got it fixed. Cmake was complaining that it couldn't
find expat, which I don't remember seeing before so I added it. Now the
build completes.

Something must have changed in Rawhide at some point, no clue what, but
it's "fixed".

Thanks everyone!

Richard