iccjpeg.h errors

[Antonio Trande]

Hi all.

I don't know how to fix these errors during IceCat compilation. Lately I
tried to adapt Fedora compilations flags but there is wrong something.

Here the log:
http://koji.fedoraproject.org/koji/getfile?taskID=8044663&name=build....

This is SPEC file that I'm using,
https://sagitter.fedorapeople.org/Icecat/icecat.spec

-- 
Antonio Trande

mailto: sagitter 'at' fedoraproject 'dot' org
http://fedoraos.wordpress.com/
https://fedoraproject.org/wiki/User:Sagitter
GPG Key: 0x66E15D00
Check on https://keys.fedoraproject.org/

[Dan Williams]

On Wed, 2014-11-05 at 18:17 +0100, Antonio Trande wrote:
>  Hi all.
>  
>  I don't know how to fix these errors during IceCat compilation. Lately I
>  tried to adapt Fedora compilations flags but there is wrong something.
>  
>  Here the log:
>
> http://koji.fedoraproject.org/koji/getfile?taskID=8044663&name=build....
Where are JPP, JOCTET, and FAR defined?  Is that header included in the
file that is causing errors?

Dan

>  This is SPEC file that I'm using,
>  https://sagitter.fedorapeople.org/Icecat/icecat.spec
>  
>  -- 
>  Antonio Trande
>  
>  mailto: sagitter 'at' fedoraproject 'dot' org
>  http://fedoraos.wordpress.com/
>  https://fedoraproject.org/wiki/User:Sagitter
>  GPG Key: 0x66E15D00
>  Check on https://keys.fedoraproject.org/

[Antonio Trande]

Hi Dan.

On 11/05/2014 06:44 PM, Dan Williams wrote:
>  On Wed, 2014-11-05 at 18:17 +0100, Antonio Trande wrote:
> > Hi all.
> >
> > I don't know how to fix these errors during IceCat compilation. Lately I
> > tried to adapt Fedora compilations flags but there is wrong something.
> >
> > Here the log:
> >
> http://koji.fedoraproject.org/koji/getfile?taskID=8044663&name=build....
>  
>  Where are JPP, JOCTET, and FAR defined?  Is that header included in the
>  file that is causing errors?
>  
>  Dan
>   
I suppose you need to read image/decoders/iccjpeg.h involved:
http://ur1.ca/ipcjo


-- 
Antonio Trande

mailto: sagitter 'at' fedoraproject 'dot' org
http://fedoraos.wordpress.com/
https://fedoraproject.org/wiki/User:Sagitter
GPG Key: 0x66E15D00
Check on https://keys.fedoraproject.org/

[Dan Williams]

On Wed, 2014-11-05 at 18:57 +0100, Antonio Trande wrote:
>  Hi Dan.
>  
>  On 11/05/2014 06:44 PM, Dan Williams wrote:
>  > On Wed, 2014-11-05 at 18:17 +0100, Antonio Trande wrote:
>  >> Hi all.
>  >>
>  >> I don't know how to fix these errors during IceCat compilation. Lately I
>  >> tried to adapt Fedora compilations flags but there is wrong something.
>  >>
>  >> Here the log:
>  >>
> http://koji.fedoraproject.org/koji/getfile?taskID=8044663&name=build....
>  > 
>  > Where are JPP, JOCTET, and FAR defined?  Is that header included in the
>  > file that is causing errors?
>  > 
>  > Dan
>  > 
>  
>  I suppose you need to read image/decoders/iccjpeg.h involved:
>  http://ur1.ca/ipcjo 
Can you get/post the jconfig.h and jmorecfg.h that's getting used?
Those are where the defines in question come from, and perhaps some
options in jconfig.h are different on this build than in past builds.

Dan

[Antonio Trande]

On 11/05/2014 08:29 PM, Dan Williams wrote:
> >>
> >> Where are JPP, JOCTET, and FAR defined?  Is that header included in the
> >> file that is causing errors?
> >>
> >> Dan
> >>
> >
> > I suppose you need to read image/decoders/iccjpeg.h involved:
> > http://ur1.ca/ipcjo
>  
>  Can you get/post the jconfig.h and jmorecfg.h that's getting used?
>  Those are where the defines in question come from, and perhaps some
>  options in jconfig.h are different on this build than in past builds.
>   
Of course.

jconfig.h: http://ur1.ca/ipfqi
jmorecfg.h: http://ur1.ca/ipfrg

-- 
Antonio Trande

mailto: sagitter 'at' fedoraproject 'dot' org
http://fedoraos.wordpress.com/
https://fedoraproject.org/wiki/User:Sagitter
GPG Key: 0x66E15D00
Check on https://keys.fedoraproject.org/

[David Tardon]

Hi,

On Wed, Nov 05, 2014 at 06:17:27PM +0100, Antonio Trande wrote:
>  Hi all.
>  
>  I don't know how to fix these errors during IceCat compilation. Lately I
>  tried to adapt Fedora compilations flags but there is wrong something.
>  
>  Here the log:
>
> http://koji.fedoraproject.org/koji/getfile?taskID=8044663&name=build....
The JPP macro is no longer defined in libjpeg-turbo-devel-1.3.90. You
can either replace all JPP(arglist) uses by arglist, or add

#define JPP(arglist) arglist

at the top of image/decoders/iccjpeg.h.

(By coincidence, I did the same replacement in libreoffice's jpeg filter
just a few hours ago...)

D.

[Antonio Trande]

Hi David.

On 11/06/2014 01:03 PM, David Tardon wrote:
>  Hi,
>  
>  On Wed, Nov 05, 2014 at 06:17:27PM +0100, Antonio Trande wrote:
> > Hi all.
> >
> > I don't know how to fix these errors during IceCat compilation. Lately I
> > tried to adapt Fedora compilations flags but there is wrong something.
> >
> > Here the log:
> >
> http://koji.fedoraproject.org/koji/getfile?taskID=8044663&name=build....
>  
>  The JPP macro is no longer defined in libjpeg-turbo-devel-1.3.90. You
>  can either replace all JPP(arglist) uses by arglist,
>  ...
>  (By coincidence, I did the same replacement in libreoffice's jpeg
>  filter just a few hours ago...) 
Can you show me the patch that you used ?

>  
>  #define JPP(arglist) arglist
>  
>  at the top of image/decoders/iccjpeg.h. 
This fix seems not work.

-- 
Antonio Trande

mailto: sagitter 'at' fedoraproject 'dot' org
http://fedoraos.wordpress.com/
https://fedoraproject.org/wiki/User:Sagitter
GPG Key: 0x66E15D00
Check on https://keys.fedoraproject.org/

[David Tardon]

Hi,

On Thu, Nov 06, 2014 at 06:16:33PM +0100, Antonio Trande wrote:
>  Hi David.
>  
>  On 11/06/2014 01:03 PM, David Tardon wrote:
>  > Hi,
>  > 
>  > On Wed, Nov 05, 2014 at 06:17:27PM +0100, Antonio Trande wrote:
>  >> Hi all.
>  >>
>  >> I don't know how to fix these errors during IceCat compilation. Lately I
>  >> tried to adapt Fedora compilations flags but there is wrong something.
>  >>
>  >> Here the log:
>  >>
> http://koji.fedoraproject.org/koji/getfile?taskID=8044663&name=build....
>  > 
>  > The JPP macro is no longer defined in libjpeg-turbo-devel-1.3.90. You
>  > can either replace all JPP(arglist) uses by arglist,
>  > ...
>  > (By coincidence, I did the same replacement in libreoffice's jpeg
>  > filter just a few hours ago...)
>  
>  Can you show me the patch that you used ? 
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=4d687aec3...

D.

[Rex Dieter]

Antonio Trande wrote:

>  I don't know how to fix these errors during IceCat compilation.
> Lately I
>  tried to adapt Fedora compilations flags but there is wrong something.
>  
>  Here the log:
>  
http://koji.fedoraproject.org/koji/getfile?taskID=8044663&name=build....
>  
>  This is SPEC file that I'm using,
>  https://sagitter.fedorapeople.org/Icecat/icecat.spec
>   
Sorry for late followup, but I filed a bug to track the fallout from this 
incompatible change in libjpeg-turbo,
https://bugzilla.redhat.com/show_bug.cgi?id=1164815

-- Rex