sssd: No %post/%preun/%postun?!?

[Richard Shaw]

Per the packaging guidelines these don't seem to be optional:

https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_sy...

Additionally, at a minimum systemctl daemon-reload should be run. It looks
like there is some sort of default behavior but it's not correct.

Warning: The unit file, source configuration file or drop-ins of
sssd-kcm.socket changed on disk. Run 'systemctl daemon-reload' to reload
units.
Warning: The unit file, source configuration file or drop-ins of
sssd-kcm.service changed on disk. Run 'systemctl daemon-reload' to reload
units.

Even the base sssd service seems to be missing daemon-reload:

Warning: The unit file, source configuration file or drop-ins of
sssd.service changed on disk. Run 'systemctl daemon-reload' to reload units.

For the other services provided the default behavior seems to be of the
try-restart variety but all (most?) of these are indirectly started by
socket activation so should be using %systemd_postun and not
%systemd_postun_with_restart:

Failed to try-restart sssd-autofs.service: Operation refused, unit
sssd-autofs.service may be requested by dependency only (it is configured
to refuse manual start/stop).
See system logs and 'systemctl status sssd-autofs.service' for details.
Failed to try-restart sssd-nss.service: Operation refused, unit
sssd-nss.service may be requested by dependency only (it is configured to
refuse manual start/stop).
See system logs and 'systemctl status sssd-nss.service' for details.
Failed to try-restart sssd-pac.service: Operation refused, unit
sssd-pac.service may be requested by dependency only (it is configured to
refuse manual start/stop).
See system logs and 'systemctl status sssd-pac.service' for details.
Failed to try-restart sssd-pam.service: Operation refused, unit
sssd-pam.service may be requested by dependency only (it is configured to
refuse manual start/stop).
See system logs and 'systemctl status sssd-pam.service' for details.
Failed to try-restart sssd-ssh.service: Operation refused, unit
sssd-ssh.service may be requested by dependency only (it is configured to
refuse manual start/stop).
See system logs and 'systemctl status sssd-ssh.service' for details.
Failed to try-restart sssd-sudo.service: Operation refused, unit
sssd-sudo.service may be requested by dependency only (it is configured to
refuse manual start/stop).
See system logs and 'systemctl status sssd-sudo.service' for details.

Looking at my dnf rpm log, this seems to have been going on for quite some
time and I can't believe I'm the first to notice...

Thanks,
Richard

[Tom Hughes]

On 25/02/2021 13:13, Richard Shaw wrote:
>  Per the packaging guidelines these don't seem to be optional:
>  
>  https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_sy... 
>  <https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_sy...
Indeed they're not optional, but they're also not missing as a glance
a the spec file confirms:

https://src.fedoraproject.org/rpms/sssd/blob/rawhide/f/sssd.spec#_931

>  Additionally, at a minimum systemctl daemon-reload should be run. It
>
>  looks like there is some sort of default behavior but it's not correct.
>  
>  Warning: The unit file, source configuration file or drop-ins of 
>  sssd-kcm.socket changed on disk. Run 'systemctl daemon-reload' to reload 
>  units.
>  Warning: The unit file, source configuration file or drop-ins of 
>  sssd-kcm.service changed on disk. Run 'systemctl daemon-reload' to 
>  reload units. 
What you are seeing there is RHBZ#1614751 in action.

>  Looking at my dnf rpm log, this seems to have been going on for quite
>
>  some time and I can't believe I'm the first to notice... 
You're not, and after 2.5 years it is finally about to be fixed.

Tom

-- 
Tom Hughes (tom(a)compton.nu)
http://compton.nu/

[Richard Shaw]

On Thu, Feb 25, 2021 at 7:39 AM Tom Hughes <tom(a)compton.nu&gt; wrote:

>  On 25/02/2021 13:13, Richard Shaw wrote:
>  > Per the packaging guidelines these don't seem to be optional:
>  >
>  >
>  https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_sy...
>  > <
>  https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_sy...
>  >
>
>  Indeed they're not optional, but they're also not missing as a glance
>  a the spec file confirms:
>
>  https://src.fedoraproject.org/rpms/sssd/blob/rawhide/f/sssd.spec#_931 

Ahh, I never thought to look past %files :)

Separate package, but I got a similar daemon-reload warning for
unbound-libs, but it was for a timer unit, which are not mentioned in the
packaging guidelines.

Warning: The unit file, source configuration file or drop-ins of
unbound-anchor.timer changed on disk. Run 'systemctl daemon-reload' to
reload units.

Should they be?

Thanks,
Richard

[Tom Hughes]

On 25/02/2021 13:58, Richard Shaw wrote:
>  On Thu, Feb 25, 2021 at 7:39 AM Tom Hughes <tom(a)compton.nu 
>  <mailto:[e-mail]>> wrote:
>  
>      On 25/02/2021 13:13, Richard Shaw wrote:
>       > Per the packaging guidelines these don't seem to be optional:
>       >
>       >
>      https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_sy...
>     
> <https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_sy...
>  
>       >
>      <https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_sy...
>     
> <https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_sy...
>  
>      Indeed they're not optional, but they're also not missing as a glance
>      a the spec file confirms:
>  
>      https://src.fedoraproject.org/rpms/sssd/blob/rawhide/f/sssd.spec#_931
> <https://src.fedoraproject.org/rpms/sssd/blob/rawhide/f/sssd.spec#_931>
>  
>  
>  Ahh, I never thought to look past %files :)
>  
>  Separate package, but I got a similar daemon-reload warning for 
>  unbound-libs, but it was for a timer unit, which are not mentioned in 
>  the packaging guidelines.
>  
>  Warning: The unit file, source configuration file or drop-ins of 
>  unbound-anchor.timer changed on disk. Run 'systemctl daemon-reload' to 
>  reload units. 
You'll get it for literally everything that uses the macros
to try and restart itself if the update has changed the unit
definition in any way because the restart is done before the
reload so the new unit definition is not loaded yet.

Tom

-- 
Tom Hughes (tom(a)compton.nu)
http://compton.nu/

[Pavel Březina]

On 2/25/21 2:39 PM, Tom Hughes via devel wrote:
>  On 25/02/2021 13:13, Richard Shaw wrote:
> > Per the packaging guidelines these don't seem to be optional:
> >
> > https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_sy... 
> >
> <https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_sy... 
> >
>  
>  Indeed they're not optional, but they're also not missing as a glance
>  a the spec file confirms:
>  
>  https://src.fedoraproject.org/rpms/sssd/blob/rawhide/f/sssd.spec#_931
>  
> > Additionally, at a minimum systemctl daemon-reload should be run. It 
> > looks like there is some sort of default behavior but it's not correct.
> >
> > Warning: The unit file, source configuration file or drop-ins of 
> > sssd-kcm.socket changed on disk. Run 'systemctl daemon-reload' to 
> > reload units.
> > Warning: The unit file, source configuration file or drop-ins of 
> > sssd-kcm.service changed on disk. Run 'systemctl daemon-reload' to 
> > reload units.
>  
>  What you are seeing there is RHBZ#1614751 in action.
>  
> > Looking at my dnf rpm log, this seems to have been going on for quite 
> > some time and I can't believe I'm the first to notice...
>  
>  You're not, and after 2.5 years it is finally about to be fixed. 
Thank you for the reminder. I opened PR against SSSD upstream:
https://github.com/SSSD/sssd/pull/5522

Once accepted, I will include this change in Fedora spec file.

>  
>  Tom
>