Attempt at building YafaRay

[Luya Tshimbalanga]

Here is an attempt at building YafaRay using scratch build:

https://koji.fedoraproject.org/koji/taskinfo?taskID=17274673


An issue is somehow OpenCV will not meet a requirement due to this error
below:

--   Found opencv, version 3.1.0
CMake Error at CMakeModules/FindOpenCV.cmake:120 (string):
  string sub-command REGEX, mode REPLACE needs at least 6 arguments total to
  command.


Using "" to work around the error inside
"CMakeModules/FindOpenCV.cmake"
still produce a failure. Any pointer?

-- 
Luya Tshimbalanga
Graphic & Web Designer
E: luya(a)fedoraproject.org
W: http://www.coolest-storm.net

[Rich Mattes]

On Sat, Jan 14, 2017 at 12:20 AM, Luya Tshimbalanga
<luya(a)fedoraproject.org&gt; wrote:
>  Here is an attempt at building YafaRay using scratch build:
>
>  https://koji.fedoraproject.org/koji/taskinfo?taskID=17274673
>
>
>  An issue is somehow OpenCV will not meet a requirement due to this error
>  below:
>
>  --   Found opencv, version 3.1.0
>  CMake Error at CMakeModules/FindOpenCV.cmake:120 (string):
>    string sub-command REGEX, mode REPLACE needs at least 6 arguments total to
>    command.
>
>
>  Using "" to work around the error inside
> "CMakeModules/FindOpenCV.cmake"
>  still produce a failure. Any pointer? 


The code [1] is looking for strings matching CV_[A-Z]+_VERSION in
opencv2/core/version.hpp, which it then filters by CV_MAJOR_VERSION,
CV_MINOR_VERSION, and CV_PATCH_VERSION.  On my f25 system,
opencv2/core/version.hpp only contains definitions for
CV_VERSION_MAJOR, CV_VERSION_MINOR, and CV_VERSION_PATCH (the VERSION
and MAJOR/MINOR/PATCH are swapped from what YafaRay expects.)  From
the CMake file's header information, it looks like they only ever
tested against OpenCV 2, so the preprocessor definitions may have
changed between versions 2 and 3.

Anyway, you should be able to work around it by fixing the regexes to
match in the short term.  In the long term, it would be better to
replace that whole file with pkg_check_modules, or
find_package(OpenCV), instead of effectively manually re-implementing
them.

Rich

[1] https://github.com/YafaRay/Core/blob/v3.1.1-beta/CMakeModules/FindOpenCV....

[Luya Tshimbalanga]

On 14/01/17 06:45 AM, Rich Mattes wrote:
>  On Sat, Jan 14, 2017 at 12:20 AM, Luya Tshimbalanga
>  <luya(a)fedoraproject.org&gt; wrote:
> > Here is an attempt at building YafaRay using scratch build:
> >
> > https://koji.fedoraproject.org/koji/taskinfo?taskID=17274673
> >
> >
> > An issue is somehow OpenCV will not meet a requirement due to this error
> > below:
> >
> > --   Found opencv, version 3.1.0
> > CMake Error at CMakeModules/FindOpenCV.cmake:120 (string):
> >   string sub-command REGEX, mode REPLACE needs at least 6 arguments total to
> >   command.
> >
> >
> > Using "" to work around the error inside
> "CMakeModules/FindOpenCV.cmake"
> > still produce a failure. Any pointer?
>
>
>  The code [1] is looking for strings matching CV_[A-Z]+_VERSION in
>  opencv2/core/version.hpp, which it then filters by CV_MAJOR_VERSION,
>  CV_MINOR_VERSION, and CV_PATCH_VERSION.  On my f25 system,
>  opencv2/core/version.hpp only contains definitions for
>  CV_VERSION_MAJOR, CV_VERSION_MINOR, and CV_VERSION_PATCH (the VERSION
>  and MAJOR/MINOR/PATCH are swapped from what YafaRay expects.)  From
>  the CMake file's header information, it looks like they only ever
>  tested against OpenCV 2, so the preprocessor definitions may have
>  changed between versions 2 and 3.
>
>  Anyway, you should be able to work around it by fixing the regexes to
>  match in the short term.  In the long term, it would be better to
>  replace that whole file with pkg_check_modules, or
>  find_package(OpenCV), instead of effectively manually re-implementing
>  them.
>
>  Rich
>
>  [1] https://github.com/YafaRay/Core/blob/v3.1.1-beta/CMakeModules/FindOpenCV....
>  _______________________________________________
>  devel mailing list -- devel(a)lists.fedoraproject.org
>  To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org 
Thank you for the reply. I filed a report to upstream.

-- 
Luya Tshimbalanga
Graphic & Web Designer
E: luya(a)fedoraproject.org
W: http://www.coolest-storm.net

[David Bluecame]

Hello,

I'm David Bluecame, one of the YafaRay developers.

Thank you for trying to build YafaRay and I apologize for the problems you are
experiencing while trying to build v3.1.1.

After v3.1.1 was released, over the last months, in the master branch of the GitHub
repository https://github.com/YafaRay/Core , I've been modifying the build scripts to
make them easier to build in different OSes and to integrate better with Git tagging
system. I plan to include them in the upcoming YafaRay v3.2.0 release.

Please try to build the latest master in git instead of v3.1.1 code. I also put some
building guides here:

https://github.com/YafaRay/Core/tree/master/building/linux

I hope it helps. Best regards!

[Luya Tshimbalanga]

On 27/01/17 11:33 PM, David Bluecame wrote:
>  Hello,
>
>  I'm David Bluecame, one of the YafaRay developers.
>
>  Thank you for trying to build YafaRay and I apologize for the problems you are
> experiencing while trying to build v3.1.1.
>
>  After v3.1.1 was released, over the last months, in the master branch of the GitHub
> repository https://github.com/YafaRay/Core , I've been modifying the build scripts to
> make them easier to build in different OSes and to integrate better with Git tagging
> system. I plan to include them in the upcoming YafaRay v3.2.0 release.
>
>  Please try to build the latest master in git instead of v3.1.1 code. I also put some
> building guides here:
>
>  https://github.com/YafaRay/Core/tree/master/building/linux
>
>  I hope it helps. Best regards!
>  _______________________________________________
>  devel mailing list -- devel(a)lists.fedoraproject.org
>  To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org 
Hi David,

Thank you for suggesting latest master to build the package from Core.
I will provide the result as soon as possible.

Sincerely,

-- 
Luya Tshimbalanga
Graphic & Web Designer
E: luya(a)fedoraproject.org
W: http://www.coolest-storm.net

[Luya Tshimbalanga]

Hello David,
I noticed this error at list line
+ /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1
Compiling
/builddir/build/BUILDROOT/YafaRay-3.2.0-0.2.20170212git.fc25.x86_64/usr/share/blender/2.78/scripts/addons/yafaray/ot/yafaray_presets.py
...
  File "/usr/share/blender/2.78/scripts/addons/yafaray/ot/yafaray_presets.py",
line 341
    class Yafaray_Menu(StructRNA, _GenericUI, metaclass=RNAMeta):  # Yafaray's own
Preset Menu drawing: search method for files changed
                                                       ^
SyntaxError: invalid syntax
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.07Lyfo (%install)

It looks like a typo somewhere inside pt/yafaray_presets.py. Interesting enoug, removing
it made the build successful. Could you investigate the issue?

Luya