Hey folks.
The fawkes package FTBFS and is not installable in F33/rawhide. This breaks the robotics spin compose, and since it's the _last_ failing thing in f33 composes, I'd love to fix it. :)
We don't have a listed post of contact for the robotics spin. :( If we did perhaps we could just remove fawkes for now and fix it that way? Or is it too essential to the spin? I don't know. ;(
So, I went part way down the rabbit hole, and I wonder if someone else can figure out the rest.
First we need: https://patch-diff.githubusercontent.com/raw/fawkesrobotics/fawkes/pull/228.... to fix the boost placeholder change in the recent boost update.
Then, https://github.com/fawkesrobotics/fawkes/compare/tviehmann/microhttpd-temp-f... gets it past the updated microhttpd that we have.
But then it hits:
https://koji.fedoraproject.org/koji/taskinfo?taskID=53038092
... [PLUGIN] src/plugins/clips-navgraph/: plugins/clips-navgraph <-- Leaving src/plugins/gazebo/msgs In file included from /usr/include/ignition/msgs1/ignition/msgs/header.pb.h:35, from /usr/include/ignition/msgs1/ignition/msgs/color.pb.h:35, from /usr/include/gazebo-10/gazebo/msgs/msgs.hh:32, from /usr/include/gazebo-10/gazebo/transport/TopicManager.hh:30, from /usr/include/gazebo-10/gazebo/transport/Node.hh:32, from /builddir/build/BUILD/fawkes-1.3.0/src/plugins/gazebo/aspect/gazebo.h:30, from /builddir/build/BUILD/fawkes-1.3.0/src/plugins/gazebo/aspect/gazebo_inifin.h:28, from /builddir/build/BUILD/fawkes-1.3.0/src/plugins/gazebo/aspect/gazebo_inifin.cpp:25: /usr/include/ignition/msgs1/ignition/msgs/time.pb.h:56:51: error: 'AuxiliaryParseTableField' in namespace 'google::protobuf::internal' does not name a type; did you mean 'AuxillaryParseTableField'? 56 | static const ::PROTOBUF_NAMESPACE_ID::internal::AuxiliaryParseTableField aux[] | ^~~~~~~~~~~~~~~~~~~~~~~~ | AuxillaryParseTableField ...
I think this might be that we need a newer ignition-msgs package? Or something in gazebo?
Ideas welcome. ;)
kevin
Hi Kevin,
On 10/9/20 9:19 PM, Kevin Fenzi wrote:
Hey folks.
The fawkes package FTBFS and is not installable in F33/rawhide. This breaks the robotics spin compose, and since it's the _last_ failing thing in f33 composes, I'd love to fix it. :)
We don't have a listed post of contact for the robotics spin. :( If we did perhaps we could just remove fawkes for now and fix it that way? Or is it too essential to the spin? I don't know. ;(
So, I went part way down the rabbit hole, and I wonder if someone else can figure out the rest.
Thanks for looking into this!
Rawhide should hopefully build now (it succeeded locally): https://koji.fedoraproject.org/koji/taskinfo?taskID=53107361
First we need: https://patch-diff.githubusercontent.com/raw/fawkesrobotics/fawkes/pull/228.... to fix the boost placeholder change in the recent boost update.
Then, https://github.com/fawkesrobotics/fawkes/compare/tviehmann/microhttpd-temp-f... gets it past the updated microhttpd that we have.
But then it hits:
https://koji.fedoraproject.org/koji/taskinfo?taskID=53038092
... [PLUGIN] src/plugins/clips-navgraph/: plugins/clips-navgraph <-- Leaving src/plugins/gazebo/msgs In file included from /usr/include/ignition/msgs1/ignition/msgs/header.pb.h:35, from /usr/include/ignition/msgs1/ignition/msgs/color.pb.h:35, from /usr/include/gazebo-10/gazebo/msgs/msgs.hh:32, from /usr/include/gazebo-10/gazebo/transport/TopicManager.hh:30, from /usr/include/gazebo-10/gazebo/transport/Node.hh:32, from /builddir/build/BUILD/fawkes-1.3.0/src/plugins/gazebo/aspect/gazebo.h:30, from /builddir/build/BUILD/fawkes-1.3.0/src/plugins/gazebo/aspect/gazebo_inifin.h:28, from /builddir/build/BUILD/fawkes-1.3.0/src/plugins/gazebo/aspect/gazebo_inifin.cpp:25: /usr/include/ignition/msgs1/ignition/msgs/time.pb.h:56:51: error: 'AuxiliaryParseTableField' in namespace 'google::protobuf::internal' does not name a type; did you mean 'AuxillaryParseTableField'? 56 | static const ::PROTOBUF_NAMESPACE_ID::internal::AuxiliaryParseTableField aux[] | ^~~~~~~~~~~~~~~~~~~~~~~~ | AuxillaryParseTableField ...
I think this might be that we need a newer ignition-msgs package? Or something in gazebo?
I think it's the other way around: ignition-msgs needs protobuf 3.13 because that contains a patch that renamed AuxillaryParseTableField to AuxiliaryParseTableField: https://github.com/protocolbuffers/protobuf/commit/2ae7cf0e03c3469973e592e81...
I don't think we can do anything from the fawkes side.
Kind regards Till
On 10/9/20 11:46 PM, Till Hofmann wrote:
On 10/9/20 9:19 PM, Kevin Fenzi wrote:
I think this might be that we need a newer ignition-msgs package? Or something in gazebo?
I think it's the other way around: ignition-msgs needs protobuf 3.13 because that contains a patch that renamed AuxillaryParseTableField to AuxiliaryParseTableField: https://github.com/protocolbuffers/protobuf/commit/2ae7cf0e03c3469973e592e81...
After some digging: This commit is in 3.12.3 but not in 3.12.4. I guess they noticed this requires a rebuild of dependent packages and they thus reverted it. Gazebo is also currently FTBFS with the same error message. After rebuilding ignition-msgs, I was able to rebuild gazebo and fawkes.
I'm pushing my changes and I'll push updates soon.
I guess this issue could also occur with other packages depending on protobuf, but I'll stop here.
Kind regards, Till
On 10/10/20 10:54 AM, Till Hofmann wrote:
On 10/9/20 11:46 PM, Till Hofmann wrote:
On 10/9/20 9:19 PM, Kevin Fenzi wrote:
I think this might be that we need a newer ignition-msgs package? Or something in gazebo?
I think it's the other way around: ignition-msgs needs protobuf 3.13 because that contains a patch that renamed AuxillaryParseTableField to AuxiliaryParseTableField: https://github.com/protocolbuffers/protobuf/commit/2ae7cf0e03c3469973e592e81...
After some digging: This commit is in 3.12.3 but not in 3.12.4. I guess they noticed this requires a rebuild of dependent packages and they thus reverted it. Gazebo is also currently FTBFS with the same error message. After rebuilding ignition-msgs, I was able to rebuild gazebo and fawkes.
I'm pushing my changes and I'll push updates soon.
Now I'm hitting: fatal: repository 'https://src.fedoraproject.org/tmp/ignition-msgs.git/' not found https://koji.fedoraproject.org/koji/taskinfo?taskID=53134273
Not sure what's going on, can somebody help? Am I missing permissions to build? I was able to push.
Kind regards, Till
On Sat, Oct 10, 2020 at 10:59:12AM +0200, Till Hofmann wrote:
On 10/10/20 10:54 AM, Till Hofmann wrote:
On 10/9/20 11:46 PM, Till Hofmann wrote:
On 10/9/20 9:19 PM, Kevin Fenzi wrote:
I think this might be that we need a newer ignition-msgs package? Or something in gazebo?
I think it's the other way around: ignition-msgs needs protobuf 3.13 because that contains a patch that renamed AuxillaryParseTableField to AuxiliaryParseTableField: https://github.com/protocolbuffers/protobuf/commit/2ae7cf0e03c3469973e592e81...
After some digging: This commit is in 3.12.3 but not in 3.12.4. I guess they noticed this requires a rebuild of dependent packages and they thus reverted it. Gazebo is also currently FTBFS with the same error message. After rebuilding ignition-msgs, I was able to rebuild gazebo and fawkes.
I'm pushing my changes and I'll push updates soon.
Awesome. We can propose the update as a Freeze break to get robotics working. ;)
Now I'm hitting: fatal: repository 'https://src.fedoraproject.org/tmp/ignition-msgs.git/' not found https://koji.fedoraproject.org/koji/taskinfo?taskID=53134273
Not sure what's going on, can somebody help? Am I missing permissions to build? I was able to push.
weird. The /tmp/ in there is completely wrong... it should be /rpms/
did you just do 'fedpkg build' ? or something else? Any odd changes you made to fedpkg there?
If you like I can try it from here...
kevin
On 10/10/20 6:24 PM, Kevin Fenzi wrote:
On Sat, Oct 10, 2020 at 10:59:12AM +0200, Till Hofmann wrote:
On 10/10/20 10:54 AM, Till Hofmann wrote:
On 10/9/20 11:46 PM, Till Hofmann wrote:
On 10/9/20 9:19 PM, Kevin Fenzi wrote:
I think this might be that we need a newer ignition-msgs package? Or something in gazebo?
I think it's the other way around: ignition-msgs needs protobuf 3.13 because that contains a patch that renamed AuxillaryParseTableField to AuxiliaryParseTableField: https://github.com/protocolbuffers/protobuf/commit/2ae7cf0e03c3469973e592e81...
After some digging: This commit is in 3.12.3 but not in 3.12.4. I guess they noticed this requires a rebuild of dependent packages and they thus reverted it. Gazebo is also currently FTBFS with the same error message. After rebuilding ignition-msgs, I was able to rebuild gazebo and fawkes.
I'm pushing my changes and I'll push updates soon.
Awesome. We can propose the update as a Freeze break to get robotics working. ;)
Now I'm hitting: fatal: repository 'https://src.fedoraproject.org/tmp/ignition-msgs.git/' not found https://koji.fedoraproject.org/koji/taskinfo?taskID=53134273
Not sure what's going on, can somebody help? Am I missing permissions to build? I was able to push.
weird. The /tmp/ in there is completely wrong... it should be /rpms/
did you just do 'fedpkg build' ? or something else? Any odd changes you made to fedpkg there?
If you like I can try it from here...
I found the issue, I had a second git remote that was something ending in /tmp/ignition-msgs, so it expected this to be the path. Funny bug. Anyway, after changing the remote tracking branch, it worked and building now!
Till
On 10/10/20 5:27 PM, Till Hofmann wrote:
On 10/10/20 6:24 PM, Kevin Fenzi wrote:
On Sat, Oct 10, 2020 at 10:59:12AM +0200, Till Hofmann wrote:
On 10/10/20 10:54 AM, Till Hofmann wrote:
On 10/9/20 11:46 PM, Till Hofmann wrote:
On 10/9/20 9:19 PM, Kevin Fenzi wrote:
I think this might be that we need a newer ignition-msgs package? Or something in gazebo?
I think it's the other way around: ignition-msgs needs protobuf 3.13 because that contains a patch that renamed AuxillaryParseTableField to AuxiliaryParseTableField: https://github.com/protocolbuffers/protobuf/commit/2ae7cf0e03c3469973e592e81...
After some digging: This commit is in 3.12.3 but not in 3.12.4. I guess they noticed this requires a rebuild of dependent packages and they thus reverted it. Gazebo is also currently FTBFS with the same error message. After rebuilding ignition-msgs, I was able to rebuild gazebo and fawkes.
I'm pushing my changes and I'll push updates soon.
Awesome. We can propose the update as a Freeze break to get robotics working. ;)
Now I'm hitting: fatal: repository 'https://src.fedoraproject.org/tmp/ignition-msgs.git/' not found https://koji.fedoraproject.org/koji/taskinfo?taskID=53134273
Not sure what's going on, can somebody help? Am I missing permissions to build? I was able to push.
weird. The /tmp/ in there is completely wrong... it should be /rpms/
did you just do 'fedpkg build' ? or something else? Any odd changes you made to fedpkg there?
If you like I can try it from here...
I found the issue, I had a second git remote that was something ending in /tmp/ignition-msgs, so it expected this to be the path. Funny bug. Anyway, after changing the remote tracking branch, it worked and building now!
Till
Thanks for working through all of this. I got the buildroot overrides in place to rebuild ignition-transport and gazebo against ignition-msgs, gazebo is currently building. Once it's done I'll submit a buildroot override so fawkes can be rebuilt in f33.
Rich
On 10/11/20 1:56 AM, Rich Mattes wrote:
On 10/10/20 5:27 PM, Till Hofmann wrote:
On 10/10/20 6:24 PM, Kevin Fenzi wrote:
On Sat, Oct 10, 2020 at 10:59:12AM +0200, Till Hofmann wrote:
On 10/10/20 10:54 AM, Till Hofmann wrote:
On 10/9/20 11:46 PM, Till Hofmann wrote:
On 10/9/20 9:19 PM, Kevin Fenzi wrote:
> > I think this might be that we need a newer ignition-msgs package? > Or something in gazebo?
I think it's the other way around: ignition-msgs needs protobuf 3.13 because that contains a patch that renamed AuxillaryParseTableField to AuxiliaryParseTableField: https://github.com/protocolbuffers/protobuf/commit/2ae7cf0e03c3469973e592e81...
After some digging: This commit is in 3.12.3 but not in 3.12.4. I guess they noticed this requires a rebuild of dependent packages and they thus reverted it. Gazebo is also currently FTBFS with the same error message. After rebuilding ignition-msgs, I was able to rebuild gazebo and fawkes.
I'm pushing my changes and I'll push updates soon.
Awesome. We can propose the update as a Freeze break to get robotics working. ;)
Now I'm hitting: fatal: repository 'https://src.fedoraproject.org/tmp/ignition-msgs.git/' not found https://koji.fedoraproject.org/koji/taskinfo?taskID=53134273
Not sure what's going on, can somebody help? Am I missing permissions to build? I was able to push.
weird. The /tmp/ in there is completely wrong... it should be /rpms/
did you just do 'fedpkg build' ? or something else? Any odd changes you made to fedpkg there?
If you like I can try it from here...
I found the issue, I had a second git remote that was something ending in /tmp/ignition-msgs, so it expected this to be the path. Funny bug. Anyway, after changing the remote tracking branch, it worked and building now!
Till
Thanks for working through all of this. I got the buildroot overrides in place to rebuild ignition-transport and gazebo against ignition-msgs, gazebo is currently building. Once it's done I'll submit a buildroot override so fawkes can be rebuilt in f33.
Thank you! Yeah I'd forgotten the buildroot override. I saw that you created one for gazebo already, so I just triggered a new build for fawkes: https://koji.fedoraproject.org/koji/taskinfo?taskID=53208800
Let's see how it goes!
Till
On 10/11/20 1:51 PM, Till Hofmann wrote:
On 10/11/20 1:56 AM, Rich Mattes wrote:
On 10/10/20 5:27 PM, Till Hofmann wrote:
On 10/10/20 6:24 PM, Kevin Fenzi wrote:
On Sat, Oct 10, 2020 at 10:59:12AM +0200, Till Hofmann wrote:
On 10/10/20 10:54 AM, Till Hofmann wrote:
On 10/9/20 11:46 PM, Till Hofmann wrote:
> > On 10/9/20 9:19 PM, Kevin Fenzi wrote:
>> >> I think this might be that we need a newer ignition-msgs package? >> Or something in gazebo? > > I think it's the other way around: ignition-msgs needs protobuf 3.13 > because that contains a patch that renamed > AuxillaryParseTableField to > AuxiliaryParseTableField: > https://github.com/protocolbuffers/protobuf/commit/2ae7cf0e03c3469973e592e81... >
After some digging: This commit is in 3.12.3 but not in 3.12.4. I guess they noticed this requires a rebuild of dependent packages and they thus reverted it. Gazebo is also currently FTBFS with the same error message. After rebuilding ignition-msgs, I was able to rebuild gazebo and fawkes.
I'm pushing my changes and I'll push updates soon.
Awesome. We can propose the update as a Freeze break to get robotics working. ;)
Now I'm hitting: fatal: repository 'https://src.fedoraproject.org/tmp/ignition-msgs.git/' not found https://koji.fedoraproject.org/koji/taskinfo?taskID=53134273
Not sure what's going on, can somebody help? Am I missing permissions to build? I was able to push.
weird. The /tmp/ in there is completely wrong... it should be /rpms/
did you just do 'fedpkg build' ? or something else? Any odd changes you made to fedpkg there?
If you like I can try it from here...
I found the issue, I had a second git remote that was something ending in /tmp/ignition-msgs, so it expected this to be the path. Funny bug. Anyway, after changing the remote tracking branch, it worked and building now!
Till
Thanks for working through all of this. I got the buildroot overrides in place to rebuild ignition-transport and gazebo against ignition-msgs, gazebo is currently building. Once it's done I'll submit a buildroot override so fawkes can be rebuilt in f33.
Thank you! Yeah I'd forgotten the buildroot override. I saw that you created one for gazebo already, so I just triggered a new build for fawkes: https://koji.fedoraproject.org/koji/taskinfo?taskID=53208800
The build succeeded, here is the update: https://bodhi.fedoraproject.org/updates/FEDORA-2020-10d819f69d
Please give karma if you can!
Kind regards, Till
On Sun, Oct 11, 2020 at 03:01:06PM +0200, Till Hofmann wrote:
The build succeeded, here is the update: https://bodhi.fedoraproject.org/updates/FEDORA-2020-10d819f69d
Please give karma if you can!
Cool. I've proposed it as a Freeze Break request.
kevin
-
Kevin Fenzi -
Rich Mattes -
Till Hofmann -
Till Hofmann