Hi,
While looking into the packages on my F31 that were not rebuilt for F31, I was looking at tk and why it was not rebuilt for F31 - it appears this package has a noautobuild file in dist-git. Should packages still be allowed to opt-out of mass rebuilds? I can't find any recent documentation about noautobuild or reminders to maintainers to manually rebuild their packages.
Scott
On 01. 11. 19 4:11, Scott Talbert wrote:
Hi,
While looking into the packages on my F31 that were not rebuilt for F31, I was looking at tk and why it was not rebuilt for F31 - it appears this package has a noautobuild file in dist-git. Should packages still be allowed to opt-out of mass rebuilds? I can't find any recent documentation about noautobuild or reminders to maintainers to manually rebuild their packages.
Here's what I think actually happens:
- the releng scripts that does mass rebuild still respect the file - the package is not rebuilt - there is no automated followup
:(
Yeah, looks like mass rebuild just skips these packages: https://pagure.io/releng/blob/master/f/scripts/mass-rebuild.py#_125
I am wondering if it wouldn't make sense to do a scratch build in that case and proceed with normal FTBS policy [0] if it fails.
[0] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_...
On 01. 11. 19 10:11, Frantisek Zatloukal wrote:
Yeah, looks like mass rebuild just skips these packages: https://pagure.io/releng/blob/master/f/scripts/mass-rebuild.py#_125
I am wondering if it wouldn't make sense to do a scratch build in that case and proceed with normal FTBS policy [0] if it fails.
The policy will eventually kick in. Recent changes make it so that packages that haven't rebuilt for certain number of releases will be retired with announcements. Even if releng have never attempted to do so.
That means that if packages with noautobuild fail to build, nobody will notice for ~year and than the maintainer have 6 weeks to fix it. \o/
I strongly suggest we should revisit all our noautobuild packages.
[0] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_...
On 01. 11. 19 10:21, Miro Hrončok wrote:
On 01. 11. 19 10:11, Frantisek Zatloukal wrote:
Yeah, looks like mass rebuild just skips these packages: https://pagure.io/releng/blob/master/f/scripts/mass-rebuild.py#_125
I am wondering if it wouldn't make sense to do a scratch build in that case and proceed with normal FTBS policy [0] if it fails.
The policy will eventually kick in. Recent changes make it so that packages that haven't rebuilt for certain number of releases will be retired with announcements. Even if releng have never attempted to do so.
That means that if packages with noautobuild fail to build, nobody will notice for ~year and than the maintainer have 6 weeks to fix it. \o/
I strongly suggest we should revisit all our noautobuild packages.
For example, for tk, the commit says:
2014-05-21 Added noautobuild, tcl/tk-8.6 cannot be automatically rebuild now
https://src.fedoraproject.org/rpms/tk/c/90966fa?branch=master
But the package was rebuilt couple times in the last 5 years actually.
On Fri, 1 Nov 2019, Miro Hrončok wrote:
Yeah, looks like mass rebuild just skips these packages: https://pagure.io/releng/blob/master/f/scripts/mass-rebuild.py#_125
I am wondering if it wouldn't make sense to do a scratch build in that case and proceed with normal FTBS policy [0] if it fails.
The policy will eventually kick in. Recent changes make it so that packages that haven't rebuilt for certain number of releases will be retired with announcements. Even if releng have never attempted to do so.
That means that if packages with noautobuild fail to build, nobody will notice for ~year and than the maintainer have 6 weeks to fix it. \o/
I strongly suggest we should revisit all our noautobuild packages.
For example, for tk, the commit says:
2014-05-21 Added noautobuild, tcl/tk-8.6 cannot be automatically rebuild now
https://src.fedoraproject.org/rpms/tk/c/90966fa?branch=master
But the package was rebuilt couple times in the last 5 years actually.
I'm going to file a PR to remove the noautobuild from tk. Doesn't seem to have a justification.
Scott
On 11/1/19 9:19 AM, Scott Talbert wrote:
On Fri, 1 Nov 2019, Miro Hrončok wrote:
For example, for tk, the commit says:
2014-05-21 Added noautobuild, tcl/tk-8.6 cannot be automatically rebuild now
..
But the package was rebuilt couple times in the last 5 years actually.
I'm going to file a PR to remove the noautobuild from tk. Doesn't seem to have a justification.
I asked the committer, and Jaroslaw agrees that it is not needed any more, and will remove it.
-
Frantisek Zatloukal -
Miro Hrončok -
Przemek Klosowski -
Scott Talbert