Review Request: rubygem-asciidoctor-diagram - Asciidoctor diagramming extension

[Christopher Brown]

Greetings,

I'm the current maintainer for the asciidoctor-pdf package plus various
dependencies in Fedora and have spent some time putting together the
following review request for a diagramming extension for Asciidoctor.

Appreciate any reviews.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1897619
Spec:
https://raw.githubusercontent.com/snecklifter/rubygem-asciidoctor-diagram...
Copr:
https://copr.fedorainfracloud.org/coprs/snecker/rubygem-asciidoctor-diagram/

Thanks!

Chris

[Christopher Brown]

Hello,

Would it be possible to get a review on this please?

On Tue, 24 Nov 2020 at 22:58, Christopher Brown <chris.brown(a)redhat.com&gt;
wrote:

>  Greetings,
>
>  I'm the current maintainer for the asciidoctor-pdf package plus various
>  dependencies in Fedora and have spent some time putting together the
>  following review request for a diagramming extension for Asciidoctor.
>
>  Appreciate any reviews.
>
>  BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1897619
>  Spec:
>
> https://raw.githubusercontent.com/snecklifter/rubygem-asciidoctor-diagram...
>  Copr:
>  https://copr.fedorainfracloud.org/coprs/snecker/rubygem-asciidoctor-diagram/
>
>  Thanks!
>
>  Chris
>  

-- 
Christopher Brown
Senior Consultant
Red Hat UK Ltd
chris.brown(a)redhat.com

[Robert-André Mauchin]

On 12/22/20 12:23 PM, Christopher Brown wrote:
>  Hello,
>  
>  Would it be possible to get a review on this please?
>   
You can't provide precompiled jar files, they needs to be build from source:

Issues:
=======
- Bundled jar/class files should be removed before build
   Note: Jar files in source (see attachment)
   See: https://docs.fedoraproject.org/en-US/packaging-
   guidelines/Java/#_pre_built_dependencies

Jar and class files in source
-----------------------------
./asciidoctor-diagram-2.0.5/lib/batik-all-1.10.jar
./asciidoctor-diagram-2.0.5/lib/ditaa-1.3.15.jar
./asciidoctor-diagram-2.0.5/lib/ditaamini-0.12.jar
./asciidoctor-diagram-2.0.5/lib/jlatexmath-minimal-1.0.5.jar
./asciidoctor-diagram-2.0.5/lib/plantuml-1.3.15.jar
./asciidoctor-diagram-2.0.5/lib/plantuml.jar
./asciidoctor-diagram-2.0.5/lib/server-1.3.15.jar