qmake-qt4 DEFINES issue

[Antonio Trande]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all.

I need your help with F1LT application[1]. Its latest release (3.0.0)
seems not work even if little things are changed in SPEC file.

'f1lt' binary doesn't load its data files located in
'usr/share/f1lt-3.0.0' directory; if I unusually copy the binary file
in 'usr/share/f1lt-3.0.0' and run it by there, so everything works fine.

I though this problem is related to Makefile generated by qmake but
everything seems good even here[2].

This is the ticket dicussed with upstream[3]

Any idea?


[1]
https://admin.fedoraproject.org/pkgdb/acls/name/f1lt?_csrf_token=c6813dd1...

[2] http://www.fpaste.org/85836/

[3]
https://bitbucket.org/pieczar/f1lt/issue/3/f1lt-commit-7440f9a-does-not-run
- -- 
Antonio Trande

mailto: sagitterATfedoraproject.org
http://www.fedoraos.worpress.com
https://fedoraproject.org/wiki/User:Sagitter
GPG Key: D400D6C4
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iQIcBAEBAgAGBQJTJZKJAAoJED2vIvfUANbE4BcQANOBuSZnuOVxic2WlEYSYSc9
> QBvacwIsAI+A9ESSsMytLZaszwEw2dGyh8P0YajiAGtKVVkqb6GpnPhGCxdFQeKv
> uimZwzdSiWow+EWjbWtiXU/tW45ZG0d5zeenVvNbaDc4Z/CO6PMoXeJePyEwmZmm
> 729z4dWNRVHWm3NdZwhtN3LPida115ulh8iXzPgCSNzBUkVBpo6O/GtwwEon5/M7
> T8doRmKb4YjJdDKzqWFAaOftcoM8XBcP8ZiZ2KbQs97HJSbJ4GWU4QBLmpQuR9Dr
> Zos8L6o4ev0qOnR8/ZQL40yhFWcASIY+BHVQX4+m9kxZW4lWvHiuCx8dT2H5APGV
> bA1vDQLOuOE3Me/DAH3wT02PnbltrHDCGhFuLpUSR8tZaVOCaFWNOjhJO3DOK0Hw
> vQIQEcuyyBpm5ILwsO7Ug0JE/HH4EKbOCso3PYSNTdnvfc7IBcT+Gn08x850FkAA
> u5vdvUE3QmISQzSDWLXofHXba7NvzZbyzZ6n02lFOa2s7j0GPWQpsuOxqGHTN/6s
> t3JWSbZAc8M4R18MBfoQ1byhjgrYx9uqQ2vzYQkLkTLOepfbMJ9jbDs2YjNGvknX
> UEtHRBn/H6CisGCdCOnrVF2EEvaZXglHiOyhn3dmFzGE819DK7p/DZdF2VxXrX8/
> Wiy4b1T1wbUXVyiAuFBx
> =FoeI
> -----END PGP SIGNATURE-----

[Kevin Kofler]

Antonio Trande wrote:
>  I need your help with F1LT application[1]. Its latest release
> (3.0.0)
>  seems not work even if little things are changed in SPEC file. 
I see you already resolved your problem with upstream's help:
https://bitbucket.org/pieczar/f1lt/issue/3/f1lt-commit-7440f9a-does-not-run

However, there are several issues in your spec file (not related to this 
particular issue, but they should be fixed):

| Requires(post): gtk2
| Requires(postun): gtk2

should NOT be used. gtk-update-icon-cache is only necessary if GTK+ is 
actually installed. See:
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
"Note that no dependencies should be added for this."

| BuildRequires: qt-devel >= 4.7, desktop-file-utils, dos2unix

"qt-devel >= 4.7" will NOT work as expected, qt-devel has Epoch 1 and so ALL

versions of qt-devel are >= 4.7. You need either "qt-devel >= 1:4.7", or,

better, "qt4-devel >= 4.7". (qt4-devel is a Provides in qt-devel.) Using 
qt4-devel will also work when Qt 5 will become the default (and also on old 
Fedora/RHEL versions where Qt 3 was the default, but you probably won't find 
4.7 available on those).

Basically, NEVER BuildRequire qt-devel, ALWAYS use qt4-devel instead.

        Kevin Kofler

[Ville Skyttä]

On Sun, Mar 23, 2014 at 4:17 AM, Kevin Kofler <kevin.kofler(a)chello.at&gt; wrote:
>  Basically, NEVER BuildRequire qt-devel, ALWAYS use qt4-devel instead.
Looks like there are quite a few packages that don't do that (nor have
the Epoch in the dep).

$ repoquery --repoid=rawhide-source --archlist=src \
    --whatrequires qt-devel --qf="---- %{NAME}\n%{REQUIRES}"

[Kevin Kofler]

Ville Skyttä wrote:
>  Looks like there are quite a few packages that don't do that (nor
> have
>  the Epoch in the dep).
>  
>  $ repoquery --repoid=rawhide-source --archlist=src \
>      --whatrequires qt-devel --qf="---- %{NAME}\n%{REQUIRES}" 
All those packages (even those which just BR qt-devel without versioning) 
are broken and should never have passed review.

        Kevin Kofler
who remembers having had to go through MANY packages to
s/qt-devel/qt3-devel/ when Qt 4 became the default and is NOT looking 
forward to having to do the same again soon for the Qt 4 → 5 transition, 
grrr!

[Rex Dieter]

Kevin Kofler wrote:

>  Ville Skyttä wrote:
> > Looks like there are quite a few packages that don't do that (nor have
> > the Epoch in the dep).
> > 
> > $ repoquery --repoid=rawhide-source --archlist=src \
> >     --whatrequires qt-devel --qf="---- %{NAME}\n%{REQUIRES}"
>  
>  All those packages (even those which just BR qt-devel without versioning) 
One possible fix would be to rename 'qt' back to 'qt4' explicitly

-- rex

[Kevin Kofler]

Rex Dieter wrote:
>  One possible fix would be to rename 'qt' back to
> 'qt4' explicitly 
That will have to happen soon anyway, with the move to Qt 5.

        Kevin Kofler

[Matthew Miller]

On Mon, Mar 24, 2014 at 04:55:34AM +0100, Kevin Kofler wrote:
>  > One possible fix would be to rename 'qt' back to
> 'qt4' explicitly
>  That will have to happen soon anyway, with the move to Qt 5. 
Is qt5 going to be shifted to be packaged as generic qt? Is there value in
doing that over leaving it versioned?

-- 
Matthew Miller    --   Fedora Project    --    <mattdm(a)fedoraproject.org&gt;

[Jaroslav Reznik]

----- Original Message -----
>  On Mon, Mar 24, 2014 at 04:55:34AM +0100, Kevin Kofler wrote:
>  > > One possible fix would be to rename 'qt' back to 'qt4'
> explicitly
>  > That will have to happen soon anyway, with the move to Qt 5.
>  
>  Is qt5 going to be shifted to be packaged as generic qt? Is there value in
>  doing that over leaving it versioned? 
Versioned. See https://bugzilla.redhat.com/show_bug.cgi?id=878188 for 
discussion (unless something changes I missed).

R.

>  --
>  Matthew Miller    --   Fedora Project    --    <mattdm(a)fedoraproject.org&gt;
>  --
>  devel mailing list
>  devel(a)lists.fedoraproject.org
>  https://admin.fedoraproject.org/mailman/listinfo/devel
>  Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

[Antonio Trande]

On 03/23/2014 03:17 AM, Kevin Kofler wrote:
>  Antonio Trande wrote:
> > I need your help with F1LT application[1]. Its latest release (3.0.0)
> > seems not work even if little things are changed in SPEC file.
>  
>  I see you already resolved your problem with upstream's help:
>  https://bitbucket.org/pieczar/f1lt/issue/3/f1lt-commit-7440f9a-does-not-run
>  
>  However, there are several issues in your spec file (not related to this 
>  particular issue, but they should be fixed):
>  
>  | Requires(post): gtk2
>  | Requires(postun): gtk2
>  
>  should NOT be used. gtk-update-icon-cache is only necessary if GTK+ is 
>  actually installed. See:
>  https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
>  "Note that no dependencies should be added for this."
>  
>  | BuildRequires: qt-devel >= 4.7, desktop-file-utils, dos2unix
>  
>  "qt-devel >= 4.7" will NOT work as expected, qt-devel has Epoch 1 and so ALL
>
>  versions of qt-devel are >= 4.7. You need either "qt-devel >= 1:4.7", or,
>
>  better, "qt4-devel >= 4.7". (qt4-devel is a Provides in qt-devel.) Using 
>  qt4-devel will also work when Qt 5 will become the default (and also on old 
>  Fedora/RHEL versions where Qt 3 was the default, but you probably won't find 
>  4.7 available on those).
>  
>  Basically, NEVER BuildRequire qt-devel, ALWAYS use qt4-devel instead.
>  
>          Kevin Kofler 

I'll fix them.
Thank you.

-- 
Antonio Trande

mailto: sagitterATfedoraproject.org
http://www.fedoraos.worpress.com
https://fedoraproject.org/wiki/User:Sagitter
GPG Key: D400D6C4