[Ascend] Failed builds with GCC6

[Antonio Trande]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi all,

Ascend is not built yet on Fedora 24+ because of errors with GCC6:

>  ascxx/ascpy_wrap.cc:27027:69:   required from here 
>  /usr/include/c++/6.0.0/bits/stl_construct.h:75:7: error: 
>  'Curve::Curve()' is private within this context {
>  ::new(static_cast<void*>(__p)) _T1(std::forward<_Args>(__args)...);
>  }
>  
>  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 
>  In file included from ascxx/plot.h:10:0, from
>  ascxx/ascpy_wrap.cc:4058: ascxx/curve.h:15:2: note: declared
>  private here Curve(); ^~~~~ solvers/qrslv/qrslv.c: In function
>  'qrslv_get_default_parameters': solvers/qrslv/qrslv.c:2806:9:
>  warning: variable 'make_macros' set but not used
>  [-Wunused-but-set-variable] int32 make_macros = 0; ^~~~~~~~~~~ 
>  solvers/qrslv/qrslv.c:2804:18: warning: variable 'lo' set but not
>  used [-Wunused-but-set-variable] union parm_arg lo,hi,val; ^~ 
>  solvers/qrslv/qrslv.c:2803:18: warning: variable 'sys' set but not 
>  used [-Wunused-but-set-variable] qrslv_system_t sys = NULL; 
Upstream is very slow to reply, and I'm not able to fix this issue.
Can anyone help me please ?

Ascend: https://admin.fedoraproject.org/pkgdb/package/rpms/ascend/
Full log:
https://kojipkgs.fedoraproject.org//work/tasks/8211/13658211/build.log

Regards.
- -- 
- ---
Antonio Trande
mailto: sagitter 'at' fedoraproject 'dot' org
http://fedoraos.wordpress.com/
https://fedoraproject.org/wiki/User:Sagitter
GPG Key: 0x6CE6D08A
Check on https://keys.fedoraproject.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJXD2/0AAoJELbsjn1s5tCKoxUH/20r4JdqrNLOulC+rWfho8pt
kElvVQsD1UdtKRh3KXniDCzD6wnHn3ft5goK4873Z9Hklpvx0K/2SR0EZKiiCKPR
FDpMzt6GGyXff0HAq3jUF4O6RFoRqoBCn6hqXEYzO7C2hP2hwJTLOzJK8T3aEFk+
GNoB8/SIO7MgkZm5Qgs1YvNjnid48q27Lc87bme9uO4s4WiiXoYsmgahWfdPd2bF
SsFmUoIldkg9DWNmhpRca5GnIyqh5TLyEQC/eby6wE7Ij3o/4dJtYpwmlT2Fjvz3
xjIL196b2++isVQjFLuT0B20BPGcoEKOMMt1AHH/SCZRzig3mZkw6Thz7TvxcHg=
=Hrta
-----END PGP SIGNATURE-----

[Igor Gnatenko]

ascxx/curve.h:
class Curve : public Instanc{
    friend class std::vector<Curve>;
private:
    friend class Plot;
    explicit Curve(const Instanc &);
    Curve();
public:
    Curve(const Curve &);
    std::vector<double> x;
    std::vector<double> y;
    const std::string getLegend() const;

    /**
        Get the curve format string, as used by matplotlib.
        Documented here:
        http://matplotlib.sourceforge.net/api/axes_api.html#matplotlib.axes.Axes....

        (This value is not used by the Tcl/Tk GUI.)
    */
    const std::string getFormat() const;
};

ascxx/ascpy.i:
%ignore Curve::Curve();

%include "curve.h"


It should be ignored by SWIG, but looks like it's not...

----- Original Message -----
>  From: "Antonio Trande" <anto.trande(a)gmail.com&gt;
>  To: devel(a)lists.fedoraproject.org
>  Sent: Thursday, April 14, 2016 12:25:14 PM
>  Subject: [Ascend] Failed builds with GCC6
>  
>  -----BEGIN PGP SIGNED MESSAGE-----
>  Hash: SHA256
>  
>  Hi all,
>  
>  Ascend is not built yet on Fedora 24+ because of errors with GCC6:
>  
>  > ascxx/ascpy_wrap.cc:27027:69:   required from here
>  > /usr/include/c++/6.0.0/bits/stl_construct.h:75:7: error:
>  > 'Curve::Curve()' is private within this context {
>  > ::new(static_cast<void*>(__p)) _T1(std::forward<_Args>(__args)...);
>  > }
>  > 
>  > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  > In file included from ascxx/plot.h:10:0, from
>  > ascxx/ascpy_wrap.cc:4058: ascxx/curve.h:15:2: note: declared
>  > private here Curve(); ^~~~~ solvers/qrslv/qrslv.c: In function
>  > 'qrslv_get_default_parameters': solvers/qrslv/qrslv.c:2806:9:
>  > warning: variable 'make_macros' set but not used
>  > [-Wunused-but-set-variable] int32 make_macros = 0; ^~~~~~~~~~~
>  > solvers/qrslv/qrslv.c:2804:18: warning: variable 'lo' set but not
>  > used [-Wunused-but-set-variable] union parm_arg lo,hi,val; ^~
>  > solvers/qrslv/qrslv.c:2803:18: warning: variable 'sys' set but not
>  > used [-Wunused-but-set-variable] qrslv_system_t sys = NULL;
>  
>  Upstream is very slow to reply, and I'm not able to fix this issue.
>  Can anyone help me please ?
>  
>  Ascend: https://admin.fedoraproject.org/pkgdb/package/rpms/ascend/
>  Full log:
>  https://kojipkgs.fedoraproject.org//work/tasks/8211/13658211/build.log
>  
>  Regards.
>  - --
>  - ---
>  Antonio Trande
>  mailto: sagitter 'at' fedoraproject 'dot' org
>  http://fedoraos.wordpress.com/
>  https://fedoraproject.org/wiki/User:Sagitter
>  GPG Key: 0x6CE6D08A
>  Check on https://keys.fedoraproject.org/
> >  -----BEGIN PGP SIGNATURE-----
> >  Version: GnuPG v2
> >  
> >  iQEcBAEBCAAGBQJXD2/0AAoJELbsjn1s5tCKoxUH/20r4JdqrNLOulC+rWfho8pt
> >  kElvVQsD1UdtKRh3KXniDCzD6wnHn3ft5goK4873Z9Hklpvx0K/2SR0EZKiiCKPR
> >  FDpMzt6GGyXff0HAq3jUF4O6RFoRqoBCn6hqXEYzO7C2hP2hwJTLOzJK8T3aEFk+
> >  GNoB8/SIO7MgkZm5Qgs1YvNjnid48q27Lc87bme9uO4s4WiiXoYsmgahWfdPd2bF
> >  SsFmUoIldkg9DWNmhpRca5GnIyqh5TLyEQC/eby6wE7Ij3o/4dJtYpwmlT2Fjvz3
> >  xjIL196b2++isVQjFLuT0B20BPGcoEKOMMt1AHH/SCZRzig3mZkw6Thz7TvxcHg=
> >  =Hrta
> >  -----END PGP SIGNATURE----- 
>  --
>  devel mailing list
>  devel(a)lists.fedoraproject.org
>  http://lists.fedoraproject.org/admin/lists/[e-mail]
>   
-- 
-Igor Gnatenko

[Jonathan Wakely]

On 14/04/16 06:34 -0400, Igor Gnatenko wrote:
> ascxx/curve.h:
> class Curve : public Instanc{
>     friend class std::vector<Curve>;
> private:
>     friend class Plot;
>     explicit Curve(const Instanc &);
>     Curve();
> public:
>     Curve(const Curve &);
>     std::vector<double> x;
>     std::vector<double> y;
>     const std::string getLegend() const;
>
>     /**
>         Get the curve format string, as used by matplotlib.
>         Documented here:
>         http://matplotlib.sourceforge.net/api/axes_api.html#matplotlib.axes.Axes....
>
>         (This value is not used by the Tcl/Tk GUI.)
>     */
>     const std::string getFormat() const;
> };
>
> ascxx/ascpy.i:
> %ignore Curve::Curve();
>
> %include "curve.h"
>
>
> It should be ignored by SWIG, but looks like it's not... 
I don't think that's the problem.

In C++98 constructing std::vector<X> v(1); would invoke X's default
constructor in the caller's context, so if the default constructor is
private then the caller must be a member or friend of X.

In C++11 the default constructor will be invoked deep inside
std::vector, or one of its helper functions.

The code is basically invalid in C++11. It should either make the
default constructor public (the simplest fix), or change how the
vector is constructed (which seems to come from Swig, so might be
difficult).

[Jonathan Wakely]

On 14/04/16 15:42 +0100, Jonathan Wakely wrote:
> On 14/04/16 06:34 -0400, Igor Gnatenko wrote:
> >ascxx/curve.h:
> >class Curve : public Instanc{
> >   friend class std::vector<Curve>;
> >private:
> >   friend class Plot;
> >   explicit Curve(const Instanc &);
> >   Curve();
> >public:
> >   Curve(const Curve &);
> >   std::vector<double> x;
> >   std::vector<double> y;
> >   const std::string getLegend() const;
> >
> >   /**
> >       Get the curve format string, as used by matplotlib.
> >       Documented here:
> >       http://matplotlib.sourceforge.net/api/axes_api.html#matplotlib.axes.Axes....
> >
> >       (This value is not used by the Tcl/Tk GUI.)
> >   */
> >   const std::string getFormat() const;
> >};
> >
> >ascxx/ascpy.i:
> >%ignore Curve::Curve();
> >
> >%include "curve.h"
> >
> >
> >It should be ignored by SWIG, but looks like it's not...
>
> I don't think that's the problem.
>
> In C++98 constructing std::vector<X> v(1); would invoke X's default
> constructor in the caller's context, so if the default constructor is
> private then the caller must be a member or friend of X.
>
> In C++11 the default constructor will be invoked deep inside
> std::vector, or one of its helper functions.
>
> The code is basically invalid in C++11. It should either make the
> default constructor public (the simplest fix), or change how the
> vector is constructed (which seems to come from Swig, so might be
> difficult). 
Having managed to do a mock build (very slow wifi in the building I'm
in now) I see the error comes from this line, where arg1 is
vector<Curve>::size_type:

      result = (std::vector< Curve > *)new std::vector< Curve >(arg1);

Which is exactly what I guessed. That is not valid C++11 if the Curve
default constructor is private.

[Jonathan Wakely]

On 14/04/16 15:47 +0100, Jonathan Wakely wrote:
> On 14/04/16 15:42 +0100, Jonathan Wakely wrote:
> >On 14/04/16 06:34 -0400, Igor Gnatenko wrote:
> >>ascxx/curve.h:
> >>class Curve : public Instanc{
> >>  friend class std::vector<Curve>;
> >>private:
> >>  friend class Plot;
> >>  explicit Curve(const Instanc &);
> >>  Curve();
> >>public:
> >>  Curve(const Curve &);
> >>  std::vector<double> x;
> >>  std::vector<double> y;
> >>  const std::string getLegend() const;
> >>
> >>  /**
> >>      Get the curve format string, as used by matplotlib.
> >>      Documented here:
> >>     
> http://matplotlib.sourceforge.net/api/axes_api.html#matplotlib.axes.Axes....
> >>
> >>      (This value is not used by the Tcl/Tk GUI.)
> >>  */
> >>  const std::string getFormat() const;
> >>};
> >>
> >>ascxx/ascpy.i:
> >>%ignore Curve::Curve();
> >>
> >>%include "curve.h"
> >>
> >>
> >>It should be ignored by SWIG, but looks like it's not...
> >
> >I don't think that's the problem.
> >
> >In C++98 constructing std::vector<X> v(1); would invoke X's default
> >constructor in the caller's context, so if the default constructor is
> >private then the caller must be a member or friend of X.
> >
> >In C++11 the default constructor will be invoked deep inside
> >std::vector, or one of its helper functions.
> >
> >The code is basically invalid in C++11. It should either make the
> >default constructor public (the simplest fix), or change how the
> >vector is constructed (which seems to come from Swig, so might be
> >difficult).
>
> Having managed to do a mock build (very slow wifi in the building I'm
> in now) I see the error comes from this line, where arg1 is
> vector<Curve>::size_type:
>
>      result = (std::vector< Curve > *)new std::vector< Curve >(arg1);
>
> Which is exactly what I guessed. That is not valid C++11 if the Curve
> default constructor is private. 
I can also confirm that making the Curve default constructor public
allows the build to complete.

[Antonio Trande]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 04/14/2016 04:52 PM, Jonathan Wakely wrote:
>  On 14/04/16 15:47 +0100, Jonathan Wakely wrote:
> > On 14/04/16 15:42 +0100, Jonathan Wakely wrote:
> >> On 14/04/16 06:34 -0400, Igor Gnatenko wrote:
> >>> ascxx/curve.h: class Curve : public Instanc{ friend class
> >>> std::vector<Curve>; private: friend class Plot; explicit
> >>> Curve(const Instanc &); Curve(); public: Curve(const Curve
> >>> &); std::vector<double> x; std::vector<double> y; const
> >>> std::string getLegend() const;
> >>> 
> >>> /** Get the curve format string, as used by matplotlib. 
> >>> Documented here:
> >>> 
> >>>
> http://matplotlib.sourceforge.net/api/axes_api.html#matplotlib.axes.Axes....
> >>>
> >>>
> >>>
> >>>  
(This value is not used by the Tcl/Tk GUI.)
> >>> */ const std::string getFormat() const; };
> >>> 
> >>> ascxx/ascpy.i: %ignore Curve::Curve();
> >>> 
> >>> %include "curve.h"
> >>> 
> >>> 
> >>> It should be ignored by SWIG, but looks like it's not...
> >> 
> >> I don't think that's the problem.
> >> 
> >> In C++98 constructing std::vector<X> v(1); would invoke X's
> >> default constructor in the caller's context, so if the default
> >> constructor is private then the caller must be a member or
> >> friend of X.
> >> 
> >> In C++11 the default constructor will be invoked deep inside 
> >> std::vector, or one of its helper functions.
> >> 
> >> The code is basically invalid in C++11. It should either make
> >> the default constructor public (the simplest fix), or change
> >> how the vector is constructed (which seems to come from Swig,
> >> so might be difficult).
> > 
> > Having managed to do a mock build (very slow wifi in the building
> > I'm in now) I see the error comes from this line, where arg1 is 
> > vector<Curve>::size_type:
> > 
> > result = (std::vector< Curve > *)new std::vector< Curve >(arg1);
> > 
> > Which is exactly what I guessed. That is not valid C++11 if the
> > Curve default constructor is private.
>  
>  I can also confirm that making the Curve default constructor
>  public allows the build to complete.
>  
>  -- 
Ehm ...

How exactly?
Thanks for yours replies.

- -- 
- ---
Antonio Trande
mailto: sagitter 'at' fedoraproject 'dot' org
http://fedoraos.wordpress.com/
https://fedoraproject.org/wiki/User:Sagitter
GPG Key: 0x6CE6D08A
Check on https://keys.fedoraproject.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJXD8V7AAoJELbsjn1s5tCKeHsH/j1kCMlBjMChdpPUzzlHbYuP
+1f5S7bjXHStqM8FbsfJTu3xxwnd8N2gHgUKmsCFuBz08UrWVHqpe1lr8/MIIrW+
dWUUg0zuk4bFPlVGL9dmTCc2aZWTX6V2GMT2hCsEmXGLHb/ifST+stC84ANOckSv
QfvTW0bIVCOa25GPqHZbLrSWovwT0fE4bVytlc6OPC5ep6qbGKdbBeysvSaTEQis
1i35zOd/0DUslt1vqEUiBZSrN7FKMo3rM3hvQvBlurHAgI8GeohnjaJ6av2sRwmB
U1dIaMmpVLDlHwPuSmRdBNKn/w2tTskmWVmC9M9084B8BIoXKXHGrKGBQqGtPkE=
=nnq+
-----END PGP SIGNATURE-----

[Jonathan Wakely]

On 14/04/16 18:29 +0200, Antonio Trande wrote:
> > I can also confirm that making the Curve default constructor
> > public allows the build to complete.
> >
> > --
>
> Ehm ...
>
> How exactly?
> Thanks for yours replies. 
As in this attachment (done by hand, not from the sources in the repo,
because pkgs.fedoraproject.org is down at the moment).

[Antonio Trande]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 04/15/2016 04:48 PM, Jonathan Wakely wrote:
>  On 14/04/16 18:29 +0200, Antonio Trande wrote:
> >> I can also confirm that making the Curve default constructor 
> >> public allows the build to complete.
> >> 
> >> --
> > 
> > Ehm ...
> > 
> > How exactly? Thanks for yours replies.
>  
>  As in this attachment (done by hand, not from the sources in the
>  repo, because pkgs.fedoraproject.org is down at the moment).
>  
>   
Thank you a lot Jonathan.
- -- 
- ---
Antonio Trande
mailto: sagitter 'at' fedoraproject 'dot' org
http://fedoraos.wordpress.com/
https://fedoraproject.org/wiki/User:Sagitter
GPG Key: 0x6CE6D08A
Check on https://keys.fedoraproject.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJXERM2AAoJELbsjn1s5tCKhcgIAM+GYa8bryfiyvPbofOc0ia6
g8enqhahsc6sSdw3LElyMu7TioNjN9LIEV+6vGPYz06rh63k4WmNkBtXlRLEzCRa
RER2AwWZzL/y9nLadBZWQtiHlJFw6WdcRxBMa1JEjuYkD96w7J7MRUrwOoJImMXa
TCCIZTnTDocYyg/t8uuOLSfoqPXjK2jVeYj1fiQfdM6t0usvrorPhpA1aNgSF101
PD1Qr65ncf3ObgU6Ry5nT46iHSpc2QpCGgdHI5wXVaV2JGDTEwuSohtv4wzM5fIL
TDGu978F/KvRTqk/sYYqlPx71qJ3Icxn/Bn5qFCs3Pqeiu2/fDG3FaWfCTbYeqg=
=x94w
-----END PGP SIGNATURE-----