On 25.11.21 13:07, Felix Schwarz wrote:
Am 25.11.21 um 09:21 schrieb spike:
> I've been trying to contact Fedora's certbot SIG for a while now. Back then I
wanted to help fix some issues with python-dns-lexicon (which are resolved upstream now
and an update has trickled down to Fedora 35 with the latest release) but currently
I'm trying to find somebody who's willing to review
https://bugzilla.redhat.com/show_bug.cgi?id=2019398
You can always write to certbot-maintainers(a)fedoraproject.org but asking here worked as
well :-)
Ah, of course, the only thing I didn't try ;)
I'll check this later this week (please ping me if I don't -
lots of other stuff going on in my area unfortunately).
No worries, there's no rush. Very much appreciated!
There is one (minor) issue with certbot plugins though: As far as I
could see certbot upstream will rethink its approach to plugins and packaging extra
plugins for Fedora/EPEL often introduces additional dependencies. The latter caused quite
a bit of work when I tried to uplift certbot to Python 3 for EPEL 7 (I've completed
the builds locally but I still need to submit a few new review requests + coordinate
updates for many more packages).
Are you referring to
https://github.com/certbot/certbot/issues/6503? I followed the
discussion on github quite closely but the plugin I'd like to add does use
dns-lexicon.
Regarding EPEL 7: If the new plugin doesn't work on EPEL 7 (which is currently the
case due to a missing python3-acme and python3-dns-lexicon dependency, there's only
python2 versions in EPEL 7) we can always just ship certbot with the existing (built-in)
plugins. Since the new plugin is a separate rpm package it shouldn't add any
dependencies to certbot.
So I'm not super keen on adding new certbot plugins to Fedora but
if we have some additional hands that of course changes the equation :-)
Disclaimer: I'm also upstream for the plugin I'd like to add. So it'd be nice
to have (since I also use it on a regular basis) and there shouldn't be any extra
workload on you. Also happy to co-maintain python-dns-lexicon if that helps you out.
I've added a couple of patches upstream so I have a rough idea of how it works.
Thanks again for offering to do the review request.
Cheers!