"Add Icon To Git" GUI WIP

[Martin Sourada]

Hi all,

I've finished initial design of the gtk version of echo-icon-add script.
It is half working -- you can select where to add it to, what icon to
add (it checks the icon beforehand), it allows you to select component
(combo box) and branches (list supporting multi-selection) to which
you'd like to push it to and a checkbox to tick whether you also want to
push it to fedorahosted or do the changes only localy. However, the
"Add" button currently only prints the selected options to the terminal
(for testing purposes) instead of actually committing the icon to git.

It would be nice if you could test the so far implemented functionality
and report back if it's easy and effective to use and any bugs you run
into (as well as suggestions).

First you'll need git version of icon artist (I needed to do some coding
there to allow proper error and warnings handling during icon check):
http://mso.fedorapeople.org/packages/RPMS/noarch/ruby-icon-artist-0.1.93-...

Then save the attached script, chmod +x it and run it from terminal and
start testing. Note that you'll need a local copy of the echo git repo
(preferably in ~/Projects/echo-icon-theme/git), otherwise it refuses to
start ;-)

I also attach a screenshot.

Thanks,
Martin

[Martin Sourada]

On Fri, 2010-03-12 at 12:16 +0100, Martin Sourada wrote:
>  Hi all,
>  
>  I've finished initial design of the gtk version of echo-icon-add script.
>  It is half working -- you can select where to add it to, what icon to
>  add (it checks the icon beforehand), it allows you to select component
>  (combo box) and branches (list supporting multi-selection) to which
>  you'd like to push it to and a checkbox to tick whether you also want to
>  push it to fedorahosted or do the changes only localy. However, the
>  "Add" button currently only prints the selected options to the terminal
>  (for testing purposes) instead of actually committing the icon to git.
>  
>  It would be nice if you could test the so far implemented functionality
>  and report back if it's easy and effective to use and any bugs you run
>  into (as well as suggestions).
>  
>  First you'll need git version of icon artist (I needed to do some coding
>  there to allow proper error and warnings handling during icon check):
>
> http://mso.fedorapeople.org/packages/RPMS/noarch/ruby-icon-artist-0.1.93-...
>  
>  Then save the attached script, chmod +x it and run it from terminal and
>  start testing. Note that you'll need a local copy of the echo git repo
>  (preferably in ~/Projects/echo-icon-theme/git), otherwise it refuses to
>  start ;-)
>  
>  I also attach a screenshot. 
I've updated the script a little to save your git
repo path as well as
the push_to_git checkbox state. It saves the settings in
~/.config/echo-artist/settings.xml (xml because ruby has convenient
library to handle xml files :D). 

Testing and feedback welcome, updated script attached.

Thanks,
Martin

[Luya Tshimbalanga]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/15/2010 07:25 AM, Martin Sourada wrote:
>  On Fri, 2010-03-12 at 12:16 +0100, Martin Sourada wrote:
> > Hi all,
> >
> > I've finished initial design of the gtk version of echo-icon-add script.
> > It is half working -- you can select where to add it to, what icon to
> > add (it checks the icon beforehand), it allows you to select component
> > (combo box) and branches (list supporting multi-selection) to which
> > you'd like to push it to and a checkbox to tick whether you also want to
> > push it to fedorahosted or do the changes only localy. However, the
> > "Add" button currently only prints the selected options to the terminal
> > (for testing purposes) instead of actually committing the icon to git.
> >
> > It would be nice if you could test the so far implemented functionality
> > and report back if it's easy and effective to use and any bugs you run
> > into (as well as suggestions).
> >
> > First you'll need git version of icon artist (I needed to do some coding
> > there to allow proper error and warnings handling during icon check):
> >
http://mso.fedorapeople.org/packages/RPMS/noarch/ruby-icon-artist-0.1.93-...
> > 
Will that package be available on official repository?
>> Then save the attached script, chmod +x it and run it from terminal and
>> start testing. Note that you'll need a local copy of the echo git repo
>> (preferably in ~/Projects/echo-icon-theme/git), otherwise it refuses to
>> start ;-)
> > 
>> I also attach a screenshot.
> I've updated the script a little to save your git repo path as well as
> the push_to_git checkbox state. It saves the settings in
> ~/.config/echo-artist/settings.xml (xml because ruby has convenient
> library to handle xml files :D).
>
> Testing and feedback welcome, updated script attached.
>
> Thanks,
> Martin
Test was successful with the updated ruby-icon. The interface is fine as
it is until a new suggestion will come.  Adding --no-gui or  --tui
function to command might do the trick for users  who like tui. Well done.

- -- 
Luya Tshimbalanga
Graphic & Web Designer
E: luya(a)fedoraproject.org
W: http://www.thefinalzone.net
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
>
> iEYEARECAAYFAkufyW0ACgkQaS6HaNQHFTl9OgCfdAexAMbHCqVnGvvWQ78kLtlR
> A/UAn0T9y8B8TejrI+h3q2zeEhNM99uJ
> =KZKY
> -----END PGP SIGNATURE-----

[Martin Sourada]

On Tue, 2010-03-16 at 11:09 -0700, Luya Tshimbalanga wrote:
>  -----BEGIN PGP SIGNED MESSAGE-----
>  Hash: SHA1
>  
>  On 03/15/2010 07:25 AM, Martin Sourada wrote:
>
> http://mso.fedorapeople.org/packages/RPMS/noarch/ruby-icon-artist-0.1.93-...
>  >>
>  Will that package be available on official repository? 
It will, I haven't made
up my mind when though. At the very latest when
I decide to release 0.1.93.

>  Test was successful with the updated ruby-icon. The interface is fine
> as
>  it is until a new suggestion will come.  Adding --no-gui or  --tui
>  function to command might do the trick for users  who like tui. Well done.
>   
I've never thought about tui... I think the command line script that we
used up until now is good for CLI lovers. Besides, I don't have the
slightest idea if there is a good library for creating TUI in ruby, but
it's probably worth considering (I was more thinking about creating QT
version for KDE users though, hence the -gtk suffix).

Martin

[Martin Sourada]

On Mon, 2010-03-15 at 15:25 +0100, Martin Sourada wrote:
>  I've updated the script a little to save your git repo path as
> well as
>  the push_to_git checkbox state. It saves the settings in
>  ~/.config/echo-artist/settings.xml (xml because ruby has convenient
>  library to handle xml files :D). 
>  
>  Testing and feedback welcome, updated script attached.
>   
And another update. This time I added another dialogue that appears when
you click the "Add" button. It shows you which symlinks will be added to
the icon (during installing the icon theme via make install) and lets
you add more, if need (or remove if you made a typo. The "system"
symlinks, i.e. those that we got from icon-naming-utils, cannot be
removed). And lets you review the commit message and customize it if
needed (though in most cases, the default commit message is good
enough). This makes it function complete sans the actual adding of the
icon to git.

And again, this is still WIP so it does *not* actually commit the icon
and instead it prints the selected settings on terminal, so you can play
with it as much as you want without worrying about it breaking
something.

Comments and suggestions (regarding the GTK GUI and it's behaviour)
welcome. 

With the next iteration I'll most likely commit it to fedorahosted and
enable the committing instead of printing the settings on terminal.

Thanks,
Martin

[Martin Sourada]

On Mon, 2010-03-22 at 16:08 +0100, Martin Sourada wrote:
>  And another update. This time I added another dialogue that appears
> when
>  you click the "Add" button. It shows you which symlinks will be added to
>  the icon (during installing the icon theme via make install) and lets
>  you add more, if need (or remove if you made a typo. The "system"
>  symlinks, i.e. those that we got from icon-naming-utils, cannot be
>  removed). And lets you review the commit message and customize it if
>  needed (though in most cases, the default commit message is good
>  enough). This makes it function complete sans the actual adding of the
>  icon to git. 
Oops, I forgot to add: you'll need updated ruby-icon-artist
again...
Otherwise it will just crash instead of showing the dialogue. You can
get it at my fpo:
http://mso.fedorapeople.org/packages/RPMS/noarch/ruby-icon-artist-0.1.93-...

Martin