https://bugzilla.redhat.com/show_bug.cgi?id=1023960
Bug ID: 1023960 Summary: erlang-R16B-02.2.fc20 fails to build on secondary arches Product: Fedora Version: 20 Component: erlang Assignee: lemenkov@gmail.com Reporter: dan@danny.cz QA Contact: extras-qa@fedoraproject.org CC: erlang@lists.fedoraproject.org, lemenkov@gmail.com, rhbugs@n-dimensional.de Blocks: 467765 (ZedoraTracker)
erlang-R16B-02 fails to build on secondary arches, seen on ppc and s390, but I guess aarch64 would also fail.
from s390 build.log (http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1243484): ... gcc -Werror=return-type -O3 -fomit-frame-pointer -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -grecord-gcc-switches -m31 -march=z9-109 -mtune=z10 -fno-strict-aliasing -I/builddir/build/BUILD/otp_src_R16B02/erts/s390-ibm-linux-gnu -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -fno-tree-copyrename -D_GNU_SOURCE -DERTS_SMP -DHAVE_CONFIG_H -Wall -Wstrict-prototypes -Wmissing-prototypes -Wdeclaration-after-statement -DUSE_THREADS -D_THREAD_SAFE -D_REENTRANT -DPOSIX_THREADS -D_POSIX_THREAD_SAFE_FUNCTIONS -Is390-ibm-linux-gnu/opt/smp -Ibeam -Isys/unix -Isys/common -Is390-ibm-linux-gnu -Ipcre -Ihipe -I../include -I../include/s390-ibm-linux-gnu -I../include/internal -I../include/internal/s390-ibm-linux-gnu -c beam/erl_bif_info.c -o obj/s390-ibm-linux-gnu/opt/smp/erl_bif_info.o In file included from beam/erl_bif_info.c:30:0: beam/erl_bif_info.c: In function 'system_info_1': beam/erl_bif_info.c:2073:10: error: 'hipe_arch_name' undeclared (first use in this function) BIF_RET(hipe_arch_name); ^ beam/bif.h:118:28: note: in definition of macro 'BIF_RET' #define BIF_RET(x) return (x) ^ beam/erl_bif_info.c:2073:10: note: each undeclared identifier is reported only once for each function it appears in BIF_RET(hipe_arch_name); ^ beam/bif.h:118:28: note: in definition of macro 'BIF_RET' #define BIF_RET(x) return (x) ^ make[3]: Leaving directory `/builddir/build/BUILD/otp_src_R16B02/erts/emulator' make[3]: *** [obj/s390-ibm-linux-gnu/opt/smp/erl_bif_info.o] Error 1
from ppc build.log (http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=1483569): ... gcc -Werror=return-type -O3 -fomit-frame-pointer -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m32 -fno-strict-aliasing -I/builddir/build/BUILD/otp_src_R16B02/erts/powerpc-redhat-linux-gnu -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -fno-tree-copyrename -D_GNU_SOURCE -DERTS_SMP -DHAVE_CONFIG_H -Wall -Wstrict-prototypes -Wmissing-prototypes -Wdeclaration-after-statement -DUSE_THREADS -D_THREAD_SAFE -D_REENTRANT -DPOSIX_THREADS -D_POSIX_THREAD_SAFE_FUNCTIONS -Ipowerpc-redhat-linux-gnu/opt/smp -Ibeam -Isys/unix -Isys/common -Ipowerpc-redhat-linux-gnu -Ipcre -Ihipe -I../include -I../include/powerpc-redhat-linux-gnu -I../include/internal -I../include/internal/powerpc-redhat-linux-gnu -c beam/erl_bif_info.c -o obj/powerpc-redhat-linux-gnu/opt/smp/erl_bif_info.o In file included from beam/erl_bif_info.c:30:0: beam/erl_bif_info.c: In function 'system_info_1': hipe/hipe_ppc.h:63:24: error: 'am_powerpc' undeclared (first use in this function) #define hipe_arch_name am_powerpc ^ beam/bif.h:118:28: note: in definition of macro 'BIF_RET' #define BIF_RET(x) return (x) ^ beam/erl_bif_info.c:2073:10: note: in expansion of macro 'hipe_arch_name' BIF_RET(hipe_arch_name); ^ hipe/hipe_ppc.h:63:24: note: each undeclared identifier is reported only once for each function it appears in #define hipe_arch_name am_powerpc ^ beam/bif.h:118:28: note: in definition of macro 'BIF_RET' #define BIF_RET(x) return (x) ^ beam/erl_bif_info.c:2073:10: note: in expansion of macro 'hipe_arch_name' BIF_RET(hipe_arch_name); ^ make[3]: *** [obj/powerpc-redhat-linux-gnu/opt/smp/erl_bif_info.o] Error 1 make[3]: Leaving directory `/builddir/build/BUILD/otp_src_R16B02/erts/emulator'
Version-Release number of selected component (if applicable): erlang-R16B-02.2.fc20
proposed solution: diff --git a/erlang.spec b/erlang.spec index 1d4cbfd..50bbe68 100644 --- a/erlang.spec +++ b/erlang.spec @@ -966,9 +966,15 @@ rm -f lib/ssl/examples/certs/etc/erlangCA/index.txt.old
%build %ifarch sparcv9 sparc64 -CFLAGS="$RPM_OPT_FLAGS -mcpu=ultrasparc -fno-strict-aliasing" %configure --enable-shared-zlib --enable-sctp --enable-hipe +CFLAGS="$RPM_OPT_FLAGS -mcpu=ultrasparc -fno-strict-aliasing" \ %else -CFLAGS="$RPM_OPT_FLAGS -fno-strict-aliasing" %configure --enable-shared-zlib --enable-sctp --enable-hipe +CFLAGS="$RPM_OPT_FLAGS -fno-strict-aliasing" \ +%endif +%configure --enable-shared-zlib --enable-sctp \ +%ifnarch s390 s390x ppc + --enable-hipe +%else + %{nil} %endif
or maybe using %ifarch with a positive list like %{ix86} x86_64 %{arm} would be even better
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=467765 [Bug 467765] Fedora for System z (s390): Bug Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
--- Comment #1 from Dan Horák dan@danny.cz --- http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=1485226 is a scratch build with hipe enabled on ppc64 and disabled on ppc
my local test builds on s390 and s390x were successful with hipe disabled using the snippet from above
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
--- Comment #2 from Peter Lemenkov lemenkov@gmail.com --- (In reply to Dan Horák from comment #1)
http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=1485226 is a scratch build with hipe enabled on ppc64 and disabled on ppc
my local test builds on s390 and s390x were successful with hipe disabled using the snippet from above
Dan, could you please try the latest build:
http://koji.fedoraproject.org/koji/buildinfo?buildID=474347
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
--- Comment #3 from Dan Horák dan@danny.cz --- scratch builds started http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1244397 http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=1487519
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
--- Comment #4 from Peter Lemenkov lemenkov@gmail.com --- (In reply to Dan Horák from comment #3)
scratch builds started http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1244397 http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=1487519
Dan, I'm terribly terribly sorry but I've made a typo in the spec-file which disabled HiPE entirely. Could you please try with the latest build (in progress at the moment of writing):
http://koji.fedoraproject.org/koji/taskinfo?taskID=6111139
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
--- Comment #5 from Dan Horák dan@danny.cz --- (In reply to Peter Lemenkov from comment #4)
(In reply to Dan Horák from comment #3)
scratch builds started http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1244397 http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=1487519
Dan, I'm terribly terribly sorry but I've made a typo in the spec-file which disabled HiPE entirely. Could you please try with the latest build (in progress at the moment of writing):
no problem :-) I will start new scratch builds after this one finishes and let you know
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
--- Comment #6 from Dan Horák dan@danny.cz --- new scratch builds http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1244424 http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=1488408
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
--- Comment #7 from Dan Horák dan@danny.cz --- all ppc went OK, but s390 failed because now hipe is again unconditionally enabled, the snippet bellow fixes it
diff --git a/erlang.spec b/erlang.spec index 6c3b085..a850f27 100644 --- a/erlang.spec +++ b/erlang.spec @@ -22,8 +22,6 @@
%ifarch %{arm} %{ix86} x86_64 ppc %{power64} %global __with_hipe 1 -%else -%global __with_hipe 0 %endif
%global n_uvr %{name}-%{upstream_ver}-%{upstream_rel_for_rpm}
the semantics for the "inline condition" looks weird ...
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
--- Comment #8 from Peter Lemenkov lemenkov@gmail.com --- Ok, I think we've fixed that. Dan, could you please try it again with the latest packages.
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
--- Comment #9 from Dan Horák dan@danny.cz --- Peter, thanks for the changes, it must succeed now. The scratch builds are http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1252454 http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=1514758
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
--- Comment #10 from Dan Horák dan@danny.cz --- (In reply to Dan Horák from comment #9)
Peter, thanks for the changes, it must succeed now. The scratch builds are http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1252454 http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=1514758
and both succeeded, please do updates in all branches where R16B-02 should exist
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
--- Comment #11 from Peter Lemenkov lemenkov@gmail.com --- (In reply to Dan Horák from comment #10)
(In reply to Dan Horák from comment #9)
Peter, thanks for the changes, it must succeed now. The scratch builds are http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1252454 http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=1514758
and both succeeded, please do updates in all branches where R16B-02 should exist
Ok, good! I'll postpone updating F19/F20 until I resolve another one issue (return of ECC in Erlang).
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
--- Comment #12 from Dan Horák dan@danny.cz --- Peter, as I see the crypto stuff is not resolved yet, but missing erlang is causing us some troubles, could you please do the updates for F19/F20?
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
--- Comment #13 from Peter Lemenkov lemenkov@gmail.com --- (In reply to Dan Horák from comment #12)
Peter, as I see the crypto stuff is not resolved yet, but missing erlang is causing us some troubles, could you please do the updates for F19/F20?
Just give me a couple of days more - I'll try to fix it during this weekend. If I won't find a free time for that then I'll rebuild f19 and f20 as is.
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
--- Comment #14 from Dan Horák dan@danny.cz --- (In reply to Peter Lemenkov from comment #13)
(In reply to Dan Horák from comment #12)
Peter, as I see the crypto stuff is not resolved yet, but missing erlang is causing us some troubles, could you please do the updates for F19/F20?
Just give me a couple of days more - I'll try to fix it during this weekend. If I won't find a free time for that then I'll rebuild f19 and f20 as is.
works for me, thanks
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- erlang-R16B-02.7.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/erlang-R16B-02.7.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- erlang-R16B-02.7.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/erlang-R16B-02.7.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- erlang-R16B-02.7.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/erlang-R16B-02.7.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- Package erlang-R16B-02.7.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing erlang-R16B-02.7.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-22163/erlang-R16B-02.7.f... then log in and leave karma (feedback).
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
Fedora Blocker Bugs Application blockerbugs@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dan@danny.cz Blocks| |980657 | |(F20FinalFreezeException,Fi | |nalFreezeException)
--- Comment #19 from Fedora Blocker Bugs Application blockerbugs@fedoraproject.org --- Proposed as a Freeze Exception for 20-final by Fedora user sharkcz using the blocker tracking app because:
Erlang R16B02 was FTBFS on secondary arches
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=980657 [Bug 980657] Fedora 20 Final freeze exception bug tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
Adam Williamson awilliam@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |awilliam@redhat.com Whiteboard| |AcceptedFreezeException
--- Comment #20 from Adam Williamson awilliam@redhat.com --- Discussed at 2013-12-02 freeze exception review meeting: http://meetbot.fedoraproject.org/fedora-blocker-review/2013-12-02/f20-blocke... . Accepted as a freeze exception issue as a significant bug for secondary arches whose fix is unlikely to break anything important for primary arches.
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |erlang-R16B-02.7.fc20 Resolution|--- |ERRATA Last Closed| |2013-12-05 07:14:19
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- erlang-R16B-02.7.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1023960
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|erlang-R16B-02.7.fc20 |erlang-R16B-02.7.fc19
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- erlang-R16B-02.7.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
erlang@lists.fedoraproject.org