[Bug 1315046] New: Incorrect ExecStop= directive in ejabberd.service

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315046

            Bug ID: 1315046
           Summary: Incorrect ExecStop= directive in ejabberd.service
           Product: Fedora
           Version: 23
         Component: ejabberd
          Assignee: lemenkov(a)gmail.com
          Reporter: rbarlow(a)redhat.com
        QA Contact: extras-qa(a)fedoraproject.org
                CC: arcfi(a)aetera.net, erlang(a)lists.fedoraproject.org,
                    extras-qa(a)fedoraproject.org, jeremy(a)jcline.org,
                    lemenkov(a)gmail.com, martin(a)laptop.org,
                    rbarlow(a)redhat.com
        Depends On: 1314753



+++ This bug was initially created as a clone of Bug #1314753 +++

Description of problem:
Incorrect ExecStop= directive in ejabberd.service resulting in unit stop
failing.
The correct directive is:
ExecStop=/usr/bin/bash /usr/bin/ejabberdctl stop

Version-Release number of selected component (if applicable):
ejabberd-14.07-6.fc22.x86_64

How reproducible:
Always.

Steps to Reproduce:
1. systemctl stop ejabberd.service
2. systemctl status ejabberd.service

Actual results:
systemd[1]: Stopping A distributed, fault-tolerant Jabber/XMPP server...
ejabberdctl[3067]: Refusing to render service to dead parents.
systemd[1]: ejabberd.service: Control process exited, code=exited status=127
systemd[1]: Stopped A distributed, fault-tolerant Jabber/XMPP server.
systemd[1]: ejabberd.service: Unit entered failed state.
systemd[1]: ejabberd.service: Failed with result 'exit-code'.

Expected results:
# grep ExecStop= /usr/lib/systemd/system/ejabberd.service 
ExecStop=/usr/bin/bash /usr/bin/ejabberdctl stop

--- Additional comment from Randy Barlow on 2016-03-06 01:48:08 EST ---

This is easy to fix in Fedora 24, but unfortunately the SRPM does not build
anymore on F22 or F23 with this build error:

Compiling
/builddir/build/BUILD/ejabberd-14.07/deps/jiffy/c_src/double-conversion/bignum.cc
/builddir/build/BUILD/ejabberd-14.07/deps/jiffy/c_src/double-conversion/bignum.cc:
In member function 'void
double_conversion::Bignum::AssignDecimalString(double_conversion::Vector<const
char>)':
/builddir/build/BUILD/ejabberd-14.07/deps/jiffy/c_src/double-conversion/bignum.cc:101:6:
error: assuming signed overflow does not occur when assuming that (X + c) < X
is always false [-Werror=strict-overflow]
 void Bignum::AssignDecimalString(Vector<const char> value) {
      ^
cc1plus: all warnings being treated as errors

I will have an F24 fix out shortly, but I don't have time to investigate these
build failures this weekend.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1314753
[Bug 1314753] Incorrect ExecStop= directive in ejabberd.service
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1315046] Incorrect ExecStop= directive in ejabberd.service

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315046

Randy Barlow <rbarlow(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |1315047




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1315047
[Bug 1315047] Incorrect ExecStop= directive in ejabberd.service
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1315046] Incorrect ExecStop= directive in ejabberd.service

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315046
Bug 1315046 depends on bug 1314753, which changed state.

Bug 1314753 Summary: Incorrect ExecStop= directive in ejabberd.service
https://bugzilla.redhat.com/show_bug.cgi?id=1314753

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1315046] Incorrect ExecStop= directive in ejabberd.service

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315046
Bug 1315046 depends on bug 1315047, which changed state.

Bug 1315047 Summary: Incorrect ExecStop= directive in ejabberd.service
https://bugzilla.redhat.com/show_bug.cgi?id=1315047

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |EOL



-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1315046] Incorrect ExecStop= directive in ejabberd.service

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315046



--- Comment #1 from ArcFi <arcfi(a)aetera.net&gt; ---
Fixed in ejabberd-16.01-5.fc24.x86_64.
Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1315046] Incorrect ExecStop= directive in ejabberd.service

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315046

Peter Lemenkov <lemenkov(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
   Fixed In Version|                            |ejabberd-16.01-5.fc24.x86_6
                   |                            |4
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2016-07-07 10:23:45



-- 
You are receiving this mail because:
You are on the CC list for the bug.