#129: Visually distinguish meetings in list view -------------------------+------------------------- Reporter: lbrabec | Owner: Type: enhancement | Status: new Priority: major | Milestone: Future Component: fedocal | Version: development Keywords: | -------------------------+------------------------- Current design of list view is somehow confusing - at first sight, one can't tell where meeting description starts and where it ends. Some kind of separator between meetings would be nice.
Also, since meeting detail is now pretty polished and there is 'blue box', it could be more readable if just part of meeting description was shown and rest of it would be accessible through click.
I did quickfix for this, see attachment for patch.
#129: Visually distinguish meetings in list view --------------------------+------------------------- Reporter: lbrabec | Owner: Type: enhancement | Status: new Priority: major | Milestone: Future Component: fedocal | Version: development Resolution: | Keywords: --------------------------+-------------------------
Comment (by pingou):
This patch fails to apply for me on both the master and the tests branch
{{{ Applying: listview quickfix /home/pingou/repos/gitrepo/fedocal/.git/rebase-apply/patch:79: trailing whitespace. <td>{% autoescape off%} {{ meeting.meeting_information }} /home/pingou/repos/gitrepo/fedocal/.git/rebase-apply/patch:81: trailing whitespace. href="{{ url_for('view_meeting', error: patch failed: fedocal/__init__.py:439 error: fedocal/__init__.py: patch does not apply Patch failed at 0001 listview quickfix The copy of the patch that failed is found in: /home/pingou/repos/gitrepo/fedocal/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". }}}
#129: Visually distinguish meetings in list view --------------------------+------------------------- Reporter: lbrabec | Owner: Type: enhancement | Status: new Priority: major | Milestone: Future Component: fedocal | Version: development Resolution: | Keywords: --------------------------+-------------------------
Comment (by pingou):
Also, for this part: {{{ + for i in range(len(meetings)): + lead_par = meetings[i].meeting_information[:100] + meetings[i].meeting_information = lead_par + "..." }}}
I think we should be able to do this directly in the template rather than iterating through all the meetings in the controller
#129: Visually distinguish meetings in list view --------------------------+------------------------- Reporter: lbrabec | Owner: Type: enhancement | Status: new Priority: major | Milestone: Future Component: fedocal | Version: development Resolution: | Keywords: --------------------------+-------------------------
Comment (by lbrabec):
Ok, again, diff against fedorahosted repo. Tried, works for me.
#129: Visually distinguish meetings in list view --------------------------+------------------------- Reporter: lbrabec | Owner: Type: enhancement | Status: new Priority: major | Milestone: Future Component: fedocal | Version: development Resolution: | Keywords: --------------------------+-------------------------
Comment (by lbrabec):
Yes, the lead paragraph part should be in model. However this was just preview meant only for showing what I had in mind not a patch for production.
Also, first X characters of description can cut text in the middle of word. Is it problem? Nicer option could be first several words or something like that.
#129: Visually distinguish meetings in list view --------------------------+------------------------- Reporter: lbrabec | Owner: Type: enhancement | Status: new Priority: major | Milestone: Future Component: fedocal | Version: development Resolution: | Keywords: --------------------------+-------------------------
Comment (by pingou):
One option might be to create a new jinja filter and maybe https://docs.python.org/2/library/textwrap.html can help getting the first X characters correctly
#129: Visually distinguish meetings in list view --------------------------+------------------------- Reporter: lbrabec | Owner: Type: enhancement | Status: new Priority: major | Milestone: Future Component: fedocal | Version: development Resolution: | Keywords: --------------------------+-------------------------
Comment (by lbrabec):
I like the jinja filter option.
Textwrap module looks pretty good, something like this: {{{ '\n'.join(textwrap.wrap(a)[:3])+"..." }}} could do the work (returns first 3 lines).
What about 'show more' link after the lead paragraph, is it needed?
#129: Visually distinguish meetings in list view --------------------------+------------------------- Reporter: lbrabec | Owner: Type: enhancement | Status: new Priority: major | Milestone: Future Component: fedocal | Version: development Resolution: | Keywords: --------------------------+-------------------------
Comment (by pingou):
I was wondering about it, I guess it's not really since the regular link is just in the next cell
#129: Visually distinguish meetings in list view --------------------------+------------------------- Reporter: lbrabec | Owner: Type: enhancement | Status: new Priority: major | Milestone: Future Component: fedocal | Version: development Resolution: | Keywords: --------------------------+-------------------------
Comment (by lbrabec):
Yep, that's my argument against it too, but I'm not sure if it is clear enough that the 'blue box' is clickable link. I'll ask around what others think.
#129: Visually distinguish meetings in list view --------------------------+------------------------- Reporter: lbrabec | Owner: Type: enhancement | Status: new Priority: major | Milestone: Future Component: fedocal | Version: development Resolution: | Keywords: --------------------------+-------------------------
Comment (by pingou):
It's the same box as in the calendar view, but sure let's check if it is clear enough
#129: Visually distinguish meetings in list view --------------------------+------------------------- Reporter: lbrabec | Owner: Type: enhancement | Status: new Priority: major | Milestone: Future Component: fedocal | Version: development Resolution: | Keywords: --------------------------+-------------------------
Comment (by lbrabec):
The feedback is that 'show more' or something like little arrow or a pictogram (like wiki uses for external links) at the end of lead paragraph would be better than only clickable 'blue box'.
Also kparal suggested that about 8 lines of text would be best (enough info from it).
#129: Visually distinguish meetings in list view --------------------------+------------------------- Reporter: lbrabec | Owner: Type: enhancement | Status: new Priority: major | Milestone: Future Component: fedocal | Version: development Resolution: | Keywords: --------------------------+------------------------- Changes (by kparal):
* cc: kparal@… (added)
#129: Visually distinguish meetings in list view --------------------------+------------------------- Reporter: lbrabec | Owner: Type: enhancement | Status: new Priority: major | Milestone: Future Component: fedocal | Version: development Resolution: | Keywords: --------------------------+-------------------------
Comment (by pingou):
8 lines seems a bit much to me but ok, we can always tweak that later.
Let's go for a small arrow/pictogram (with the title `show more`) then :)
#129: Visually distinguish meetings in list view --------------------------+------------------------- Reporter: lbrabec | Owner: Type: enhancement | Status: new Priority: major | Milestone: Future Component: fedocal | Version: development Resolution: | Keywords: --------------------------+-------------------------
Comment (by kparal):
I'm not sure what "title" means (is that a tooltip?), but I'd rather have that text visible. A single small expander icon can be too hard to spot.
So something like "show more >>" is best, IMO.
#129: Visually distinguish meetings in list view --------------------------+------------------------- Reporter: lbrabec | Owner: Type: enhancement | Status: new Priority: major | Milestone: Future Component: fedocal | Version: development Resolution: | Keywords: --------------------------+-------------------------
Comment (by pingou):
Yes the title is the tooltip displayed when one hover over a link
#129: Visually distinguish meetings in list view --------------------------+------------------------- Reporter: lbrabec | Owner: Type: enhancement | Status: new Priority: major | Milestone: Future Component: fedocal | Version: development Resolution: | Keywords: --------------------------+-------------------------
Comment (by pingou):
So where do we stand on this one?
#129: Visually distinguish meetings in list view --------------------------+------------------------- Reporter: lbrabec | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.10 Component: fedocal | Version: development Resolution: | Keywords: --------------------------+------------------------- Changes (by pingou):
* milestone: Future => 0.10
#129: Visually distinguish meetings in list view --------------------------+------------------------- Reporter: lbrabec | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.10 Component: fedocal | Version: development Resolution: | Keywords: --------------------------+-------------------------
Comment (by kparal):
Replying to [comment:15 pingou]:
So where do we stand on this one?
Sorry, are we waiting on my feedback, or lbrabec's new patch, or something else? Not sure :)
#129: Visually distinguish meetings in list view --------------------------+------------------------- Reporter: lbrabec | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.10 Component: fedocal | Version: development Resolution: | Keywords: --------------------------+-------------------------
Comment (by pingou):
lbrabec could you rebase your patch?
#129: Visually distinguish meetings in list view --------------------------+------------------------- Reporter: lbrabec | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.10 Component: fedocal | Version: development Resolution: | Keywords: --------------------------+-------------------------
Comment (by pingou):
Ok I took the patch from lbrabec and based on it finished this RFE: https://github.com/fedora-infra/fedocal/pull/142
See screen-shot attached.
#129: Visually distinguish meetings in list view --------------------------+------------------------- Reporter: lbrabec | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.10 Component: fedocal | Version: development Resolution: fixed | Keywords: --------------------------+------------------------- Changes (by pingou):
* status: new => closed * resolution: => fixed
Comment:
Merged
fedocal-devel@lists.fedorahosted.org
-
fedocal