Review Check

[Sourav Basu]

Hello all,

I got stuck at a check in a review;

* Package consistently uses macro is (instead of hard-coded directory names)*
I cannot understand what it means. Can anyone help me out?
This was a manual check left after I ran fedora-review.

Regards,

Sourav

[Ankur Sinha]

Hi Sourav,

On Fri, 2012-10-26 at 08:54 -0700, Sourav Basu wrote:
> Package consistently uses macro is (instead of hard-coded directory
>
> names)*

It implies that you make use of the rpm macros for directories as given
here[1] instead of using the actual directories themselves. For
instance, we use

%{__bindir} and _not_ the expansion: /usr/bin

These macros may evaluate differently on different fedora and epel
versions (read the link). The idea is simple:

All binaries go into %{__bindir}, _however_ it's defined by rpm. If any
of these locations are modified (say, by the fedora packaging
committee), all that is required is a rebuild.

[1] https://fedoraproject.org/wiki/Packaging:RPMMacros