On Sun, Feb 10, 2013 at 04:09:20PM -0500, David Malcolm wrote:
On Sat, 2013-02-09 at 18:48 -0500, Paul Tagliamonte wrote:
> Hello, Firehosen,
>
> I've just hacked a basic wrapper around one of the most used Debian
> tools; Lintian. It's currently brokenish (need to work out some stray
> Nones in the schema), but should be good to go shortly. Check it out on
> GitHub[1]
Nice. I started making a list of projects using Firehose in the
README.rst and added a link.
Sweet. Hopefully this turns more into a set of Debian tool wrappers (or
perhaps not even that, evetually)
> While wrapping it, I also added some helper functions which could use
> some feedback. They're very Debian-centric, but could be simply adapted
> for Firehose proper if we decided on that.
Those would be:
https://github.com/paultag/storz/blob/master/storz/deb.py
right?
Yeah, that's right! Also `wrapper', there's some stuff in there to ease
some of the Firehose tree creation, but nothing major.
If every Debian project using Firehose is going to use code like that,
then it would makes sense to slurp that into Firehose itself, but I
don't want to force dependencies on people using Firehose that aren't
using the deb functionality (I see you have a couple of "from debian"
imports, which don't exist on this box).
Aye, I assumed so, so saved you the pull request :)
So you could put these into a new firehose/debian.py, or
alternatively
put the imports into *method scope* within firehose/report.py, and have
a couple of DebianBinary.from_deb() and DebianSource.from_dsc()
classmethods. (If you also want to slurp in the exception classes into
firehose you'd want to rename them also, naturally)
Not a bad idea. I'll take a look on how to get that stuff upstream'd
ASAP.
Cheers
Dave
_______________________________________________
firehose-devel mailing list
firehose-devel(a)lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/firehose-devel
Cheers,
Paul
--
.''`. Paul Tagliamonte <paultag(a)debian.org>
: :' : Proud Debian Developer
`. `'` 4096R / 8F04 9AD8 2C92 066C 7352 D28A 7B58 5B30 807C 2A87
`-
http://people.debian.org/~paultag