[Bug 454078] Review Request: khmeros-fonts - Khmer free/libre font set created by Danh Hong of the Cambodian Open Institute
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: khmeros-fonts - Khmer free/libre font set created by Danh Hong of the Cambodian Open Institute
https://bugzilla.redhat.com/show_bug.cgi?id=454078
nicolas.mailhot(a)laposte.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |NEEDINFO
Flag| |needinfo?(mnowak(a)redhat.com)
------- Additional Comments From nicolas.mailhot(a)laposte.net 2008-07-04 16:58 EST -------
Anyway:
1. please take care of the licensing (blocker)
2. try to split the file (nice-to-have)
3. work a bit on the package description (as suggested, or if you have better ideas)
Then I'll approve the package (don't wait before I leave for summer vacations)
Thank you for packaging a new font!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
15 years, 9 months
[Bug 454078] Review Request: khmeros-fonts - Khmer free/libre font set created by Danh Hong of the Cambodian Open Institute
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: khmeros-fonts - Khmer free/libre font set created by Danh Hong of the Cambodian Open Institute
https://bugzilla.redhat.com/show_bug.cgi?id=454078
------- Additional Comments From nicolas.mailhot(a)laposte.net 2008-07-04 16:52 EST -------
Proposed spec changes:
1. re-word description a little
2. macroify version in archivename
3. kill the external non-upstream-provided license file
(even if you kept it it's not necessary to install it this way, %doc takes care
of a lot of things)
--- khmeros-fonts.spec 2008-07-04 15:40:50.000000000 +0200
+++ khmeros-fonts-nim.spec 2008-07-04 22:49:39.000000000 +0200
@@ -1,27 +1,26 @@
%define fontname khmeros
%define fontdir %{_datadir}/fonts/%{fontname}
-%define archivename All_KhmerOS_5.0
+%define archivename All_KhmerOS_%{version}
Name: %{fontname}-fonts
Version: 5.0
Release: 1%{?dist}
-Summary: Khmer free/libre font set created by Danh Hong of the Cambodian
Open Institute
+Summary: Khmer font set created by Danh Hong of the Cambodian Open Institute
Group: User Interface/X
License: LGPLv2+
URL: http://www.khmeros.info/drupal/?q=en/download/fonts
Source0: http://downloads.sourceforge.net/khmer/%{archivename}.zip
-Source1: COPYRIGHT.Fedora
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildArch: noarch
%description
-All font include Khmer and Latin alphabets, and they have equivalent sizes
-for Khmer and English alphabets, so that when texts mix both it is not
-necessary to have different size points of the text for each language.
-This makes localization possible. Khmer OS System is our system font. It
-is hinted, so that it can be used and clearly understood in small sizes.
+The Khmer OS fonts include Khmer and Latin alphabets, and they have equivalent
+sizes for Khmer and English alphabets, so that when texts mix both it is not
+necessary to have different point sizes for the text in each language.
+
+They were created by Danh Hong of the Cambodian Open Institute.
%prep
@@ -36,8 +35,6 @@
install -dm 755 %{buildroot}%{fontdir}
install -pm 644 *.ttf %{buildroot}%{fontdir}
-install -dm 755 %{buildroot}%{_datadir}/doc/%{name}
-install -pm 644 %{SOURCE1} %{buildroot}%{_datadir}/doc/%{name}
%clean
@@ -59,7 +56,6 @@
%defattr(644,root,root,755)
%dir %{fontdir}/
%{fontdir}/*.ttf
-%doc %{_datadir}/doc/%{name}/COPYRIGHT.Fedora
%changelog
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
15 years, 9 months
[Bug 454078] Review Request: khmeros-fonts - Khmer free/libre font set created by Danh Hong of the Cambodian Open Institute
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: khmeros-fonts - Khmer free/libre font set created by Danh Hong of the Cambodian Open Institute
https://bugzilla.redhat.com/show_bug.cgi?id=454078
------- Additional Comments From nicolas.mailhot(a)laposte.net 2008-07-04 16:41 EST -------
Formal review
OK | MUST: rpmlint must be run on every packag…
$ rpmlint *rpm
khmeros-fonts.noarch: E: zero-length /usr/share/doc/khmeros-fonts/COPYRIGHT.Fedora
2 packages and 0 specfiles checked; 1 errors, 0 warnings.
(self-inflicted error, not the proposed file)
OK | MUST: The package must be named according to the Package…
OK | MUST: The spec file name must match the base package…
OK | MUST: The package must meet the Packaging Guidelines…
OK | MUST: The package must be licensed with a Fedora approved…
OK | MUST: The License field in the package spec file must…
NOK | MUST: If (and only if) the source package includes the…
Don't add licence files not published upstream
- | MUST: The spec file must be written in American English.
OK | MUST: The spec file for the package MUST be legible.
- | MUST: The sources used to build the package must match…
Didn't check the srpm. the spec works fine with the upstream zip
OK | MUST: The package must successfully compile and build…
N/A | MUST: If the package does not successfully compile, build
OK | MUST: All build dependencies must be listed…
N/A | MUST: The spec file MUST handle locales properly…
N/A | MUST: Every binary RPM package which stores shared…
N/A | MUST: If the package is designed to be relocatable…
OK | MUST: A package must own all directories that it creates
OK | MUST: A package must not contain any duplicate files
OK | MUST: Permissions on files must be set properly.
OK | MUST: Each package must have a %clean section
OK | MUST: Each package must consistently use macros
OK | MUST: The package must contain code, or permissable
N/A | MUST: Large documentation files should go in a -doc
OK | MUST: If a package includes something as %doc…
N/A | MUST: Header files must be in a -devel package.
N/A | MUST: Static libraries must be in a -static package.
N/A | MUST: Packages containing pkgconfig(.pc) files must…
N/A | MUST: If a package contains library files with a suffix…
N/A | MUST: In the vast majority of cases, devel packages must…
N/A | MUST: Packages must NOT contain any .la libtool archives,
N/A | MUST: Packages containing GUI applications must include…
OK | MUST: Packages must not own files or directories already
OK | MUST: At the beginning of %install, each package MUST…
OK | MUST: All filenames in rpm packages must be valid UTF-8.
- | SHOULD: If the source package does not include license
text(s) as a separate file from upstream, the packager
SHOULD query upstream to include it.
Please do so
- | SHOULD: The description and summary sections in the…
OK | SHOULD: The reviewer should test that the package builds…
N/A | SHOULD: The package should compile and build into binary…
OK | SHOULD: The reviewer should test that the package…
OK | SHOULD: If scriptlets are used, those scriptlets must…
N/A | SHOULD: Usually, subpackages other than devel should…
N/A | SHOULD: The placement of pkgconfig(.pc) files depends on…
N/A | SHOULD: If the package has file dependencies outside of…
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
15 years, 9 months