Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526607
Nicolas Mailhot <nicolas.mailhot(a)laposte.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody(a)fedoraproject.org |nicolas.mailhot(a)laposte.net
Flag| |fedora-review?,
| |needinfo?(michael.silvanus@
| |gmail.com)
--- Comment #4 from Nicolas Mailhot <nicolas.mailhot(a)laposte.net> 2009-10-01 17:53:24 EDT ---
Thank you for submitting a new font package for review. I hope you'll find the
process smooth and friendly, please do not hesitate to tell us what could be
made better if something bugs you.
Anyway, for the review
1. we use oflb as prefix for openfontlibrary fonts
2. the author claims he created this font in fontforge, so it'd be a good idea
to beg for the sfd file upstream and build the font from source in the rpm
3. there is no licensing trace in the ttf file, and web pages are unfortunately
not future proof. Please ask upstream to release the font in a zip file that
includes a detached .txt licensing file (or at least use the fontforge button
that embeds the OFL text in the .ttf)
4. IMHO this font should be classified as "fantasy" not "monospace" (see
fontconfig-generics.txt in fontpackages-devel)
5. Why do you reference Droid Sans Mono in your fontconfig file? If that's
because you cut and pasted from the Droid file, you have clean and documented
fontconfig templates in fontpackages-devel (in
/usr/share/fontconfig/templates/). The lastest rawhide version is probably the
best reference for anything ≥ F11 (I'll probably push it to F11 if I stop
finding things to improve every other week)
6. IMHO it is wrong to alias Chalkboard or Comic Sans MS if you're not sure
Smonohand is very close both in looks and metrics. The reason being looks only
are not sufficient, if the letters are different sizes documents written will
one of the other fonts will end up repaginated with smonohand. Usually when we
alias a font is much closer than just 'looks like it'
7. 65 is probably too high a prio for a fantasy latin font, 63-64 should be
fine (see fontconfig-priorities.txt)
For a first try this is a nice package, you just need to spend some time
reading the little documentation we have in fontpackages-devel and you'll be
fine.
NEEDINFO till this submission progresses
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526607
--- Comment #3 from Michel Alexandre Salim <michael.silvanus(a)gmail.com> 2009-10-01 12:18:15 EDT ---
Looks like the restore is now complete, and the files are back there. I didn't
even notice the crash!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526607
Sven Lankes <sven(a)lank.es> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sven(a)lank.es
--- Comment #2 from Sven Lankes <sven(a)lank.es> 2009-10-01 09:47:21 EDT ---
The files are not available due to the fedorapeople.org crash.
Could you please re-upload them?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225617
--- Comment #17 from Pravin Satpute <psatpute(a)redhat.com> 2009-10-01 06:04:05 EDT ---
(In reply to comment #16)
> 3. your -fixed subpackage contains font files that declare themselves as
> "Console". These should go in a "console" subpackage
as it has only console fonts in it dropping this subpackage and will have
bitmap-console-fonts subpackage
>
> 6. why do you add a Requires(pre): fontconfig ? We do not require fontconfig in
> font packages. Do you have a special need?
>
> 7. what do you need xorg-x11-font-utils as BR for ?
>
> 8. I think you can specify a different LICENSE field per subpackage, can you
> check with spot how he'd prefer the licensing reported ? (mixed licensing
> packages are a PITA) I feel if it'd be better if each subpackage was tagged
> with just the necessary license info (and included the corresponding license
> files)
>
can you guide me little bit about what is exact LICENSES of fangsongati, just
test is give but not mention which GPL version etc.
> 9. fontconfig will happily use pcf.gz files, please compress your pcf files (if
> you're feeling ambitious ask behdad if he intends to support pcf.xz soon)
>
> That's all for this first partial review, will look more in depth tomorrow
ok, so fontdir will contain pcf.gz file, looks ok
thanks for first review
as we are targeting this for f13 we have some time now :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526633
Ankur Sinha <sanjay.ankur(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fedora-fonts-bugs-list@redh
| |at.com
--- Comment #1 from Ankur Sinha <sanjay.ankur(a)gmail.com> 2009-10-01 02:43:45 EDT ---
hi,
As always, I'm not too sure of the fontconfig. The prio seems okay? I'm not
sure if its a sans-serif or a fantasy, since I can't decide if this font can be
used for long professional texts. It's the Devanagari script, so could be used.
regards,
Ankur
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512079
Ankur Sinha <sanjay.ankur(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-cvs?
--- Comment #8 from Ankur Sinha <sanjay.ankur(a)gmail.com> 2009-10-01 00:58:50 EDT ---
New Package CVS Request
=======================
Package Name: oflb-prociono-fonts
Short Description: A text roman with standard and discretionary ligatures,
class-based kerning
Owners: ankursinha
Branches: F-10 F-11
InitialCC: fonts-sig
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526607
Michel Alexandre Salim <michael.silvanus(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| |https://fedoraproject.org/w
| |iki/SMonohand_Fonts
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526607
Michel Alexandre Salim <michael.silvanus(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fedora-fonts-bugs-list@redh
| |at.com
--- Comment #1 from Michel Alexandre Salim <michael.silvanus(a)gmail.com> 2009-09-30 21:09:00 EDT ---
This is my first font package, so please be very thorough.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.