[Bug 1228865] Review Request: gdouros-anaktoria-fonts - A font based
on "Grecs du roi" and the "First Folio Edition of Shakespeare"
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1228865
--- Comment #6 from Alexander Ploumistos <alex.ploumistos(a)gmail.com> ---
Thank you for taking the time to review this.
Source rpm and spec file updated.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #5)
> Where is the license specified?
There never was a license file. See here, bottom of the page:
https://web.archive.org/web/20150625020428/http://users.teilar.gr/~g1951d/
> %description seems to contain a private use unicode character (1480
> 1561).
Thanks, there was a funny-looking zero, I fixed it in both the spec file and
the metainfo.xml file. By the way, which tool picked that up?
> [ ]: Each %files section contains %defattr if rpm < 4.4
> Note: %defattr present but not needed
But I don't have a %defattr directive, where is this coming from?
> [ ]: Large documentation must go in a -doc subpackage. Large could be size
> (~1MB) or number of files.
> Note: Documentation size is 808960 bytes in 1 files.
> That's borderline. A bit too small to create a separate package.
See comments 1 & 4 here:
https://bugzilla.redhat.com/show_bug.cgi?id=1208842
> Appdata file should be validated in %check
> [https://fedoraproject.org/wiki/Packaging:AppData].
Does this apply to metainfo.xml files? I thought it was just for the
appdata.xml ones.
> $ appstream-util validate-relax
> /usr/share/appdata/gdouros-anaktoria.metainfo.xml
> /usr/share/appdata/gdouros-anaktoria.metainfo.xml: FAILED:
> • markup-invalid : <id> does not have correct extension for kind
> • tag-missing : <extends> is not present
> Validation of files failed
On an F22 system, I'm getting this:
$ appstream-util validate-relax rpmbuild/SOURCES/gdouros-anaktoria.metainfo.xml
rpmbuild/SOURCES/gdouros-anaktoria.metainfo.xml: OK
I can't understand why there would be a problem with the id tag or why the
extends tag would be needed, it does not extend anything.
On what system did you run fedora-review?
I've just noticed that fedora-review on this system creates an F21 package even
though I fed it an F23 source rpm built in mock, is there a setting someplace
that I've missed?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UhHDUUS4r9&a=cc_unsubscribe
8 years, 9 months
[Bug 1228865] Review Request: gdouros-anaktoria-fonts - A font based
on "Grecs du roi" and the "First Folio Edition of Shakespeare"
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1228865
Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nobody(a)fedoraproject.org |zbyszek(a)in.waw.pl
Flags| |fedora-review?
--- Comment #5 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
OK. I guess that's fine: the font is open source and either the author will
re-post it or it will pop up somewhere else. Where is the license specified?
%description seems to contain a private use unicode character (1480
1561).
[ ]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 808960 bytes in 1 files.
That's borderline. A bit too small to create a separate package.
Appdata file should be validated in %check
[https://fedoraproject.org/wiki/Packaging:AppData].
$ appstream-util validate-relax
/usr/share/appdata/gdouros-anaktoria.metainfo.xml
/usr/share/appdata/gdouros-anaktoria.metainfo.xml: FAILED:
• markup-invalid : <id> does not have correct extension for kind
• tag-missing : <extends> is not present
Validation of files failed
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4W20oYQbV2&a=cc_unsubscribe
8 years, 9 months