[Bug 1728307] Review Request: foundation-icons-fonts - Icons web
font
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1728307
Xavier Bachelot <xavier(a)bachelot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |ASSIGNED
Flags|fedora-review+ |fedora-review?
--- Comment #10 from Xavier Bachelot <xavier(a)bachelot.org> ---
(In reply to Robert-André Mauchin from comment #8)
> LGTM, package approved.
Thanks for the review.
(In reply to Nicolas Mailhot from comment #9)
> (In reply to Xavier Bachelot from comment #7)
>
> > - Drop commented out appstream support.
>
> Sorry about that, not wasting time on manual appstream files is perfectly
> fine, they don't contain any info not already present in the rpm package, so
> the next generation of font macros will just generate them (as it should
> have been done in the first place)
>
> I really need to finish this and send it to FPC :(
No worries, it was just a couple lines to remove, not a big deal and much
easier than to grasp what the appstream support is all about. I'll save that
for another time.
Thanks for your help.
--
You are receiving this mail because:
You are on the CC list for the bug.
4 years, 9 months
[Bug 1728307] Review Request: foundation-icons-fonts - Icons web
font
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1728307
--- Comment #9 from Nicolas Mailhot <nicolas.mailhot(a)laposte.net> ---
(In reply to Xavier Bachelot from comment #7)
> - Drop commented out appstream support.
Sorry about that, not wasting time on manual appstream files is perfectly fine,
they don't contain any info not already present in the rpm package, so the next
generation of font macros will just generate them (as it should have been done
in the first place)
I really need to finish this and send it to FPC :(
--
You are receiving this mail because:
You are on the CC list for the bug.
4 years, 9 months