[Bug 1906714] New: Enable OpenType related features with HarfBuzz

https://bugzilla.redhat.com/show_bug.cgi?id=1906714

Bug ID: 1906714
           Summary: Enable OpenType related features with HarfBuzz
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: freetype
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail], [e-mail],
                    [e-mail],
                    [e-mail],
                    [e-mail], [e-mail],
                    [e-mail], [e-mail],
                    [e-mail], [e-mail]
  Target Milestone: ---
    Classification: Fedora

Description of problem:
FreeType has supported some OpenType related features since 2.5.3 by linking
HarfBuzz at the build time, and continue growing more since then.

Although our build keeps disabling this feature, we have Bug#1853937 now and it
is hard to fix without enabling HarfBuzz in FreeType. it may be time to enable
it in Fedora too because it may be stable enough that they spent 6 years or so
since 2.5.3 has been released.

I'm filing this RFE separetely because it would be better informing this as a
f34 Changes proposal and good to keep it on track.

[Bug 1906714] Enable OpenType related features with HarfBuzz

https://bugzilla.redhat.com/show_bug.cgi?id=1906714

Akira TAGOH  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1853937

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1853937
[Bug 1853937] Auto-hinter ignores non-unicode ligatures (e.g. Lato ti, tt)

[Bug 1906714] Enable OpenType related features with HarfBuzz

https://bugzilla.redhat.com/show_bug.cgi?id=1906714

--- Comment #1 from Marek Kašík  ---
Hi,

I agree with the change. But I'm lost with the bootstrap process (I'm sorry
about that, I didn't need it until now). I understand how should the changes
look in the spec file thanks to you but the process of rebuilding freetype
isn't clear to me.

I think it should go this way:

1) bump release
2) build freetype with bootrap on (== without harfbuzz and the build has
~bootstrap suffix)
3) build harfbuzz with the previously build freetype
4) build freetype without bootstrap which will use the previously built
harfbuzz

I'm not sure how to execute 4). Is it by changing the bcond in the spec file to
"without" instead of "with" or by passing a parameter to the build?
Does it need to be manual or do we have an automation for this?
Do we need to do this every time we need to build freetype or harfbuzz?

[Bug 1906714] Enable OpenType related features with HarfBuzz

https://bugzilla.redhat.com/show_bug.cgi?id=1906714

--- Comment #2 from Akira TAGOH  ---
Actually I have same question and not exactly sure how that will be done. but
after looking at some packages that support bootstrap like glibc, I see they
didn't touch a flag in spec file since it has been added. they disable
bootstrap by default and looks like expecting enabling boostrap by --with
bootstrap from rpmbuild side.

[Bug 1906714] Enable OpenType related features with HarfBuzz

https://bugzilla.redhat.com/show_bug.cgi?id=1906714

--- Comment #3 from Marek Kašík  ---
I'll ask some of my colleagues then. Regards

[Bug 1906714] Enable OpenType related features with HarfBuzz

https://bugzilla.redhat.com/show_bug.cgi?id=1906714

Marek Kašík  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #4 from Marek Kašík  ---
I think that I've figured the process out thanks to Jan Grulich and
https://docs.fedoraproject.org/en-US/packaging-guidelines/#bootstrapping.
However I'm not sure whether it is needed to track this as a proposal but if
you think that it is needed we can do this at January as there is time for
these until 19th of January (I don't consider this a System Wide change).

[Bug 1906714] Enable OpenType related features with HarfBuzz

https://bugzilla.redhat.com/show_bug.cgi?id=1906714

--- Comment #5 from Akira TAGOH  ---
Thank you for working on this. I hope this wouldn't negatively affect too much
but that would be nice if we can get more testers and feedback on it by
advertising this with Change proposal since users is somewhat sensitive on the
changes in freetype and rendering.

[Bug 1906714] Enable OpenType related features with HarfBuzz

https://bugzilla.redhat.com/show_bug.cgi?id=1906714

--- Comment #6 from Marek Kašík  ---
I've proposed this at
https://fedoraproject.org/wiki/Changes/EnableHarfBuzzInFreeType.

[Bug 1906714] Enable OpenType related features with HarfBuzz

https://bugzilla.redhat.com/show_bug.cgi?id=1906714

--- Comment #7 from Akira TAGOH  ---
Thank you so much. that looks good to me.

[Bug 1906714] Enable OpenType related features with HarfBuzz

https://bugzilla.redhat.com/show_bug.cgi?id=1906714

Marek Kašík  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
   Fixed In Version|                            |freetype-2.10.4-3.fc34
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2021-02-05 11:48:59

--- Comment #8 from Marek Kašík  ---
I've built the freetype with enabled HarfBuzz support successfully in rawhide.

[Bug 1906714] Enable OpenType related features with HarfBuzz

https://bugzilla.redhat.com/show_bug.cgi?id=1906714

--- Comment #9 from Mamoru TASAKA  ---
Perhaps this is causing the issue: bug 1925922

[Bug 1906714] Enable OpenType related features with HarfBuzz

https://bugzilla.redhat.com/show_bug.cgi?id=1906714

Marek Kašík  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Marek Kašík  ---
*** Bug 1136522 has been marked as a duplicate of this bug. ***