[Bug 1332250] New: Incorrect font configuration

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332250

Bug ID: 1332250
           Summary: Incorrect font configuration
           Product: Fedora
           Version: rawhide
         Component: open-sans-fonts
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail],
                    [e-mail]

When a website requests Open Sans, Firefox uses Comfortaa.  I have both fonts
installed.  I don't know if the following is the cause, because the matching
works correctly with fc-match, but I discovered this and it's still wrong, I
think.

The open-sans-fonts package includes this fontconfig rule:

<alias>
    <family>Open Sans</family>
    <prefer>
      <family>sans-serif</family>
    </prefer>
  </alias>

In my understanding of fontconfig, this is saying "Edit the font family list
for Open Sans and prepend the sans-serif font family" i.e. Open Sans itself is
given *less* priority than all other sans-serif fonts.  The
aajohan-comfortaa-fonts package includes this (correct) rule:

<alias>
     <family>sans-serif</family>
     <prefer>
    <family>Comfortaa</family>
     </prefer>
  </alias>

And so perhaps C being early in the alphabet or perhaps because being the next
fontconfig file in my conf.d (I don't fully understand fontconfig) the combined
effect ends up being "When looking for Open Sans, the first match is sans-serif
which in turn is Comfortaa".

I think the Open Sans rule above should be edited to something closer to the
Comfortaa rule above, like:

<alias>
    <family>sans-serif</family>
     <prefer>
    <family>Open Sans</family>
     </prefer>
 </alias>

The second rule it contains is also wrong, I think, and not like how any other
fonts are configured:

<alias>
    <family>sans-serif</family>
    <default>
      <family>Open Sans</family>
    </default>
  </alias>

Should probably also swap the families like so:

<alias>
    <family>Open Sans</family>
    <default>
      <family>sans-serif</family>
    </default>
  </alias>

This Firefox bug seems relevant but I think this is a bug in the packaged font
configuration and really unrelated to Firefox (I didn't read the whole bug):
https://bugzilla.mozilla.org/show_bug.cgi?id=1245811

[Bug 1332250] Incorrect font configuration

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332250

--- Comment #1 from Petr Vobornik  ---
I don't really understand FontConfig so if somebody knowledgeable can confirm
the change then I can update the config.

[Bug 1332250] Incorrect font configuration

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332250

Alexander Ploumistos  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Alexander Ploumistos  ---
According to
https://www.freedesktop.org/software/fontconfig/fontconfig-user.html
Dag is right.

Also, my first font package, which I inherited from someone else, had a
similarly structured fontconfig.conf file. I have replicated that configuration
in every font package I maintain.

[Bug 1332250] Incorrect font configuration

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332250

--- Comment #3 from Nicolas Mailhot  ---
The correct fontconfig templates for Fedora are documented in
fontpackages-devel (in /usr/share/fontconfig/templates).

They've been audited by the fontconfig maintainer

Bundled explanation files document what the rules do

Please use them strictly. fontpackages-devel is required to build font packages
in Fedora so the examples are not exactly hidden.

[Bug 1332250] Incorrect font configuration

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332250

Dawid Zych  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Dawid Zych  ---
The bug still exists on Fedora 25.
I can confirm that solution provided by Dag fixes the issue.

[Bug 1332250] Incorrect font configuration

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332250

Hin-Tak Leung  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Hin-Tak Leung  ---
It does look like the current config is the opposite of what
basic-font-template.conf recommends. Can we get a fix soon?

[Bug 1332250] Incorrect font configuration

https://bugzilla.redhat.com/show_bug.cgi?id=1332250

--- Comment #7 from Hin-Tak Leung  ---
*** Bug 1349567 has been marked as a duplicate of this bug. ***

[Bug 1332250] Incorrect font configuration

https://bugzilla.redhat.com/show_bug.cgi?id=1332250

Danny Brodzik  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Danny Brodzik  ---
Can confirm this on Fedora 25 with the latest updates. The solution from Dag
works for me as well.

[Bug 1332250] Incorrect font configuration

https://bugzilla.redhat.com/show_bug.cgi?id=1332250

Garrett Mitchener  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Garrett Mitchener  ---
On my system the symptom was that firefox chooses Laconic instead of Open Sans.

As suggested, I changed /etc/fonts/conf.d/60-open-sans.conf to the following
and it seems to be working.

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE fontconfig SYSTEM "../fonts.dtd">
<fontconfig>
 <alias>
    <family>sans-serif</family>
    <prefer>
      <family>Open Sans</family>
    </prefer>
  </alias>
  <alias>
    <family>Open Sans</family>
    <default>
      <family>sans-serif</family>
    </default>
  </alias>
</fontconfig>

[Bug 1332250] Incorrect font configuration

https://bugzilla.redhat.com/show_bug.cgi?id=1332250

--- Comment #10 from Fedora End Of Life  ---
This message is a reminder that Fedora 25 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 25. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '25'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 25 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

[Bug 1332250] Incorrect font configuration

https://bugzilla.redhat.com/show_bug.cgi?id=1332250

Dag Odenhall  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|25                          |27

[Bug 1332250] Incorrect font configuration

https://bugzilla.redhat.com/show_bug.cgi?id=1332250

--- Comment #11 from Dag Odenhall  ---
Confirmed as unchanged in Fedora 27. Haven't tested if Firefox is still
confused by this configuration, but it appears to be incorrect regardless.

[Bug 1332250] Incorrect font configuration

https://bugzilla.redhat.com/show_bug.cgi?id=1332250

--- Comment #12 from Danny Brodzik  ---
Firefox is still confused by the incorrect configuration in Fedora 27, with a
clean OS and font install. The proposed changes by Dag Odenhall fix the problem
for me.

[Bug 1332250] Incorrect font configuration

https://bugzilla.redhat.com/show_bug.cgi?id=1332250

--- Comment #13 from Hin-Tak Leung  ---
Just saw this bug on firefox 57.0.1 on fc27.

[Bug 1332250] Incorrect font configuration

https://bugzilla.redhat.com/show_bug.cgi?id=1332250

Vitaly Zaitsev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Version|27                          |28
              Flags|                            |needinfo?(pvoborni@redhat.c
                   |                            |om)

--- Comment #14 from Vitaly Zaitsev  ---
The problem is still in F28 and Rawhide.

Can you merge pull request
https://src.fedoraproject.org/rpms/open-sans-fonts/pull-request/1 and rebuild
package for F28?

[Bug 1332250] Incorrect font configuration

https://bugzilla.redhat.com/show_bug.cgi?id=1332250

--- Comment #15 from Fedora Update System  ---
open-sans-fonts-1.10-8.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-531ea2315c

[Bug 1332250] Incorrect font configuration

https://bugzilla.redhat.com/show_bug.cgi?id=1332250

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |MODIFIED

[Bug 1332250] Incorrect font configuration

https://bugzilla.redhat.com/show_bug.cgi?id=1332250

Petr Vobornik  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(pvoborni@redhat.c |
                   |om)                         |

--- Comment #16 from Petr Vobornik  ---
Per, previous automated comments, a build with the fix is available for F28 and
rawhide.

[Bug 1332250] Incorrect font configuration

https://bugzilla.redhat.com/show_bug.cgi?id=1332250

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #17 from Fedora Update System  ---
open-sans-fonts-1.10-8.fc28 has been pushed to the Fedora 28 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-531ea2315c

[Bug 1332250] Incorrect font configuration

https://bugzilla.redhat.com/show_bug.cgi?id=1332250

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |open-sans-fonts-1.10-8.fc28
         Resolution|---                         |ERRATA
        Last Closed|                            |2018-06-13 11:18:17

--- Comment #18 from Fedora Update System  ---
open-sans-fonts-1.10-8.fc28 has been pushed to the Fedora 28 stable repository.
If problems still persist, please make note of it in this bug report.