Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Useless font auto-installer calls
https://bugzilla.redhat.com/show_bug.cgi?id=531105
Summary: Useless font auto-installer calls Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: fontconfig AssignedTo: besfahbo@redhat.com ReportedBy: nicolas.mailhot@laposte.net QAContact: extras-qa@fedoraproject.org CC: besfahbo@redhat.com, fedora-fonts-bugs-list@redhat.com Classification: Fedora
The font stack triggers the PK font auto-installer for stuff like N'ko or Ancient Persian for which fontconfig has no orthography
Therefore, those calls will never succeed and the user is bothered for no good reason
fc-query/cache should also generate PK metadata for unicode blocks, so that when the font stack needs a glyph which is not part of an orthography, PK can search for fonts that cover the corresponding unicode block (stuff like symbols will probably never make it in an orth)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=531105
Behdad Esfahbod besfahbo@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |richard@hughsie.com, | |smparrish@gmail.com Component|fontconfig |PackageKit AssignedTo|besfahbo@redhat.com |richard@hughsie.com
--- Comment #1 from Behdad Esfahbod besfahbo@redhat.com 2009-10-26 18:17:15 EDT --- (In reply to comment #0)
The font stack triggers the PK font auto-installer for stuff like N'ko or Ancient Persian for which fontconfig has no orthography
Therefore, those calls will never succeed and the user is bothered for no good reason
This is surely a bug. And easy to fix, in at least two ways on the PK side:
1) Only show a dialog if there's any font supporting that language. This was supposed to be the default. Not sure why it wasn't implemented this way.
2) In the GTK+ module, use FcLangGetCharset() to check whether fc knows about the language.
IMO both of them should be done.
fc-query/cache should also generate PK metadata for unicode blocks, so that when the font stack needs a glyph which is not part of an orthography, PK can search for fonts that cover the corresponding unicode block (stuff like symbols will probably never make it in an orth)
Not a huge fan of this. Lets add orth's where missing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=531105
--- Comment #2 from Nicolas Mailhot nicolas.mailhot@laposte.net 2009-10-26 18:35:46 EDT --- (In reply to comment #1)
(In reply to comment #0)
The font stack triggers the PK font auto-installer for stuff like N'ko or Ancient Persian for which fontconfig has no orthography
Therefore, those calls will never succeed and the user is bothered for no good reason
This is surely a bug. And easy to fix, in at least two ways on the PK side:
- Only show a dialog if there's any font supporting that language. This was
supposed to be the default. Not sure why it wasn't implemented this way.
PK asks for permission to search for fonts, and since it has not searched yet, it does not know if there's any font supporting that language yet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=531105
Richard Hughes rhughes@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rhughes@redhat.com Flag| |needinfo?
--- Comment #3 from Richard Hughes rhughes@redhat.com 2009-10-27 06:32:25 EDT --- (In reply to comment #1)
- Only show a dialog if there's any font supporting that language. This was
supposed to be the default. Not sure why it wasn't implemented this way.
We're working with the yum guys to make this possible.
- In the GTK+ module, use FcLangGetCharset() to check whether fc knows about
the language.
At what point should the module call FcLangGetCharset? Somewhere like http://cgit.freedesktop.org/packagekit/tree/contrib/gtk-module/pk-gtk-module... ?
Richard.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=531105
Nicolas Mailhot nicolas.mailhot@laposte.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo? |
--- Comment #4 from Nicolas Mailhot nicolas.mailhot@laposte.net 2009-10-27 06:58:39 EDT --- (In reply to comment #1)
(In reply to comment #0)
fc-query/cache should also generate PK metadata for unicode blocks, so that when the font stack needs a glyph which is not part of an orthography, PK can search for fonts that cover the corresponding unicode block (stuff like symbols will probably never make it in an orth)
Not a huge fan of this. Lets add orth's where missing.
So if I submitted a fontconfig rfe to add an .orth for math symbols, engineering symbols, dingbats, ancient persian, etc would it be accepted? If yes what namespace should be used for those orths? I think ancient scripts have standardised ids ISO-side, but symbols?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=531105
Nicolas Mailhot nicolas.mailhot@laposte.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(besfahbo@redhat.c | |om)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=531105
Behdad Esfahbod besfahbo@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(besfahbo@redhat.c | |om) |
--- Comment #5 from Behdad Esfahbod besfahbo@redhat.com 2009-10-28 20:54:02 EDT --- Created an attachment (id=366524) --> (https://bugzilla.redhat.com/attachment.cgi?id=366524) Untested patch
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=531105
--- Comment #6 from Behdad Esfahbod besfahbo@redhat.com 2009-10-28 20:55:23 EDT --- (In reply to comment #4)
(In reply to comment #1)
(In reply to comment #0)
fc-query/cache should also generate PK metadata for unicode blocks, so that when the font stack needs a glyph which is not part of an orthography, PK can search for fonts that cover the corresponding unicode block (stuff like symbols will probably never make it in an orth)
Not a huge fan of this. Lets add orth's where missing.
So if I submitted a fontconfig rfe to add an .orth for math symbols, engineering symbols, dingbats, ancient persian, etc would it be accepted? If yes what namespace should be used for those orths? I think ancient scripts have standardised ids ISO-side, but symbols?
Oh, that's what you meant. I believe there's a bug upstream about it? That's a separate issue and we need to figure it out, yeah.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=531105
Richard Hughes rhughes@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |needinfo?
--- Comment #7 from Richard Hughes rhughes@redhat.com 2009-10-29 07:02:42 EDT --- Please can you try the build of PackageKit here: http://koji.fedoraproject.org/koji/taskinfo?taskID=1776157
You will need to reboot your computer to ensure the packagekitd process has been restarted. Please provide feedback to whether this build fixes this bug. Thanks.
Richard.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=531105
Matthias Clasen mclasen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED CC| |mclasen@redhat.com Flag|needinfo? |
--- Comment #8 from Matthias Clasen mclasen@redhat.com 2009-10-31 00:32:46 EDT --- Tag has been requested
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=531105
Richard Hughes rhughes@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution| |CURRENTRELEASE
fonts-bugs@lists.fedoraproject.org