[Bug 903288] New: use -fno-strict-aliasing to fix some compilation warnings

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903288

Bug ID: 903288
           Summary: use -fno-strict-aliasing to fix some compilation
                    warnings
           Product: Fedora
           Version: 18
         Component: fontforge
          Severity: medium
          Priority: unspecified
          Reporter: [e-mail]

Created attachment 686075
  --> https://bugzilla.redhat.com/attachment.cgi?id=686075&action=edit
add -fno-strict-aliasing to every needed Makefile

Description of problem:
I see fontforge build.log showing
ufo.c:1027:2: warning: dereferencing type-punned pointer will break
strict-aliasing rules [-Wstrict-aliasing]
ufo.c:1031:2: warning: dereferencing type-punned pointer will break
strict-aliasing rules [-Wstrict-aliasing]

spec file shows -fno-strict-aliasing added to CFLAGS but its not in effect.
Attached patch will modify each needed Makefile to add that flag

Also, attached patch removes some makefile rules as they are really not needed

Version-Release number of selected component (if applicable):
fontforge-20120731b-2.fc18.x86_64

How reproducible:
always

Steps to Reproduce:
1.
2.
3.

Actual results:

Expected results:

Additional info:

[Bug 903288] use -fno-strict-aliasing to fix some compilation warnings

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903288

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from Kevin Fenzi  ---
Seems fine to me... rawhide only?

Might submit upstream as well?

[Bug 903288] use -fno-strict-aliasing to fix some compilation warnings

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903288

--- Comment #2 from Parag  ---
Actually I need this fix for f18 also. I see that upstream sourcecode on github
has been changed a lot and Makefiles are re-written and accepting additional
compiler flags correctly. so no need to upstream this patch.

[Bug 903288] use -fno-strict-aliasing to fix some compilation warnings

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=903288

Parag  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #686075|0                           |1
        is obsolete|                            |

--- Comment #3 from Parag  ---
Created attachment 788781
  --> https://bugzilla.redhat.com/attachment.cgi?id=788781&action=edit
Modified spec file to address some issues

Issues that this patch will solve

1) bogus date changelog messages

2) adds cflag -Wstrict-aliasing

3) Fix compile time po files link error messages by removing makefile rule
e.g. some of these messages in build.log
ln -s ./po/*.po po
ln: failed to create symbolic link 'po/ca.po': File exists
ln: failed to create symbolic link 'po/de.po': File exists
ln: failed to create symbolic link 'po/el.po': File exists
ln: failed to create symbolic link 'po/en_GB.po': File exists

4) Fix compile time install error messages by removing makefile rule
/usr/bin/install: cannot stat './htdocs/flags/*': No such file or directory
make[1]: [install_docs] Error 1 (ignored)
/usr/bin/install: cannot stat './htdocs/ja/*': No such file or directory
make[1]: [install_docs] Error 1 (ignored)

[Bug 903288] use -Wstrict-aliasing cflag to fix some compilation warnings

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=903288

Parag  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|use -fno-strict-aliasing to |use -Wstrict-aliasing cflag
                   |fix some compilation        |to fix some compilation
                   |warnings                    |warnings

[Bug 903288] use -Wstrict-aliasing cflag to fix some compilation warnings

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=903288

Parag  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18                          |rawhide

[Bug 903288] use -Wstrict-aliasing cflag to fix some compilation warnings

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=903288

--- Comment #4 from Parag  ---
can this patch be applied to master please?

[Bug 903288] use -Wstrict-aliasing cflag to fix some compilation warnings

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=903288

--- Comment #5 from Kevin Fenzi  ---
I went to apply this and then realized that I didn't approve your acls on the
package. ;)

Must have missed when you applied.

I have approved them, can you apply this yourself? Or would you like me to?

[Bug 903288] use -Wstrict-aliasing cflag to fix some compilation warnings

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=903288

--- Comment #6 from Parag  ---
Thank you for approving my acls. I will commit now proposed spec file patch and
build new package.

[Bug 903288] use -Wstrict-aliasing cflag to fix some compilation warnings

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=903288

Parag  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
   Fixed In Version|                            |fontforge-20120731b-9.fc21
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2013-08-22 10:10:36

--- Comment #7 from Parag  ---
Fixed in fontforge-20120731b-9.fc21. Closing this bug now.

[Bug 903288] use -Wstrict-aliasing cflag to fix some compilation warnings

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=903288

Parag  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |ASSIGNED
         Resolution|RAWHIDE                     |---
           Keywords|                            |Reopened

--- Comment #8 from Parag  ---
I just come to know to fix warning messages given in description comment I
should have used cflag -fno-strict-aliasing and not -Wstrict-aliasing. Also,
tested successfully rpmdiff results for this -fno-strict-aliasing cflag. Sorry
I got confused in between as I was actually decided to use -fno-strict-aliasing
but then something made me to change it to -Wstrict-aliasing.

I will build new package tomorrow.

[Bug 903288] use -fno-strict-aliasing cflag to fix some compilation warnings

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=903288

Parag  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|use -Wstrict-aliasing cflag |use -fno-strict-aliasing
                   |to fix some compilation     |cflag to fix some
                   |warnings                    |compilation warnings

[Bug 903288] use -fno-strict-aliasing cflag to fix some compilation warnings

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=903288

Parag  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |NEXTRELEASE
        Last Closed|2013-08-22 10:10:36         |2013-11-28 00:54:03

--- Comment #9 from Parag  ---
This is already fixed in fontforge-20120731b-10.fc21