[Bug 495399] Review Request: NotCourier-Sans-sfd-fonts - NotCourier Sans is a re-interpretation of Nimbus Mono.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=495399

Ankur Sinha  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(sanjay.ankur@gmai |
                   |l.com)                      |

--- Comment #4 from Ankur Sinha   2009-05-21 13:52:45 EDT ---
(In reply to comment #3)
> First review:
> W: file-not-utf8
>
> /usr/share/doc/NotCourier-Sans-sfd-fonts-20080906/FONTLOG.txt
> ⇒ please use iconv to fix this file's encoding (you have an example in sil
> andika, make sure you've the right source encoding though)
> please use lowercase package naming only as requested by the fonts packaging
>
> guidelines
>
> please add the oflb- foundry prefix to the package name
>
> unless the fonts authors asked you to, I don't thing the -sfd postfix is
>
> really needed
>
> your URL does not work
>
> it seems upstreams versions this font properly, so you can use a real
>
> version instead of a timestamp (current is 1.1)
>
> I'd drop the first § of your description
>
> the font is derived from a GPL font so it must stay GPL. Upstream has
>
> already fixed this in its last release (do not forget to update your %doc)
> Be very careful to use the exact name the font declares in your fontconfig
>
> file. For version 1.1, it will be "NotCourierSans"
> since the fonts are missing an italic face, I wouldn't stack them at 60 in
>
> fontconfig, 61 or 62 would be better
>
> Anyway that's all for now, thank you for continuing to package Fedora fonts

bah... they edited it all on may 17.. I'll redo the package..