Peer review of my Python script?

[Justin W. Flory]

Hey all,

Hope everyone's summers are going well, wherever you all happen to be!

I was working on some side projects this weekend, and since I know a lot
of Pythonistas are floating around #rit-foss, I thought I'd ask here for
some feedback on a Python script I put together tonight. I was hoping to
get some feedback on it before I actually put it to use, as I'll be
running it against a few thousand files, and if I made a silly mistake,
it would be better to stop it early than to just "send it to prod". :)

There's more details about the script and how I plan to use it in the
pull request.

If anyone with even a little bit of Python knowledge could check out my
PR and give me some feedback on my script, that would be very
appreciated! I tried to keep it easy to read as well. Thanks all.

https://github.com/jflory7/infrastructure/pull/6

[Daniel Wysocki (RIT Student)]

​Why write a python script for this? It just looks like you rewrote

*sed -i 's/old/new/g' input.txt*

[Justin W. Flory]

On 06/25/2017 08:23 PM, Daniel Wysocki (RIT Student) wrote:
> ​Why write a python script for this? It just looks like you rewrote
>
> /sed -i 's/old/new/g' input.txt/

Yeah, in retrospect, this would have been much simpler. But I guess I
was looking for an excuse to do some sort of Python project and went to
that by default. Thanks for pointing this out anyways, I guess I should
have considered a more simpler approach for a pretty simple problem.