[freeipa PR#802][opened] Improve cert messages some more + do that for KDC certs as well
by stlaz
URL: https://github.com/freeipa/freeipa/pull/802
Author: stlaz
Title: #802: Improve cert messages some more + do that for KDC certs as well
Action: opened
PR body:
"""
Some of the previous error message handling would not work in
a locale different from English so we just output the error message we get
from `certutil`.
Also, since this was previously done, there is now kdc cert validation that is
different from the others so make the error messages more verbose there.
OpenSSL prints quite verbose messages so you may want to grab only a
part of it, let me know what your opinion is.
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/802/head:pr802
git checkout pr802
6 years, 3 months
[freeipa PR#812][opened] Refactoring cert-find to use API call directly instead of using
by felipevolpone
URL: https://github.com/freeipa/freeipa/pull/812
Author: felipevolpone
Title: #812: Refactoring cert-find to use API call directly instead of using
Action: opened
PR body:
"""
Refactoring cert-find to use API calls directly instead of using raw LDAP search.
Upstream ticket: https://pagure.io/freeipa/issue/6948
I removed the raw LDAP search and used the API directly. In the old code, the call ` self.obj._owners()` returns `service, hots and user`. However, when testing the code, only the service was being used, so I made it only use the service API.
If there another scenario where `user and host` are used, I thought to do something like:
```python
for owner in self.obj._owners():
api_name = owner.name
response = api.Command[api_name+'_find'](options[api_name])
... # continues
```
Is that correct?
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/812/head:pr812
git checkout pr812
6 years, 3 months