URL: https://github.com/freeipa/freeipa/pull/821
Author: martbab
Title: #821: fix incorrect suffix handling in topology checks
Action: opened
PR body:
"""
When trying to delete a partially removed master entry lacking
'iparepltopomanagedsuffix' attribute, the code that tries to retrieve
tha value for further computations passes None and causes unhandled
internal errors.
If the attribute is empty or not present, we should return empty list
instead as to not break calling cod attribute, the code that tries to
retrieve tha value for further computations passes None and causes
unhandled internal errors. We should return empty list instead.
https://pagure.io/freeipa/issue/6965
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/821/head:pr821
git checkout pr821
URL: https://github.com/freeipa/freeipa/pull/851
Author: abbra
Title: #851: ipa-kdb: add pkinit authentication indicator in case of a successful certauth
Action: opened
PR body:
"""
We automatically add 'otp' and 'radius' authentication indicators when
pre-authentication with OTP or RADIUS did succeed. Do the same for
certauth-based pre-authentication (PKINIT).
A default PKINIT configuration does not add any authentication
indicators unless 'pkinit_indicator = pkinit' is set in kdc.conf.
Unfortunately, modifying kdc.conf automatically is a bit more
complicated than modifying krb5.conf. Given that we have 'otp' and
'radius' authentication indicators also defined in the code not in the
kdc.conf, this change is following an established trend.
SSSD certauth interface does not provide additional information about
which rule(s) succeeded in matching the incoming certificate. Thus,
there is not much information we can automatically provide in the
indicator. It would be good to generate indicators that include some
information from the certmapping rules in future but for now a single
'pkinit' indicator is enough.
Fixes https://pagure.io/freeipa/issue/6736
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/851/head:pr851
git checkout pr851
URL: https://github.com/freeipa/freeipa/pull/812
Author: felipevolpone
Title: #812: Refactoring cert-find to use API call directly instead of using
Action: opened
PR body:
"""
Refactoring cert-find to use API calls directly instead of using raw LDAP search.
Upstream ticket: https://pagure.io/freeipa/issue/6948
I removed the raw LDAP search and used the API directly. In the old code, the call ` self.obj._owners()` returns `service, hots and user`. However, when testing the code, only the service was being used, so I made it only use the service API.
If there another scenario where `user and host` are used, I thought to do something like:
```python
for owner in self.obj._owners():
api_name = owner.name
response = api.Command[api_name+'_find'](options[api_name])
... # continues
```
Is that correct?
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/812/head:pr812
git checkout pr812
URL: https://github.com/freeipa/freeipa/pull/818
Author: stlaz
Title: #818: Avoid possible recursion in RPC call from client
Action: opened
PR body:
"""
This commit removes recursion which may lack end condition.
https://pagure.io/freeipa/issue/6796
===============================
This is my try to fix ^--. The methods and their arguments in the module are very poorly documented (they are not documented), so I just hope I can initialize the variables used in logs prior to the cycle.
I also think this actually relates more to https://pagure.io/freeipa/issue/6775 than the ticket mentioned here and that the person "fixing" https://pagure.io/freeipa/issue/6796 messed up the tickets but it's hopefully OK to fix it this way.
Aside from just moving everything into a cycle, I also improved logging a bit and had same error handling for different errors merged into one `except` block (`SSLError`, `socket.error`).
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/818/head:pr818
git checkout pr818
URL: https://github.com/freeipa/freeipa/pull/701
Title: #701: ipa help doesn't always work
neffs commented:
"""
Not sure why pylint is reporting this, it looks fine to me and I didn't change this function.
```python
if isinstance(self._help, bytes):
self._help = json.loads(self._help.decode('utf-8'))
```
maybe we can trick it with a change like this (similar to read_namespace_member):
```python
value = self._help
if isinstance(value, bytes):
self._help = json.loads(value.decode('utf-8'))
```
"""
See the full comment at https://github.com/freeipa/freeipa/pull/701#issuecomment-304273513
URL: https://github.com/freeipa/freeipa/pull/844
Author: frasertweedale
Title: #844: py3: fix regression in schemaupdate
Action: opened
PR body:
"""
The python-ldap classes that process schema definitions require a
unicode string, not a byte string. A recent py3 compatibility fix
(d89de4219d0e8ee33e81d6b6d1bc6c22ac9ffbaa) changed the constructor
argument to a unicode string to dispel a warning, but this broke
schema update. Change it back to a bytestring.
Part of: https://fedorahosted.org/freeipa/ticket/4985
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/844/head:pr844
git checkout pr844
URL: https://github.com/freeipa/freeipa/pull/803
Author: tomaskrizek
Title: #803: ipatests: add systemd journal collection for multihost tests
Action: opened
PR body:
"""
Some messages are only logged in journal. Collection of journal
makes debugging failed tests from logs easier.
Fixes: https://pagure.io/freeipa/issue/6971
Signed-off-by: Tomas Krizek <tkrizek(a)redhat.com>
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/803/head:pr803
git checkout pr803
URL: https://github.com/freeipa/freeipa/pull/824
Author: frasertweedale
Title: #824: ca-add: validate Subject DN name attributes
Action: opened
PR body:
"""
If the Subject DN is syntactically valid but contains unrecognised
name attributes, FreeIPA accepts it but Dogtag rejects it, returning
status 400 and causing the framework to raise RemoteRetrieveError.
Update the ca-add command to perform some additional validation on
the user-supplied Subject DN, making sure that we recognise all the
attributes.
Fixes: https://pagure.io/freeipa/issue/6987
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/824/head:pr824
git checkout pr824