[Freeipa-devel] [freeipa PR#3095][opened] [Backport][ipa-4-6] Consider configured servers as valid

[tiran]

   URL: https://github.com/freeipa/freeipa/pull/3095
Author: tiran
 Title: #3095: [Backport][ipa-4-6] Consider configured servers as valid
Action: opened

PR body:
"""
Manual backport of PR #3093 

Under some conditions, ipa config-show and several other commands were
failing with error message:

  ERROR: invalid 'PKINIT enabled server': all masters must have IPA master role
enabled

Amongst others the issue can be caused by a broken installation, when
some services are left in state 'configuredServices'. The problem even
block uninstallation or removal of replicas. Now configured servers are
also consider valid providers for associated roles.

A new test verifies that config-show works with hidden and configured HTTP
service.

Remark: The original intent of the sanity check is no longer clear to me. I
think it was used to very that all services can be started by ipactl.
Since ipactl starts hidden, configured, and enabled services, the new
logic reflect the fact, too.

Fixes: https://pagure.io/freeipa/issue/7929
Signed-off-by: Christian Heimes <cheimes(a)redhat.com&gt;
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/3095/head:pr3095
git checkout pr3095